From: Dajun Jin <adajunjin@gmail.com>
To: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
robh+dt@kernel.org, frowand.list@gmail.com
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org
Subject: [PATCH] drivers/of/of_mdio.c:fix of_mdiobus_register()
Date: Mon, 2 Mar 2020 20:24:21 -0800 [thread overview]
Message-ID: <20200303042421.23050-1-adajunjin@gmail.com> (raw)
In-Reply-To: <20200302175759.GD24912@lunn.ch>
When registers a phy_device successful, should terminate the loop
or the phy_device would be registered in other addr. If there are
multiple PHYs without reg properties, it will go wrong.
Signed-off-by: Dajun Jin <adajunjin@gmail.com>
---
Hi Andrew, Thanks for your review.
drivers/of/of_mdio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
index 8270bbf505fb..9f982c0627a0 100644
--- a/drivers/of/of_mdio.c
+++ b/drivers/of/of_mdio.c
@@ -306,6 +306,7 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np)
rc = of_mdiobus_register_phy(mdio, child, addr);
if (rc && rc != -ENODEV)
goto unregister;
+ break;
}
}
}
--
2.17.1
next prev parent reply other threads:[~2020-03-03 4:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-01 16:41 [PATCH] drivers/of/of_mdio.c:fix of_mdiobus_register() Dajun Jin
2020-03-01 16:50 ` Andrew Lunn
2020-03-02 17:29 ` Dajun Jin
2020-03-02 17:57 ` Andrew Lunn
2020-03-02 18:38 ` Russell King - ARM Linux admin
2020-03-03 4:24 ` Dajun Jin [this message]
2020-03-03 22:02 ` Andrew Lunn
2020-03-04 3:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200303042421.23050-1-adajunjin@gmail.com \
--to=adajunjin@gmail.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).