From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEDD6C10F26 for ; Sat, 7 Mar 2020 02:43:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B861C20714 for ; Sat, 7 Mar 2020 02:43:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pk5kyEk9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726704AbgCGCnG (ORCPT ); Fri, 6 Mar 2020 21:43:06 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:34778 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726245AbgCGCnF (ORCPT ); Fri, 6 Mar 2020 21:43:05 -0500 Received: by mail-pg1-f193.google.com with SMTP id t3so1946420pgn.1 for ; Fri, 06 Mar 2020 18:43:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1gdPrM7L3JdZc/DG08O9ahVcD28LXiincmgoBfc8Mlk=; b=pk5kyEk9yONh7dBZ4flJDx27Aj9j4jpOizczWG9giJCpqjVhUweWm+DHF8gCoFgpBc wJNHcO3UProRW0mz7dSaSKbsVZ/Dp2KLPG0170LTxpWi6qwtLmtGmhTP2yIiZ3WG0x/W +Hr0y4Zq6JepLXz7XJgwpdwOPIWx2m/vxqj+7uhNH+4wYoV5WNFkw4hdQxMfCZwFBqQv mboRdDlqz34LKHiz2jC0pCgBH1dpMeJak8hCbPB/sZ2N5T0LjHkyYvw3/SqAE37eRRWg hP/uviKv6/4QpaIMP0scsFPli5lTx4pAJZs/iyjlAlPR9Q0EFMn+o0Ikdpd7HAsvDT72 tlyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1gdPrM7L3JdZc/DG08O9ahVcD28LXiincmgoBfc8Mlk=; b=XQoZDKA0GHPXY+0zsf0ABemsFsCWNpZinv62+DxblZoNvC7J9sSiKaOzsIKXhZ9sjz WWI5p2KCu76IjVR2EYO7WZqykqEwhvqDmmejZevR8M/Hx3yqOTk/2BAxVt5dgqzIM4EY WzEAh/761/2aR6IHkN43NPjkNQOa/oiEjOCqIm72zxJvXWg9c2VEdgN9PHzyTbjQJlbF gIL0iTTDmtbXcxC2IIEi/WplHrBoFgpYTRXyUkAHeZpClKaRWAaglzvN2TfxJ/lgGRVI qYXCcJRrbyIxX4WGp0ZpMyVRK5LNARb8mVI0bt5UAPDOmsYtJutRUekCmrZb3PmzFpQJ yhWg== X-Gm-Message-State: ANhLgQ2/ftBTyJC7ApG8z/UhuqR9u0KOR0PJGedNGkPUtm0mo1LRdWTR gZQLy8RvTveHj/b9/D6mMTqyyg== X-Google-Smtp-Source: ADFU+vuzaPV2bzk0eY5etm8MBkQwXVV+JqsNaT+Nx+n8UshkHyDQtbFM8E58qN3eCImTFJd4eK/0kw== X-Received: by 2002:a63:da45:: with SMTP id l5mr5780622pgj.273.1583548983410; Fri, 06 Mar 2020 18:43:03 -0800 (PST) Received: from builder (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id h132sm33211291pfe.118.2020.03.06.18.43.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2020 18:43:02 -0800 (PST) Date: Fri, 6 Mar 2020 18:43:00 -0800 From: Bjorn Andersson To: Srinivas Kandagatla Cc: agross@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] arm64: dts: qcom: c630: Enable audio support Message-ID: <20200307024300.GD1094083@builder> References: <20200305145344.14670-1-srinivas.kandagatla@linaro.org> <20200305145344.14670-3-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200305145344.14670-3-srinivas.kandagatla@linaro.org> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu 05 Mar 06:53 PST 2020, Srinivas Kandagatla wrote: > This patch add support to audio via WSA881x Speakers and Headset. > > Signed-off-by: Srinivas Kandagatla > --- > .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 91 +++++++++++++++++++ > 1 file changed, 91 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > index b255be3a4a0a..99f5836b9331 100644 > --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > @@ -8,6 +8,8 @@ > /dts-v1/; > > #include > +#include > +#include > #include "sdm845.dtsi" > #include "pm8998.dtsi" > > @@ -353,6 +355,95 @@ > status = "okay"; > }; > > +&slim_msm { > + ngd@1 { > + wcd9340: codec@1{ Afaict this extends the &wcd9340 defined in sdm845.dtsi, so you should be able to just reference &wcd9340 here instead. > + clock-names = "extclk"; > + clocks = <&rpmhcc RPMH_LN_BB_CLK2>; > + vdd-buck-supply = <&vreg_s4a_1p8>; > + vdd-buck-sido-supply = <&vreg_s4a_1p8>; > + vdd-tx-supply = <&vreg_s4a_1p8>; > + vdd-rx-supply = <&vreg_s4a_1p8>; > + vdd-io-supply = <&vreg_s4a_1p8>; > + swm: swm@c85 { This too extends the node from sdm845.dtsi, so reference it by label (and perhaps give it a label to indicate that this is the wcd9340_swm? > + left_spkr:wsa8810-left{ Space after ':', unit address on the node name and then perhaps just give the node a more generic name? Something like: left_spkr: amplifier@0 { > + compatible = "sdw10217211000"; > + reg = <0 3>; > + powerdown-gpios = <&wcdpinctrl 2 0>; s/0/GPIO_ACTIVE_HIGH/ > + #thermal-sensor-cells = <0>; > + sound-name-prefix = "SpkrLeft"; > + #sound-dai-cells = <0>; > + }; > + > + right_spkr:wsa8810-right{ > + compatible = "sdw10217211000"; > + powerdown-gpios = <&wcdpinctrl 3 0>; > + reg = <0 4>; > + #thermal-sensor-cells = <0>; > + sound-name-prefix = "SpkrRight"; > + #sound-dai-cells = <0>; > + }; > + }; > + > + }; > + }; > +}; Regards, Bjorn