From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A99D6C3F2C6 for ; Sat, 7 Mar 2020 11:41:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8D9462073D for ; Sat, 7 Mar 2020 11:41:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726360AbgCGLlA (ORCPT ); Sat, 7 Mar 2020 06:41:00 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:35686 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726283AbgCGLk7 (ORCPT ); Sat, 7 Mar 2020 06:40:59 -0500 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id CFB902002D; Sat, 7 Mar 2020 12:40:55 +0100 (CET) Date: Sat, 7 Mar 2020 12:40:54 +0100 From: Sam Ravnborg To: Krishna Manikandan Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, seanpaul@chromium.org, kalyan_t@codeaurora.org, hoegsberg@chromium.org Subject: Re: [v1] dt-bindings: msm: disp: add yaml schemas for DPU and DSI bindings Message-ID: <20200307114054.GA564@ravnborg.org> References: <1583494560-25336-1-git-send-email-mkrishn@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1583494560-25336-1-git-send-email-mkrishn@codeaurora.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=LpQP-O61AAAA:8 a=gEfo2CItAAAA:8 a=nY4iuGU7CXqHoBgY49wA:9 a=UqWAcN0MMYTXwVMZ:21 a=A81lDmqo7XWCXIhH:21 a=CjuIK1q_8ugA:10 a=pioyyrs4ZptJ924tMmac:22 a=sptkURWiP4Gy88Gu7hUp:22 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Krishna. Thanks for these bindings files. On Fri, Mar 06, 2020 at 05:06:00PM +0530, Krishna Manikandan wrote: > MSM Mobile Display Subsytem(MDSS) encapsulates sub-blocks > like DPU display controller, DSI etc. Add YAML schema > for the device tree bindings for the same. > > Signed-off-by: Krishna Manikandan > --- > .../bindings/display/msm/dpu-sc7180.yaml | 269 +++++++++++++++ > .../bindings/display/msm/dpu-sdm845.yaml | 265 +++++++++++++++ > .../bindings/display/msm/dsi-sc7180.yaml | 369 +++++++++++++++++++++ > .../bindings/display/msm/dsi-sdm845.yaml | 369 +++++++++++++++++++++ > 4 files changed, 1272 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml > create mode 100644 Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml > create mode 100644 Documentation/devicetree/bindings/display/msm/dsi-sc7180.yaml > create mode 100644 Documentation/devicetree/bindings/display/msm/dsi-sdm845.yaml > > diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml > new file mode 100644 > index 0000000..3d1d9b8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml > @@ -0,0 +1,269 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/msm/dpu-sc7180.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Description of Qualcomm Display Dpu dt properties. Try to be cossistent in capitilization of Dpu versus DPU > + > +maintainers: > + - Krishna Manikandan > + > +description: | > + Device tree bindings for MSM Mobile Display Subsytem(MDSS) that encapsulates > + sub-blocks like DPU display controller, DSI and DP interfaces etc. Device tree > + bindings of MDSS and DPU are mentioned for SC7180 target. Bindings should use an indent of two spaces. This is what is used in the example schema and the de-facto standard. One space indent makes it very hard to follow the indent. For examples the indent varies. From 2 spaces to 8 spaces. I often use 4 spaces as 2 spaces is not enough when it spans several lines. But there is nothing fixed there. > + > +properties: > + "mdss": > + type: object > + description: | > + Node containing MDSS that encapsulated sub-blocks like DPU, DSI and DP > + interfaces. > + > + properties: > + compatible: > + items: > + - const: qcom,sc7180-mdss > + reg: > + description: | > + Physical base address and length of controller's registers. Add empty line between properties (empty line before reg:). > + > + reg-names: > + description: | > + Names for different register regions defined above. The required region > + is mentioned below. > + items: > + - const: mdss > + > + power-domains: > + description: | > + A power domain consumer specifier according to > + Documentation/devicetree/bindings/power/power_domain.txt. Should this be power-domain.yaml? > + > + clocks: > + description: | > + List of clock specifiers for clocks needed by the device. Do not use "|" unless required. Fine to have text on same line as description: . Sam