From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ACCDC10F27 for ; Mon, 9 Mar 2020 07:12:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C861206D5 for ; Mon, 9 Mar 2020 07:12:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tR8cA0V6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726368AbgCIHMb (ORCPT ); Mon, 9 Mar 2020 03:12:31 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:40670 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726248AbgCIHMb (ORCPT ); Mon, 9 Mar 2020 03:12:31 -0400 Received: by mail-wr1-f65.google.com with SMTP id p2so8797100wrw.7 for ; Mon, 09 Mar 2020 00:12:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Jx5Fj/KqKcbpxqyibs51BThSAgjts5OPNkpxf24XLEw=; b=tR8cA0V6wn3IXu7I5PIZbj2+RF0mwRgQrGHbYq2MPnA2DeBAeU3Vi0+83xqTsrIsTM n+V2qGUg6b2Rp3XceJES5C57ra7qrzdmlyIeTQG7Ud2SH6JUuiXb5Vg9twxkeRAMG5+4 9e9zU3IEUWN3W26ywuTVjRnfUGLDPYmKQbaTQMiDFvoiXOegtNxGZh8zk3fbHJjg8vbB Oic0kHkQWmKs7iZ0KGG39oyV+z/9FYk4FPevarfIDonaVx/kIeihO79lV17w7Y3R7Kje vTa/yBL+iuR6landd8ZhZAcZqlngtHG2dKPBFfF3eZK2rCWIJdELf3iz4jtS8RTh5RV3 gvwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Jx5Fj/KqKcbpxqyibs51BThSAgjts5OPNkpxf24XLEw=; b=q3ugSDIB0YJlGtiiSjawu2kF2q0Exh0L2bsCJqcwo1IQDUDeilqdcd+OIly6V5XzAX etZLNcHudP1aYqisnXtPj7pdAshSkPB4DgBhm3OmQ9tO81YrRL969J9fHJqPntdz99XZ qHI+um6ZL8gqWKZ1QoXWRm6mbeBdtgKo+ghpO5L47BXeZ4KwnIMKZQBEVRy5Q/0hd0c5 C8xZOQzRSnVEDSEbtUzjG0M3gK5ta0zFcfEdM+lxhC7cXNzIzOeTEKEIXNqG4LYLR2Ve OV04LB9EMUWy39SWhkUEf4AFqvvEyl1Be5bFLfmA6roUPIfty6PkFs7TYatho33vOJAM Wl8A== X-Gm-Message-State: ANhLgQ2fDCCmZ5irqnydmu5G4qfxLx1FFOKBfdrcPPGOaOvUHk8VEJST 9TMKMmGV82VGIVeA8iSn557Shg== X-Google-Smtp-Source: ADFU+vv1KN/TNTl8uwEObqOb9eEUvKbajXYeZlnfMBRzAHZjYnEsQAJAA/ali0fp45ZhYJTwLDz3/w== X-Received: by 2002:adf:94c2:: with SMTP id 60mr12156640wrr.396.1583737949449; Mon, 09 Mar 2020 00:12:29 -0700 (PDT) Received: from dell ([2.31.163.122]) by smtp.gmail.com with ESMTPSA id b6sm2157961wrv.43.2020.03.09.00.12.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2020 00:12:28 -0700 (PDT) Date: Mon, 9 Mar 2020 07:13:13 +0000 From: Lee Jones To: Sergey.Semin@baikalelectronics.ru Cc: Serge Semin , Alexey Malahov , Maxim Kaurkin , Pavel Parkhomenko , Ramil Zaripov , Ekaterina Skachko , Vadim Vlasov , Thomas Bogendoerfer , Paul Burton , Ralf Baechle , Sebastian Reichel , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] syscon: Alter syscon and reboot-mode drivers Message-ID: <20200309071313.GA3200@dell> References: <20200306130356.6ABDD8030703@mail.baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200306130356.6ABDD8030703@mail.baikalelectronics.ru> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 06 Mar 2020, Sergey.Semin@baikalelectronics.ru wrote: > From: Serge Semin > > A lot of custom functionality can be tuned by means of a syscon-registers > placed in Baikal-T1 CCU memory space (though in documentation they are > called system devices registers). While in most of the case the syscon > registers usage will be distributed between corresponding subsystem drivers > (thanks to pretty much coherent design of the registers fields), there are > some peculiarities we should reflect in the generic syscon code. > > First of all seeing there is an map endiannes config acceptable by the syscon > it would be justified to add the corresponding properties declared in the > mfd/syscon.yaml bindings file. Don't really know why this hasn't been done > before. > > Then as it's going to be general in the framework of the Baikal-T1 SoC support > integration into the kernel, we suggest to replace the legacy text-based > syscon-reboot-mode dts-bindings file with yaml-based one. > > Finally seeing the syscon-reboot-mode devices are mostly used in conjuction > with just syscon-reboot device (in particular Baikal-T1 CCU WDT RCR register is > preserved during any type of reboots) and for several other reasons (see the > commit message for details), we suggest to add the 'regmap' property support > to the syscon-reboot-mode driver. This would eliminate the requirement of > placing the syscon-reboot-mode dts-node in the syscon sub-nodes area. > > This patchset is rebased and tested on the mainline Linux kernel 5.6-rc4: > commit 98d54f81e36b ("Linux 5.6-rc4"). > > Signed-off-by: Serge Semin > Signed-off-by: Alexey Malahov > Cc: Maxim Kaurkin > Cc: Pavel Parkhomenko > Cc: Ramil Zaripov > Cc: Ekaterina Skachko > Cc: Vadim Vlasov > Cc: Thomas Bogendoerfer > Cc: Paul Burton > Cc: Ralf Baechle > Cc: Lee Jones > Cc: Sebastian Reichel > Cc: Rob Herring > Cc: Mark Rutland > Cc: devicetree@vger.kernel.org > Cc: linux-pm@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > > Serge Semin (4): > dt-bindings: syscon: Add syscon endian properties support > dt-bindings: power: reset: Replace SYSCON reboot-mode legacy bindings > with YAML-based one > dt-bindings: power: reset: Add regmap support to the SYSCON > reboot-mode bindings > power: reset: syscon-reboot-mode: Add regmap dts-property support > > .../devicetree/bindings/mfd/syscon.yaml | 14 +++++ > .../power/reset/syscon-reboot-mode.txt | 35 ----------- > .../power/reset/syscon-reboot-mode.yaml | 58 +++++++++++++++++++ > drivers/power/reset/syscon-reboot-mode.c | 11 +++- > 4 files changed, 80 insertions(+), 38 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.txt > create mode 100644 Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.yaml Please re-send this patch --threaded. As it stands, it's been scattered to the 4 winds throughout my inbox. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog