From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Paul Barker <pbarker@konsulko.com>
Cc: devicetree@vger.kernel.org, linux-pwm@vger.kernel.org,
Matt Ranostay <matt.ranostay@konsulko.com>,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
Thierry Reding <thierry.reding@gmail.com>,
Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH] dts: imx6: Allow flags argument in pwms reference
Date: Mon, 9 Mar 2020 16:34:37 +0100 [thread overview]
Message-ID: <20200309153437.lwc5uutytj7rvee2@pengutronix.de> (raw)
In-Reply-To: <20200309145558.16098-1-pbarker@konsulko.com>
Hello,
while I like the result in general I'd be a bit more careful here. So
I'd split this into several steps:
a) add
#pwm-cells = <3>;
to the soc.dtsi and undo this by adding
#pwm-cells = <2>;
to all machine.dts (that don't already have #pwm-cells = <3>)
b) for each machine with explicit #pwm-cells = <2>; convert to ... =
<3>;.
This has the advantage that after a) there are no changes to the .dtb
files which can be easily verified. And the patches in b) can be
individually reverted in case something machine specific breaks.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
next prev parent reply other threads:[~2020-03-09 15:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 14:55 [PATCH] dts: imx6: Allow flags argument in pwms reference Paul Barker
2020-03-09 15:34 ` Uwe Kleine-König [this message]
2020-03-09 16:45 ` Philippe Schenker
2020-03-09 17:07 ` Uwe Kleine-König
2020-03-09 17:35 ` Laurent Pinchart
2020-03-09 21:23 ` Uwe Kleine-König
2020-03-16 0:55 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200309153437.lwc5uutytj7rvee2@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=matt.ranostay@konsulko.com \
--cc=pantelis.antoniou@konsulko.com \
--cc=pbarker@konsulko.com \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).