Error in dtc around -fno-common

Error in dtc around -fno-common

[Nathan Chancellor]

Hi all,

GCC 10 is defaulting to -fno-common and Clang has decided to join it [1],
which will completely turn our CI [2] red across the board when our
compiler uprevs in the current tree's state:

ld.lld: error: duplicate symbol: yylloc
>>> defined at dtc-lexer.lex.c
>>>            scripts/dtc/dtc-lexer.lex.o:(yylloc)
>>> defined at dtc-parser.tab.c
>>>            scripts/dtc/dtc-parser.tab.o:(.bss+0x10)
clang-11: error: linker command failed with exit code 1 (use -v to see
invocation)

Is it possible to pick a single patch from dtc and get it fast tracked
to mainline/stable so that this does not happen? It would be this one:

https://git.kernel.org/pub/scm/utils/dtc/dtc.git/commit/?id=0e9225eb0dfec51def612b928d2f1836b092bc7e

I have tested it and it works fine. If that is not possible, how would
you recommend solving this issue?

[1]: https://github.com/llvm/llvm-project/commit/3d9a0445cce368b55dc3a573bc91fe902bbb977f
[2]: https://travis-ci.com/ClangBuiltLinux/continuous-integration/builds/152428887

Cheers,
Nathan

Re: Error in dtc around -fno-common

[Nick Desaulniers]

Bumping this thread.  It would be good to send this as a fixup for the
next -rc if possible, that way we can start backporting it to -stable.

On Tue, Mar 10, 2020 at 12:53 AM Nathan Chancellor
<natechancellor@gmail.com> wrote:
>
> Hi all,
>
> GCC 10 is defaulting to -fno-common and Clang has decided to join it [1],
> which will completely turn our CI [2] red across the board when our
> compiler uprevs in the current tree's state:
>
> ld.lld: error: duplicate symbol: yylloc
> >>> defined at dtc-lexer.lex.c
> >>>            scripts/dtc/dtc-lexer.lex.o:(yylloc)
> >>> defined at dtc-parser.tab.c
> >>>            scripts/dtc/dtc-parser.tab.o:(.bss+0x10)
> clang-11: error: linker command failed with exit code 1 (use -v to see
> invocation)
>
> Is it possible to pick a single patch from dtc and get it fast tracked
> to mainline/stable so that this does not happen? It would be this one:
>
> https://git.kernel.org/pub/scm/utils/dtc/dtc.git/commit/?id=0e9225eb0dfec51def612b928d2f1836b092bc7e
>
> I have tested it and it works fine. If that is not possible, how would
> you recommend solving this issue?
>
> [1]: https://github.com/llvm/llvm-project/commit/3d9a0445cce368b55dc3a573bc91fe902bbb977f
> [2]: https://travis-ci.com/ClangBuiltLinux/continuous-integration/builds/152428887
>
> Cheers,
> Nathan
>
> --
> You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20200310075328.GA17573%40ubuntu-m2-xlarge-x86.



-- 
Thanks,
~Nick Desaulniers

Re: Error in dtc around -fno-common

[Rob Herring]

On Wed, Mar 11, 2020 at 3:39 PM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> Bumping this thread.  It would be good to send this as a fixup for the
> next -rc if possible, that way we can start backporting it to -stable.

The single fix is in my tree now and I'll sync dtc for 5.7.

Rob

> On Tue, Mar 10, 2020 at 12:53 AM Nathan Chancellor
> <natechancellor@gmail.com> wrote:
> >
> > Hi all,
> >
> > GCC 10 is defaulting to -fno-common and Clang has decided to join it [1],
> > which will completely turn our CI [2] red across the board when our
> > compiler uprevs in the current tree's state:
> >
> > ld.lld: error: duplicate symbol: yylloc
> > >>> defined at dtc-lexer.lex.c
> > >>>            scripts/dtc/dtc-lexer.lex.o:(yylloc)
> > >>> defined at dtc-parser.tab.c
> > >>>            scripts/dtc/dtc-parser.tab.o:(.bss+0x10)
> > clang-11: error: linker command failed with exit code 1 (use -v to see
> > invocation)
> >
> > Is it possible to pick a single patch from dtc and get it fast tracked
> > to mainline/stable so that this does not happen? It would be this one:
> >
> > https://git.kernel.org/pub/scm/utils/dtc/dtc.git/commit/?id=0e9225eb0dfec51def612b928d2f1836b092bc7e


> >
> > I have tested it and it works fine. If that is not possible, how would
> > you recommend solving this issue?
> >
> > [1]: https://github.com/llvm/llvm-project/commit/3d9a0445cce368b55dc3a573bc91fe902bbb977f
> > [2]: https://travis-ci.com/ClangBuiltLinux/continuous-integration/builds/152428887
> >
> > Cheers,
> > Nathan
> >
> > --
> > You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20200310075328.GA17573%40ubuntu-m2-xlarge-x86.
>
>
>
> --
> Thanks,
> ~Nick Desaulniers