From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCAF9C18E5B for ; Tue, 10 Mar 2020 09:25:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 93B0B24683 for ; Tue, 10 Mar 2020 09:25:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726316AbgCJJZ4 (ORCPT ); Tue, 10 Mar 2020 05:25:56 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:54451 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726353AbgCJJZz (ORCPT ); Tue, 10 Mar 2020 05:25:55 -0400 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jBb8q-00066g-Ok; Tue, 10 Mar 2020 10:25:36 +0100 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1jBb8n-0006XS-8W; Tue, 10 Mar 2020 10:25:33 +0100 Date: Tue, 10 Mar 2020 10:25:33 +0100 From: Sascha Hauer To: Robin Gong Cc: "vkoul@kernel.org" , "shawnguo@kernel.org" , "u.kleine-koenig@pengutronix.de" , "broonie@kernel.org" , "robh+dt@kernel.org" , "festevam@gmail.com" , "dan.j.williams@intel.com" , "mark.rutland@arm.com" , "catalin.marinas@arm.com" , "will.deacon@arm.com" , "l.stach@pengutronix.de" , "martin.fuzzey@flowbird.group" , "kernel@pengutronix.de" , "linux-spi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , dl-linux-imx , "dmaengine@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [RESEND v6 07/13] spi: imx: remove ERR009165 workaround on i.mx6ul Message-ID: <20200310092533.GV3335@pengutronix.de> References: <1583839922-22699-1-git-send-email-yibin.gong@nxp.com> <1583839922-22699-8-git-send-email-yibin.gong@nxp.com> <20200310080240.GS3335@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 10:08:54 up 19 days, 16:39, 58 users, load average: 0.05, 0.18, 0.20 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Mar 10, 2020 at 08:43:10AM +0000, Robin Gong wrote: > On 2020/03/10 Sascha Hauer wrote: > > On Tue, Mar 10, 2020 at 07:31:56PM +0800, Robin Gong wrote: > > > ERR009165 fixed on i.mx6ul/6ull/6sll. All other i.mx6/7 and i.mx8m/8mm > > > still need this errata. Please refer to nxp official errata document > > > from > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.nx > > p.com%2F&data=02%7C01%7Cyibin.gong%40nxp.com%7Cf73bfc11a68c4 > > 2f5f6d308d7c4c96efa%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C > > 637194241755109112&sdata=xzIUP8qZkrlDXX0yjTcUNZB6zDrevTdHFg1o4 > > PZZd8E%3D&reserved=0 . > > > > > > For removing workaround on those chips. Add new i.mx6ul type. > > > > > > Signed-off-by: Robin Gong > > > Acked-by: Mark Brown > > > --- > > > drivers/spi/spi-imx.c | 50 > > > +++++++++++++++++++++++++++++++++++++++++++++----- > > > 1 file changed, 45 insertions(+), 5 deletions(-) > > > > > > diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index > > > 842a86e..f7ee2ec 100644 > > > --- a/drivers/spi/spi-imx.c > > > +++ b/drivers/spi/spi-imx.c > > > @@ -57,6 +57,7 @@ enum spi_imx_devtype { > > > IMX35_CSPI, /* CSPI on all i.mx except above */ > > > IMX51_ECSPI, /* ECSPI on i.mx51 */ > > > IMX53_ECSPI, /* ECSPI on i.mx53 and later */ > > > + IMX6UL_ECSPI, /* ERR009165 fix from i.mx6ul */ > > > }; > > > > > > struct spi_imx_data; > > > @@ -75,6 +76,11 @@ struct spi_imx_devtype_data { > > > bool has_slavemode; > > > unsigned int fifo_size; > > > bool dynamic_burst; > > > + /* > > > + * ERR009165 fixed or not: > > > + * > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.nx > > p.com%2Fdocs%2Fen%2Ferrata%2FIMX6DQCE.pdf&data=02%7C01%7Cyi > > bin.gong%40nxp.com%7Cf73bfc11a68c42f5f6d308d7c4c96efa%7C686ea1d3bc > > 2b4c6fa92cd99c5c301635%7C0%7C1%7C637194241755109112&sdata=m > > uw4HL5nMDjREJwVd885Wrxka0moMaaZ%2BhJgsAgY3eo%3D&reserved= > > 0 > > > + */ > > > + bool tx_glitch_fixed; > > > enum spi_imx_devtype devtype; > > > }; > > > > > > @@ -128,7 +134,8 @@ static inline int is_imx35_cspi(struct > > > spi_imx_data *d) > > > > > > static inline int is_imx51_ecspi(struct spi_imx_data *d) { > > > - return d->devtype_data->devtype == IMX51_ECSPI; > > > + return d->devtype_data->devtype == IMX51_ECSPI || > > > + d->devtype_data->devtype == IMX6UL_ECSPI; > > > } > > > > Erm, no. A i.MX51 ECSPI is a i.MX51 ECSPI and not a i.MX6UL ECSPI. If you want > > to handle them equally somewhere then explicitly test for i.MX6ul *and* > > i.MX51 there. > But all i.mx6 chips including i.MX53 ECSPI are almost same as i.MX51 ECSPI, and ERR00915 is fixed from i.mx6ul.... You introduce .devtype = IMX6UL_ECSPI in this series, so apparently it is *not* the same as IMX51_ECSPI, then please also don't introduce a function which claims they are the same. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |