Re: [PATCH 2/2] arm64: dts: meson-g12a-tanix-tx5max: add initial device tree

Jerome Brunet
2020-03-05T08:16:00Z

On Sat 29 Feb 2020 at 16:46, Christian Hewitt <christianshewitt@gmail.com> wrote:

> The Oranth Tanix TX5 Max is based on the Amlogic U200 reference design
> using the S905X2 chipset. Hardware specification:
>
> - 4GB LPDDR4 RAM
> - 32GB eMMC storage
> - 10/100/1000 Base-T Ethernet using External RGMII PHY
> - 802.11 a/b/g/b/ac + BT 4.1 sdio wireless
> - HDMI 2.0 (4k@60p) video
> - Composite video + 2-channel audio output on 3.5mm jack
> - S/PDIF audio output
> - 1x USB 3.0
> - 1x USB 2.0
> - 1x micro SD card slot
>
> The device tree is based on the higher-spec X96 Max box device.

Would you mind pointing out the differences ?
Maybe I missed something, but do we really this dts ?
Can't this device directly use the x96 dt, or the u200 ?

All these boards, for which we don't have any documentation, add up

>
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
> ---
> arch/arm64/boot/dts/amlogic/Makefile | 1 +
> .../boot/dts/amlogic/meson-g12a-tanix-tx5max.dts | 481 +++++++++++++++++++++
> 2 files changed, 482 insertions(+)
> create mode 100644 arch/arm64/boot/dts/amlogic/meson-g12a-tanix-tx5max.dts
>
> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
> index eef0045..a1db803 100644
> --- a/arch/arm64/boot/dts/amlogic/Makefile
> +++ b/arch/arm64/boot/dts/amlogic/Makefile
> @@ -1,6 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0
> dtb-$(CONFIG_ARCH_MESON) += meson-axg-s400.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-g12a-sei510.dtb
> +dtb-$(CONFIG_ARCH_MESON) += meson-g12a-tanix-tx5max.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-g12a-u200.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-g12a-x96-max.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-g12b-a311d-khadas-vim3.dtb
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-tanix-tx5max.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-tanix-tx5max.dts
> new file mode 100644
> index 0000000..c3ef0ee
> --- /dev/null
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12a-tanix-tx5max.dts
> @@ -0,0 +1,481 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2018 BayLibre SAS. All rights reserved.
> + */
> +
> +/dts-v1/;

[...]

> +&spdifout_b {
> + status = "okay";
> +};

Why do you need this ?
This producer is dedicated to HDMI controller which does not support it
ATM. Also it is not even used in your sound card

Same goes for the x96 BTW.

> +
> +&tdmif_b {
> + status = "okay";
> +};
> +
> +&tdmout_b {
> + status = "okay";
> +};
> +
> +&tohdmitx {
> + status = "okay";
> +};