From: Marco Felsch <m.felsch@pengutronix.de>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: mchehab@kernel.org, hans.verkuil@cisco.com,
jacopo+renesas@jmondi.org, robh+dt@kernel.org,
laurent.pinchart@ideasonboard.com, devicetree@vger.kernel.org,
kernel@pengutronix.de, linux-media@vger.kernel.org
Subject: Re: [PATCH v12 06/19] media: v4l2-fwnode: add initial connector parsing support
Date: Wed, 11 Mar 2020 10:12:28 +0100 [thread overview]
Message-ID: <20200311091228.qwuh53blrwnokjhn@pengutronix.de> (raw)
In-Reply-To: <20200311090303.GI5379@paasikivi.fi.intel.com>
On 20-03-11 11:03, Sakari Ailus wrote:
> On Wed, Mar 11, 2020 at 09:43:57AM +0100, Marco Felsch wrote:
> > Hi Sakari,
> >
> > On 20-03-11 10:17, Sakari Ailus wrote:
> > > Hi Marco,
> > >
> > > On Mon, Mar 09, 2020 at 11:14:15AM +0100, Marco Felsch wrote:
> > > ...
> > > > +void v4l2_fwnode_connector_free(struct v4l2_fwnode_connector *connector)
> > > > +{
> > > > + struct v4l2_connector_link *link, *tmp;
> > > > +
> > > > + if (IS_ERR_OR_NULL(connector) ||
> > > > + connector->type == V4L2_CONN_UNKNOWN)
> > > > + return;
> > > > +
> > > > + list_for_each_entry_safe(link, tmp, &connector->links, head) {
> > > > + v4l2_fwnode_put_link(&link->fwnode_link);
> > > > + list_del(&link->head);
> > > > + kfree(link);
> > > > + }
> > > > +
> > > > + kfree(connector->label);
> > > > + connector->label = NULL;
> > > > + connector = NULL;
> > >
> > > No need to set connector NULL here.
> >
> > My intention was to make it safe e.g. if a caller calls this twice for
> > the same connector.
>
> This changes the pointer to NULL locally but the caller won't see this ---
> because it's the value of the pointer that was passed here by the caller.
Argh, you're right. Damn i missed this.
Regards,
Marco
next prev parent reply other threads:[~2020-03-11 9:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 10:14 [PATCH v12 00/19] TVP5150 Features and Fixes Marco Felsch
2020-03-09 10:14 ` [PATCH v12 01/19] dt-bindings: connector: analog: add sdtv standards property Marco Felsch
2020-03-09 10:14 ` [PATCH v12 02/19] dt-bindings: display: add sdtv-standards defines Marco Felsch
2020-03-09 10:14 ` [PATCH v12 03/19] media: v4l: link dt-bindings and uapi Marco Felsch
2020-03-09 10:14 ` [PATCH v12 04/19] media: v4l2-fwnode: add endpoint id field to v4l2_fwnode_link Marco Felsch
2020-03-11 8:15 ` Sakari Ailus
2020-03-11 8:39 ` Marco Felsch
2020-03-09 10:14 ` [PATCH v12 05/19] media: v4l2-fwnode: add v4l2_fwnode_connector Marco Felsch
2020-03-09 10:14 ` [PATCH v12 06/19] media: v4l2-fwnode: add initial connector parsing support Marco Felsch
2020-03-11 8:17 ` Sakari Ailus
2020-03-11 8:43 ` Marco Felsch
2020-03-11 9:03 ` Sakari Ailus
2020-03-11 9:12 ` Marco Felsch [this message]
2020-03-09 10:14 ` [PATCH v12 07/19] partial revert of "[media] tvp5150: add HW input connectors support" Marco Felsch
2020-03-09 10:14 ` [PATCH v12 08/19] media: tvp5150: add input source selection of_graph support Marco Felsch
2020-03-09 10:14 ` [PATCH v12 09/19] media: dt-bindings: tvp5150: Add input port connectors DT bindings Marco Felsch
2020-03-09 10:14 ` [PATCH v12 10/19] media: tvp5150: fix set_selection rectangle handling Marco Felsch
2020-03-09 10:14 ` [PATCH v12 11/19] media: tvp5150: add FORMAT_TRY support for get/set selection handlers Marco Felsch
2020-03-09 10:14 ` [PATCH v12 12/19] media: tvp5150: initialize subdev before parsing device tree Marco Felsch
2020-03-09 10:14 ` [PATCH v12 13/19] media: tvp5150: move irq en-/disable into runtime-pm ops Marco Felsch
2020-03-09 10:14 ` [PATCH v12 14/19] media: tvp5150: add v4l2-event support Marco Felsch
2020-03-09 10:14 ` [PATCH v12 15/19] media: tvp5150: add subdev open/close callbacks Marco Felsch
2020-03-09 10:14 ` [PATCH v12 16/19] media: dt-bindings: tvp5150: cleanup bindings stlye Marco Felsch
2020-03-09 10:14 ` [PATCH v12 17/19] media: dt-bindings: tvp5150: add optional sdtv standards documentation Marco Felsch
2020-03-09 10:14 ` [PATCH v12 18/19] media: tvp5150: add support to limit sdtv standards Marco Felsch
2020-03-09 10:14 ` [PATCH v12 19/19] media: tvp5150: make debug output more readable Marco Felsch
2020-03-11 8:33 ` [PATCH v12 00/19] TVP5150 Features and Fixes Sakari Ailus
2020-03-11 9:08 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311091228.qwuh53blrwnokjhn@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=hans.verkuil@cisco.com \
--cc=jacopo+renesas@jmondi.org \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).