From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83DEEC10F27 for ; Wed, 11 Mar 2020 10:30:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5AC1020663 for ; Wed, 11 Mar 2020 10:30:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Q8iLXeBx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728931AbgCKKaw (ORCPT ); Wed, 11 Mar 2020 06:30:52 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:36212 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726817AbgCKKav (ORCPT ); Wed, 11 Mar 2020 06:30:51 -0400 Received: by mail-wr1-f67.google.com with SMTP id s5so1894474wrg.3 for ; Wed, 11 Mar 2020 03:30:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=LzaLKCBRIewXD3EaTa5hnO0VT8owm6vRQQh9HZJ8avA=; b=Q8iLXeBxiZgXJvA2vze2ga6XXLHnHiwXpcRBGb+97vDPoqWmHmYQNZD5qm5/UYrxEN cjwCR0pOyqqvz+obQOJ74UiEbO7YwyeOGWUXaBfM4aUNnRCAIQ9IE4r3C+JmrXVApEtN QfPbit0/lnZGYVi+UbvPMWvMtahu0kOMN1FY7tWEojQqHEJFot3f9/ECjN87ZRJokwqG 2UsaMwgAolYMNAwFN3YLUN/BSxz17PzqJ2t4SXZFY+UzqWaGXWXRITvoP1q9aPlL8I0s 56ZCsoZTUZMEuVHJtvwg/6Z8hd7DcKfTuDssaWskglPcGlBC0+0hPscKQR+14eNZKuhJ oaJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LzaLKCBRIewXD3EaTa5hnO0VT8owm6vRQQh9HZJ8avA=; b=YjRy3QWhTprzE48zxm6hwcr5pvlFZTi8zNElN+LdRLm2rn+byejEBbio66ot+SNjdA 4FkEDh4CY7t8v9SmvzGMo5Ocl4PBfQow15S12CeV82qb8CaQw9KkGTkEEM5rhKt3B3zt 6/jKzoAH/eA0faYf7XEtTVWxcvIqPF5oufCXuf8ahDuVkaTapOc0kgVsTbxRcYLJtK9T ZBZ+eWfiPYUjQGoq7FhvHMW6HvpP9TrhR3lHh9GTt67rYb8iP/R38aj67/BwfzB+MMbl uWq+Y0DJHoZSTyNxlNIiVtsLlcNdLNYZ0R7mmMjci7pZrUKEPelhHJvD3sL9Z4R12u/c pW3A== X-Gm-Message-State: ANhLgQ0zjRM/rm/jIdvAwF3nOzBArcC13hDbf9iiwDdvqFW3dwPkm2Op KR+XqMpFM6AsT9gv410T7J/OLw== X-Google-Smtp-Source: ADFU+vuO9qK9g/2D1BMl3E61Zu+yTrfHT1j9G9JEFmGh20HcuAhscXtAx5vC28GPTMlL0pnuoxc5CA== X-Received: by 2002:adf:ef44:: with SMTP id c4mr3720111wrp.404.1583922649952; Wed, 11 Mar 2020 03:30:49 -0700 (PDT) Received: from holly.lan (cpc141214-aztw34-2-0-cust773.18-1.cable.virginm.net. [86.9.19.6]) by smtp.gmail.com with ESMTPSA id f9sm18718612wrc.71.2020.03.11.03.30.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2020 03:30:49 -0700 (PDT) Date: Wed, 11 Mar 2020 10:30:47 +0000 From: Daniel Thompson To: kgunda@codeaurora.org Cc: bjorn.andersson@linaro.org, jingoohan1@gmail.com, lee.jones@linaro.org, b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org, jacek.anaszewski@gmail.com, pavel@ucw.cz, robh+dt@kernel.org, mark.rutland@arm.com, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Gross , linux-arm-msm@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-arm-msm-owner@vger.kernel.org Subject: Re: [PATCH V3 2/4] backlight: qcom-wled: Add callback functions Message-ID: <20200311103047.v7rt5ii3saack22a@holly.lan> References: <1583760362-26978-1-git-send-email-kgunda@codeaurora.org> <1583760362-26978-3-git-send-email-kgunda@codeaurora.org> <20200310152719.5hpzh6osq22y4qbn@holly.lan> <05ab744dfbd83b6704bd394ce3c3dfc9@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <05ab744dfbd83b6704bd394ce3c3dfc9@codeaurora.org> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Mar 11, 2020 at 12:11:00PM +0530, kgunda@codeaurora.org wrote: > On 2020-03-10 20:57, Daniel Thompson wrote: > > On Mon, Mar 09, 2020 at 06:56:00PM +0530, Kiran Gunda wrote: > > > Add cabc_config, sync_toggle, wled_ovp_fault_status and wled_ovp_delay > > > callback functions to prepare the driver for adding WLED5 support. > > > > > > Signed-off-by: Kiran Gunda > > > > Overall this code would a lot easier to review if > > > --- > > > drivers/video/backlight/qcom-wled.c | 196 > > > +++++++++++++++++++++++------------- > > > 1 file changed, 126 insertions(+), 70 deletions(-) > > > > > > diff --git a/drivers/video/backlight/qcom-wled.c > > > b/drivers/video/backlight/qcom-wled.c > > > index 3d276b3..b73f273 100644 > > > --- a/drivers/video/backlight/qcom-wled.c > > > +++ b/drivers/video/backlight/qcom-wled.c > > > @@ -128,6 +128,7 @@ struct wled_config { > > > bool cs_out_en; > > > bool ext_gen; > > > bool cabc; > > > + bool en_cabc; > > > > Does this ever get set to true? > > > Yes. If user wants use the cabc pin to control the brightness and > use the "qcom,cabc" DT property in the device tree. That sounds like what you intended the code to do! Is the code that does this present in the patch? I could not find it. Daniel.