From: Pavel Machek <pavel@ucw.cz>
To: "20200309082218.13263-1-Denis.Osterland@diehl.com"
<20200309082218.13263-1-Denis.Osterland@diehl.com>
Cc: "dmurphy@ti.com" <dmurphy@ti.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"jacek.anaszewski@gmail.com" <jacek.anaszewski@gmail.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Denis Osterland-Heim <denis.osterland@diehl.com>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2] leds: pwm: add support for default-state device property
Date: Wed, 11 Mar 2020 22:33:09 +0100 [thread overview]
Message-ID: <20200311213309.GB18398@amd> (raw)
In-Reply-To: <20200310123126.4709-1-Denis.Osterland@diehl.com>
[-- Attachment #1: Type: text/plain, Size: 1687 bytes --]
Hi!
> This patch adds support for "default-state" devicetree property, which
> allows to defer pwm init to first use of led.
>
> This allows to configure the PWM early in bootloader to let the LED
> blink until an application in Linux userspace set something different.
"sets".
> Signed-off-by: Denis Osterland-Heim <Denis.Osterland@diehl.com>
Looks good, I'll probably just apply it.
> index 6c6583c35f2f..d0f489680594 100644
> --- a/Documentation/devicetree/bindings/leds/leds-pwm.txt
> +++ b/Documentation/devicetree/bindings/leds/leds-pwm.txt
> @@ -19,6 +19,8 @@ LED sub-node properties:
> see Documentation/devicetree/bindings/leds/common.txt
> - linux,default-trigger : (optional)
> see Documentation/devicetree/bindings/leds/common.txt
> +- default-state : (optional)
> + see Documentation/devicetree/bindings/leds/common.yaml
>
Should other references be updated to common.yaml (as a separate patch)?
> diff --git a/include/linux/leds_pwm.h b/include/linux/leds_pwm.h
> index 93d101d28943..c9ef9012913d 100644
> --- a/include/linux/leds_pwm.h
> +++ b/include/linux/leds_pwm.h
> @@ -10,6 +10,7 @@ struct led_pwm {
> const char *default_trigger;
> unsigned pwm_id __deprecated;
> u8 active_low;
> + u8 default_state;
> unsigned max_brightness;
> unsigned pwm_period_ns;
> };
leds-pwm.c but leds_pwm.h. Hmm. This really should be leds-pwm.h.
Actually, leds-pwm.c is only user of leds_pwm.h, so that one should
just disappear...
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2020-03-11 21:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 12:47 [PATCH v2] leds: pwm: add support for default-state device property Denis Osterland-Heim
2020-03-10 15:19 ` Denis Osterland-Heim
2020-03-10 21:15 ` Jacek Anaszewski
2020-03-11 6:45 ` Denis Osterland-Heim
2020-03-11 22:33 ` Jacek Anaszewski
2020-03-12 7:25 ` Denis Osterland-Heim
2020-03-11 21:33 ` Pavel Machek [this message]
2020-03-12 7:35 ` Denis Osterland-Heim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311213309.GB18398@amd \
--to=pavel@ucw.cz \
--cc=20200309082218.13263-1-Denis.Osterland@diehl.com \
--cc=denis.osterland@diehl.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).