* [PATCH 1/2] firmware: qcom_scm: add ipq806x with no clock
@ 2020-03-11 13:09 Ansuel Smith
2020-03-11 13:09 ` [PATCH 2/2] devicetree: bindings: firmware: add ipq806x to qcom_scm Ansuel Smith
2020-03-12 5:46 ` [PATCH 1/2] firmware: qcom_scm: add ipq806x with no clock Bjorn Andersson
0 siblings, 2 replies; 4+ messages in thread
From: Ansuel Smith @ 2020-03-11 13:09 UTC (permalink / raw)
To: agross
Cc: Ansuel Smith, Bjorn Andersson, Rob Herring, Mark Rutland,
linux-arm-msm, devicetree, linux-kernel
ipq806x rpm definition was missing for a long time.
Add this to make this soc support rpm.
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
---
drivers/firmware/qcom_scm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
index 059bb0fbae9e..d13ef3cd8cf5 100644
--- a/drivers/firmware/qcom_scm.c
+++ b/drivers/firmware/qcom_scm.c
@@ -1144,6 +1144,7 @@ static const struct of_device_id qcom_scm_dt_match[] = {
SCM_HAS_BUS_CLK)
},
{ .compatible = "qcom,scm-ipq4019" },
+ { .compatible = "qcom,scm-ipq806x" },
{ .compatible = "qcom,scm-msm8660", .data = (void *) SCM_HAS_CORE_CLK },
{ .compatible = "qcom,scm-msm8960", .data = (void *) SCM_HAS_CORE_CLK },
{ .compatible = "qcom,scm-msm8916", .data = (void *)(SCM_HAS_CORE_CLK |
--
2.25.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] devicetree: bindings: firmware: add ipq806x to qcom_scm
2020-03-11 13:09 [PATCH 1/2] firmware: qcom_scm: add ipq806x with no clock Ansuel Smith
@ 2020-03-11 13:09 ` Ansuel Smith
2020-03-12 5:46 ` [PATCH 1/2] firmware: qcom_scm: add ipq806x with no clock Bjorn Andersson
1 sibling, 0 replies; 4+ messages in thread
From: Ansuel Smith @ 2020-03-11 13:09 UTC (permalink / raw)
To: agross
Cc: Ansuel Smith, Bjorn Andersson, Rob Herring, Mark Rutland,
linux-arm-msm, devicetree, linux-kernel
Add ipq806x to compatible list in qcom_scm Documentation
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
---
Documentation/devicetree/bindings/firmware/qcom,scm.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.txt b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
index 3f29ea04b5fe..354b448fc0c3 100644
--- a/Documentation/devicetree/bindings/firmware/qcom,scm.txt
+++ b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
@@ -10,6 +10,7 @@ Required properties:
* "qcom,scm-apq8064"
* "qcom,scm-apq8084"
* "qcom,scm-ipq4019"
+ * "qcom,scm-ipq806x"
* "qcom,scm-msm8660"
* "qcom,scm-msm8916"
* "qcom,scm-msm8960"
--
2.25.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] firmware: qcom_scm: add ipq806x with no clock
2020-03-11 13:09 [PATCH 1/2] firmware: qcom_scm: add ipq806x with no clock Ansuel Smith
2020-03-11 13:09 ` [PATCH 2/2] devicetree: bindings: firmware: add ipq806x to qcom_scm Ansuel Smith
@ 2020-03-12 5:46 ` Bjorn Andersson
2020-03-12 9:25 ` R: " ansuelsmth
1 sibling, 1 reply; 4+ messages in thread
From: Bjorn Andersson @ 2020-03-12 5:46 UTC (permalink / raw)
To: Ansuel Smith
Cc: agross, Rob Herring, Mark Rutland, linux-arm-msm, devicetree,
linux-kernel
On Wed 11 Mar 06:09 PDT 2020, Ansuel Smith wrote:
> ipq806x rpm definition was missing for a long time.
> Add this to make this soc support rpm.
>
I merged the dt-binding patch, but please update dts to use:
compatible = "qcom,scm-ipq806x", "qcom,scm";
instead of adding the platform specific compatible in the driver.
Regards,
Bjorn
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---
> drivers/firmware/qcom_scm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> index 059bb0fbae9e..d13ef3cd8cf5 100644
> --- a/drivers/firmware/qcom_scm.c
> +++ b/drivers/firmware/qcom_scm.c
> @@ -1144,6 +1144,7 @@ static const struct of_device_id qcom_scm_dt_match[] = {
> SCM_HAS_BUS_CLK)
> },
> { .compatible = "qcom,scm-ipq4019" },
> + { .compatible = "qcom,scm-ipq806x" },
> { .compatible = "qcom,scm-msm8660", .data = (void *) SCM_HAS_CORE_CLK },
> { .compatible = "qcom,scm-msm8960", .data = (void *) SCM_HAS_CORE_CLK },
> { .compatible = "qcom,scm-msm8916", .data = (void *)(SCM_HAS_CORE_CLK |
> --
> 2.25.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* R: [PATCH 1/2] firmware: qcom_scm: add ipq806x with no clock
2020-03-12 5:46 ` [PATCH 1/2] firmware: qcom_scm: add ipq806x with no clock Bjorn Andersson
@ 2020-03-12 9:25 ` ansuelsmth
0 siblings, 0 replies; 4+ messages in thread
From: ansuelsmth @ 2020-03-12 9:25 UTC (permalink / raw)
To: 'Bjorn Andersson'
Cc: agross, 'Rob Herring', 'Mark Rutland',
linux-arm-msm, devicetree, linux-kernel
> On Wed 11 Mar 06:09 PDT 2020, Ansuel Smith wrote:
>
> > ipq806x rpm definition was missing for a long time.
> > Add this to make this soc support rpm.
> >
>
> I merged the dt-binding patch, but please update dts to use:
> compatible = "qcom,scm-ipq806x", "qcom,scm";
>
> instead of adding the platform specific compatible in the driver.
>
> Regards,
> Bjorn
>
Should I drop the added compatible in qcom_scm.c or just
keep it and add the definition in the ipq806x dts?
> > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> > ---
> > drivers/firmware/qcom_scm.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/firmware/qcom_scm.c
> b/drivers/firmware/qcom_scm.c
> > index 059bb0fbae9e..d13ef3cd8cf5 100644
> > --- a/drivers/firmware/qcom_scm.c
> > +++ b/drivers/firmware/qcom_scm.c
> > @@ -1144,6 +1144,7 @@ static const struct of_device_id
> qcom_scm_dt_match[] = {
> >
> SCM_HAS_BUS_CLK)
> > },
> > { .compatible = "qcom,scm-ipq4019" },
> > + { .compatible = "qcom,scm-ipq806x" },
> > { .compatible = "qcom,scm-msm8660", .data = (void *)
> SCM_HAS_CORE_CLK },
> > { .compatible = "qcom,scm-msm8960", .data = (void *)
> SCM_HAS_CORE_CLK },
> > { .compatible = "qcom,scm-msm8916", .data = (void
> *)(SCM_HAS_CORE_CLK |
> > --
> > 2.25.0
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-12 9:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-11 13:09 [PATCH 1/2] firmware: qcom_scm: add ipq806x with no clock Ansuel Smith
2020-03-11 13:09 ` [PATCH 2/2] devicetree: bindings: firmware: add ipq806x to qcom_scm Ansuel Smith
2020-03-12 5:46 ` [PATCH 1/2] firmware: qcom_scm: add ipq806x with no clock Bjorn Andersson
2020-03-12 9:25 ` R: " ansuelsmth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).