From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55D9CC10DCE for ; Thu, 12 Mar 2020 10:37:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 30433206BE for ; Thu, 12 Mar 2020 10:37:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726752AbgCLKhL (ORCPT ); Thu, 12 Mar 2020 06:37:11 -0400 Received: from mga06.intel.com ([134.134.136.31]:29068 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726669AbgCLKhL (ORCPT ); Thu, 12 Mar 2020 06:37:11 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Mar 2020 03:37:10 -0700 X-IronPort-AV: E=Sophos;i="5.70,544,1574150400"; d="scan'208";a="232008288" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Mar 2020 03:37:08 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 7A1CB208BB; Thu, 12 Mar 2020 12:37:06 +0200 (EET) Date: Thu, 12 Mar 2020 12:37:06 +0200 From: Sakari Ailus To: Marco Felsch Cc: mchehab@kernel.org, hans.verkuil@cisco.com, jacopo+renesas@jmondi.org, robh+dt@kernel.org, laurent.pinchart@ideasonboard.com, devicetree@vger.kernel.org, kernel@pengutronix.de, linux-media@vger.kernel.org Subject: Re: [PATCH v13 04/21] media: v4l2-fwnode: fix v4l2_fwnode_parse_link handling Message-ID: <20200312103706.GM5379@paasikivi.fi.intel.com> References: <20200312103156.3178-1-m.felsch@pengutronix.de> <20200312103156.3178-5-m.felsch@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200312103156.3178-5-m.felsch@pengutronix.de> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Marco, On Thu, Mar 12, 2020 at 11:31:39AM +0100, Marco Felsch wrote: > Currently the driver differentiate the port number property handling for > ACPI and DT. This is wrong as because ACPI should use the "reg" val too > [1]. > > [1] https://patchwork.kernel.org/patch/11421985/ > > Fixes: ca50c197bd96 ("[media] v4l: fwnode: Support generic fwnode for parsing standardised properties") > Signed-off-by: Marco Felsch > --- > drivers/media/v4l2-core/v4l2-fwnode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c b/drivers/media/v4l2-core/v4l2-fwnode.c > index 6ece4320e1d2..d56eee9c09b8 100644 > --- a/drivers/media/v4l2-core/v4l2-fwnode.c > +++ b/drivers/media/v4l2-core/v4l2-fwnode.c > @@ -560,7 +560,7 @@ EXPORT_SYMBOL_GPL(v4l2_fwnode_endpoint_alloc_parse); > int v4l2_fwnode_parse_link(struct fwnode_handle *__fwnode, > struct v4l2_fwnode_link *link) > { > - const char *port_prop = is_of_node(__fwnode) ? "reg" : "port"; > + const char *port_prop = "reg"; > struct fwnode_handle *fwnode; > > memset(link, 0, sizeof(*link)); I'd omit this patch. With this change, the parsing is no longer compatible with previous definition (now deprecated) that use the "port" property. We don't really need to address this for v4l2_fwnode_parse_link(), but rather should change the users to use other APIs. No driver supporting ACPI uses this anyway so it's not really an issue right now. -- Regards, Sakari Ailus