From: Rob Herring <robh@kernel.org>
To: Eason Yen <eason.yen@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Mark Brown <broonie@kernel.org>,
jiaxin.yu@mediatek.com, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
wsd_upstream@mediatek.com
Subject: Re: [PATCH 1/2] ASoC: mediatek: mt6359: add codec document
Date: Thu, 12 Mar 2020 14:05:52 -0500 [thread overview]
Message-ID: <20200312190552.GA27630@bogus> (raw)
In-Reply-To: <1583465622-16628-2-git-send-email-eason.yen@mediatek.com>
On Fri, Mar 06, 2020 at 11:33:41AM +0800, Eason Yen wrote:
> Add mt6359 codec document
>
> Signed-off-by: Eason Yen <eason.yen@mediatek.com>
> ---
> Documentation/devicetree/bindings/sound/mt6359.txt | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/mt6359.txt
Please convert to a DT schema.
>
> diff --git a/Documentation/devicetree/bindings/sound/mt6359.txt b/Documentation/devicetree/bindings/sound/mt6359.txt
> new file mode 100644
> index 0000000..77864e0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/mt6359.txt
> @@ -0,0 +1,16 @@
> +Mediatek MT6359 Audio Codec
> +
> +The communication between MT6358 and SoC is through Mediatek PMIC wrapper.
> +For more detail, please visit Mediatek PMIC wrapper documentation.
> +
> +Must be a child node of PMIC wrapper.
> +
> +Required properties:
> +
> +- compatible : "mediatek,mt6359-sound".
A compatible with no other properties is generally suspect. Don't you
have clocks, connection to I2S or something, etc.
> +
> +Example:
> +
> +mt6359_snd {
audio-codec {
> + compatible = "mediatek,mt6359-sound";
> +};
> --
> 1.9.1
next prev parent reply other threads:[~2020-03-12 19:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 3:33 [PATCH 0/2] Add mediatek codec mt6359 driver Eason Yen
2020-03-06 3:33 ` [PATCH 1/2] ASoC: mediatek: mt6359: add codec document Eason Yen
2020-03-12 19:05 ` Rob Herring [this message]
2020-03-06 3:33 ` [PATCH 2/2] ASoC: codec: mediatek: add mt6359 codec driver Eason Yen
2020-03-09 13:13 ` Mark Brown
2020-03-11 9:22 ` Eason Yen
2020-03-11 12:12 ` Mark Brown
2020-03-12 6:43 ` Eason Yen
2020-03-12 19:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312190552.GA27630@bogus \
--to=robh@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eason.yen@mediatek.com \
--cc=jiaxin.yu@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).