* [PATCH 01/22] dt-bindings: Permit platform devices in the trivial-devices bindings
[not found] <20200306124705.6595-1-Sergey.Semin@baikalelectronics.ru>
@ 2020-03-06 12:46 ` Sergey.Semin
2020-03-06 13:56 ` Rob Herring
[not found] ` <20200306140550.0A68180307C4@mail.baikalelectronics.ru>
2020-03-06 12:46 ` [PATCH 02/22] dt-bindings: Add MIPS CPC controller as a trivial devices Sergey.Semin
` (3 subsequent siblings)
4 siblings, 2 replies; 12+ messages in thread
From: Sergey.Semin @ 2020-03-06 12:46 UTC (permalink / raw)
To: Rob Herring, Mark Rutland
Cc: Serge Semin, Serge Semin, Alexey Malahov, Thomas Bogendoerfer,
Paul Burton, Ralf Baechle, devicetree, linux-kernel
From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Indeed there are a log of trivial devices amongst platform controllers,
IP-blocks, etc. If they satisfy the trivial devices bindings requirements
like consisting of a compatible field, an address and possibly an interrupt
line why not having them in the generic trivial-devices bindings file?
We only need to accordingly alter the bindings title and description nodes.
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Signed-off-by: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Paul Burton <paulburton@kernel.org>
Cc: Ralf Baechle <ralf@linux-mips.org>
---
Documentation/devicetree/bindings/trivial-devices.yaml | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 978de7d37c66..ce0149b4b6ed 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -4,15 +4,15 @@
$id: http://devicetree.org/schemas/trivial-devices.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#
-title: Trivial I2C and SPI devices that have simple device tree bindings
+title: Trivial I2C, SPI and platform devices having simple device tree bindings
maintainers:
- Rob Herring <robh@kernel.org>
description: |
- This is a list of trivial I2C and SPI devices that have simple device tree
- bindings, consisting only of a compatible field, an address and possibly an
- interrupt line.
+ This is a list of trivial I2C, SPI and platform devices that have simple
+ device tree bindings, consisting only of a compatible field, an address and
+ possibly an interrupt line.
If a device needs more specific bindings, such as properties to
describe some aspect of it, there needs to be a specific binding
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 01/22] dt-bindings: Permit platform devices in the trivial-devices bindings
2020-03-06 12:46 ` [PATCH 01/22] dt-bindings: Permit platform devices in the trivial-devices bindings Sergey.Semin
@ 2020-03-06 13:56 ` Rob Herring
[not found] ` <20200306140550.0A68180307C4@mail.baikalelectronics.ru>
1 sibling, 0 replies; 12+ messages in thread
From: Rob Herring @ 2020-03-06 13:56 UTC (permalink / raw)
To: Sergey.Semin
Cc: Mark Rutland, Serge Semin, Alexey Malahov, Thomas Bogendoerfer,
Paul Burton, Ralf Baechle, devicetree,
linux-kernel@vger.kernel.org
On Fri, Mar 6, 2020 at 6:48 AM <Sergey.Semin@baikalelectronics.ru> wrote:
>
> From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
>
> Indeed there are a log of trivial devices amongst platform controllers,
> IP-blocks, etc. If they satisfy the trivial devices bindings requirements
> like consisting of a compatible field, an address and possibly an interrupt
> line why not having them in the generic trivial-devices bindings file?
NAK.
Do you have some documentation on what a platform bus is? Last I
checked, that's a Linux thing.
If anything, we'd move toward getting rid of trivial-devices.yaml. For
example, I'd like to start defining the node name which wouldn't work
for trivial-devices.yaml unless we split by class.
Rob
^ permalink raw reply [flat|nested] 12+ messages in thread[parent not found: <20200306140550.0A68180307C4@mail.baikalelectronics.ru>]
* Re: [PATCH 01/22] dt-bindings: Permit platform devices in the trivial-devices bindings
[not found] ` <20200306140550.0A68180307C4@mail.baikalelectronics.ru>
@ 2020-03-10 1:09 ` Sergey Semin
0 siblings, 0 replies; 12+ messages in thread
From: Sergey Semin @ 2020-03-10 1:09 UTC (permalink / raw)
To: Rob Herring
Cc: Mark Rutland, Alexey Malahov, Thomas Bogendoerfer, Paul Burton,
Ralf Baechle, devicetree, linux-kernel@vger.kernel.org
On Fri, Mar 06, 2020 at 07:56:51AM -0600, Rob Herring wrote:
> On Fri, Mar 6, 2020 at 6:48 AM <Sergey.Semin@baikalelectronics.ru> wrote:
> >
> > From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> >
> > Indeed there are a log of trivial devices amongst platform controllers,
> > IP-blocks, etc. If they satisfy the trivial devices bindings requirements
> > like consisting of a compatible field, an address and possibly an interrupt
> > line why not having them in the generic trivial-devices bindings file?
>
> NAK.
>
> Do you have some documentation on what a platform bus is? Last I
> checked, that's a Linux thing.
>
> If anything, we'd move toward getting rid of trivial-devices.yaml. For
> example, I'd like to start defining the node name which wouldn't work
> for trivial-devices.yaml unless we split by class.
>
> Rob
Hello Rob,
Understood. I thought the trivial-devices bindings was to collect all
the devices with simple bindings, but it turns out to be a stub for
devices, which just aren't described by a dedicated bindings file.
I'll resubmit the v2 version with no changes to the trivial-devices.yaml,
but with CDMM/CPC dt-nodes having yaml-based bindings.
Regards,
-Sergey
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 02/22] dt-bindings: Add MIPS CPC controller as a trivial devices
[not found] <20200306124705.6595-1-Sergey.Semin@baikalelectronics.ru>
2020-03-06 12:46 ` [PATCH 01/22] dt-bindings: Permit platform devices in the trivial-devices bindings Sergey.Semin
@ 2020-03-06 12:46 ` Sergey.Semin
2020-03-06 12:46 ` [PATCH 03/22] dt-bindings: Add MIPS CDMM controller as a trivial device Sergey.Semin
` (2 subsequent siblings)
4 siblings, 0 replies; 12+ messages in thread
From: Sergey.Semin @ 2020-03-06 12:46 UTC (permalink / raw)
To: Paul Burton, Rob Herring, Mark Rutland
Cc: Serge Semin, Serge Semin, Alexey Malahov, Thomas Bogendoerfer,
Ralf Baechle, linux-mips, devicetree, linux-kernel
From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
It's a Cluster Power Controller embedded into the MIPS IP cores.
Currently the corresponding dts node is supposed to have a compatible
and regs properties. There is no need in the text-based mti,mips-cpc
bindings file from now. So it can be removed.
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Signed-off-by: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Paul Burton <paulburton@kernel.org>
Cc: Ralf Baechle <ralf@linux-mips.org>
---
Documentation/devicetree/bindings/power/mti,mips-cpc.txt | 8 --------
Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
2 files changed, 2 insertions(+), 8 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/power/mti,mips-cpc.txt
diff --git a/Documentation/devicetree/bindings/power/mti,mips-cpc.txt b/Documentation/devicetree/bindings/power/mti,mips-cpc.txt
deleted file mode 100644
index c6b82511ae8a..000000000000
--- a/Documentation/devicetree/bindings/power/mti,mips-cpc.txt
+++ /dev/null
@@ -1,8 +0,0 @@
-Binding for MIPS Cluster Power Controller (CPC).
-
-This binding allows a system to specify where the CPC registers are
-located.
-
-Required properties:
-compatible : Should be "mti,mips-cpc".
-regs: Should describe the address & size of the CPC register region.
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index ce0149b4b6ed..b6b6f3181fd8 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -304,6 +304,8 @@ properties:
- miramems,da280
# MiraMEMS DA311 3-axis 12-bit digital accelerometer
- miramems,da311
+ # MIPS Cluster Power Controller (CPC)
+ - mti,mips-cpc
# Temperature sensor with integrated fan control
- national,lm63
# I2C TEMP SENSOR
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 03/22] dt-bindings: Add MIPS CDMM controller as a trivial device
[not found] <20200306124705.6595-1-Sergey.Semin@baikalelectronics.ru>
2020-03-06 12:46 ` [PATCH 01/22] dt-bindings: Permit platform devices in the trivial-devices bindings Sergey.Semin
2020-03-06 12:46 ` [PATCH 02/22] dt-bindings: Add MIPS CPC controller as a trivial devices Sergey.Semin
@ 2020-03-06 12:46 ` Sergey.Semin
2020-03-06 12:46 ` [PATCH 04/22] dt-bindings: Add vendor prefix for Baikal Electronics, JSC Sergey.Semin
2020-03-10 1:01 ` [PATCH 00/22] mips: Prepare MIPS-arch code for Baikal-T1 SoC support Sergey Semin
4 siblings, 0 replies; 12+ messages in thread
From: Sergey.Semin @ 2020-03-06 12:46 UTC (permalink / raw)
To: Rob Herring, Mark Rutland
Cc: Serge Semin, Serge Semin, Alexey Malahov, Thomas Bogendoerfer,
Paul Burton, Ralf Baechle, devicetree, linux-kernel
From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
It's a Common Device Memory Map controller embedded into the MIPS IP
cores. The corresponding dts node is supposed to have a compatible
and regs properties. So add the device to the trivial-devices bindings
file.
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Signed-off-by: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Paul Burton <paulburton@kernel.org>
Cc: Ralf Baechle <ralf@linux-mips.org>
---
Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index b6b6f3181fd8..370b8c6631fc 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -304,6 +304,8 @@ properties:
- miramems,da280
# MiraMEMS DA311 3-axis 12-bit digital accelerometer
- miramems,da311
+ # MIPS Common Device Memory Map block (CDMM)
+ - mti,mips-cdmm
# MIPS Cluster Power Controller (CPC)
- mti,mips-cpc
# Temperature sensor with integrated fan control
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 04/22] dt-bindings: Add vendor prefix for Baikal Electronics, JSC
[not found] <20200306124705.6595-1-Sergey.Semin@baikalelectronics.ru>
` (2 preceding siblings ...)
2020-03-06 12:46 ` [PATCH 03/22] dt-bindings: Add MIPS CDMM controller as a trivial device Sergey.Semin
@ 2020-03-06 12:46 ` Sergey.Semin
2020-03-12 20:41 ` Rob Herring
2020-03-12 20:44 ` Rob Herring
2020-03-10 1:01 ` [PATCH 00/22] mips: Prepare MIPS-arch code for Baikal-T1 SoC support Sergey Semin
4 siblings, 2 replies; 12+ messages in thread
From: Sergey.Semin @ 2020-03-06 12:46 UTC (permalink / raw)
To: Rob Herring, Mark Rutland
Cc: Serge Semin, Serge Semin, Alexey Malahov, Thomas Bogendoerfer,
Paul Burton, Ralf Baechle, devicetree, linux-kernel
From: Serge Semin <fancer.lancer@gmail.com>
Add "BAIKAL ELECTRONICS, JSC" to the list of devicetree vendor prefixes
as "be".
Website: http://www.baikalelectronics.com
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Signed-off-by: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Paul Burton <paulburton@kernel.org>
Cc: Ralf Baechle <ralf@linux-mips.org>
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 9e67944bec9c..8568713396af 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -141,6 +141,8 @@ patternProperties:
description: Shenzhen AZW Technology Co., Ltd.
"^bananapi,.*":
description: BIPAI KEJI LIMITED
+ "^be,.*":
+ description: BAIKAL ELECTRONICS, JSC
"^bhf,.*":
description: Beckhoff Automation GmbH & Co. KG
"^bitmain,.*":
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 04/22] dt-bindings: Add vendor prefix for Baikal Electronics, JSC
2020-03-06 12:46 ` [PATCH 04/22] dt-bindings: Add vendor prefix for Baikal Electronics, JSC Sergey.Semin
@ 2020-03-12 20:41 ` Rob Herring
2020-03-13 8:52 ` Sergey Semin
2020-03-12 20:44 ` Rob Herring
1 sibling, 1 reply; 12+ messages in thread
From: Rob Herring @ 2020-03-12 20:41 UTC (permalink / raw)
To: Sergey.Semin
Cc: Mark Rutland, Serge Semin, Alexey Malahov, Thomas Bogendoerfer,
Paul Burton, Ralf Baechle, devicetree, linux-kernel
On Fri, Mar 06, 2020 at 03:46:47PM +0300, Sergey.Semin@baikalelectronics.ru wrote:
> From: Serge Semin <fancer.lancer@gmail.com>
>
> Add "BAIKAL ELECTRONICS, JSC" to the list of devicetree vendor prefixes
> as "be".
>
> Website: http://www.baikalelectronics.com
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
checkpatch is not happy that the author and S-o-b don't match.
> Signed-off-by: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: Paul Burton <paulburton@kernel.org>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> ---
> Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 9e67944bec9c..8568713396af 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -141,6 +141,8 @@ patternProperties:
> description: Shenzhen AZW Technology Co., Ltd.
> "^bananapi,.*":
> description: BIPAI KEJI LIMITED
> + "^be,.*":
> + description: BAIKAL ELECTRONICS, JSC
> "^bhf,.*":
> description: Beckhoff Automation GmbH & Co. KG
> "^bitmain,.*":
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 04/22] dt-bindings: Add vendor prefix for Baikal Electronics, JSC
2020-03-12 20:41 ` Rob Herring
@ 2020-03-13 8:52 ` Sergey Semin
0 siblings, 0 replies; 12+ messages in thread
From: Sergey Semin @ 2020-03-13 8:52 UTC (permalink / raw)
To: Rob Herring
Cc: Mark Rutland, Alexey Malahov, Thomas Bogendoerfer, Paul Burton,
Ralf Baechle, devicetree, linux-kernel
On Thu, Mar 12, 2020 at 03:41:24PM -0500, Rob Herring wrote:
> On Fri, Mar 06, 2020 at 03:46:47PM +0300, Sergey.Semin@baikalelectronics.ru wrote:
> > From: Serge Semin <fancer.lancer@gmail.com>
> >
> > Add "BAIKAL ELECTRONICS, JSC" to the list of devicetree vendor prefixes
> > as "be".
> >
> > Website: http://www.baikalelectronics.com
> >
> > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
>
> checkpatch is not happy that the author and S-o-b don't match.
>
Sorry. Missed that. I'll fix it up in v2.
-Sergey
> > Signed-off-by: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
> > Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> > Cc: Paul Burton <paulburton@kernel.org>
> > Cc: Ralf Baechle <ralf@linux-mips.org>
> > ---
> > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > index 9e67944bec9c..8568713396af 100644
> > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > @@ -141,6 +141,8 @@ patternProperties:
> > description: Shenzhen AZW Technology Co., Ltd.
> > "^bananapi,.*":
> > description: BIPAI KEJI LIMITED
> > + "^be,.*":
> > + description: BAIKAL ELECTRONICS, JSC
> > "^bhf,.*":
> > description: Beckhoff Automation GmbH & Co. KG
> > "^bitmain,.*":
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 04/22] dt-bindings: Add vendor prefix for Baikal Electronics, JSC
2020-03-06 12:46 ` [PATCH 04/22] dt-bindings: Add vendor prefix for Baikal Electronics, JSC Sergey.Semin
2020-03-12 20:41 ` Rob Herring
@ 2020-03-12 20:44 ` Rob Herring
2020-03-13 9:40 ` Sergey Semin
1 sibling, 1 reply; 12+ messages in thread
From: Rob Herring @ 2020-03-12 20:44 UTC (permalink / raw)
To: Sergey.Semin
Cc: Mark Rutland, Serge Semin, Alexey Malahov, Thomas Bogendoerfer,
Paul Burton, Ralf Baechle, devicetree, linux-kernel
On Fri, Mar 06, 2020 at 03:46:47PM +0300, Sergey.Semin@baikalelectronics.ru wrote:
> From: Serge Semin <fancer.lancer@gmail.com>
>
> Add "BAIKAL ELECTRONICS, JSC" to the list of devicetree vendor prefixes
> as "be".
>
> Website: http://www.baikalelectronics.com
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> Signed-off-by: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: Paul Burton <paulburton@kernel.org>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> ---
> Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 9e67944bec9c..8568713396af 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -141,6 +141,8 @@ patternProperties:
> description: Shenzhen AZW Technology Co., Ltd.
> "^bananapi,.*":
> description: BIPAI KEJI LIMITED
> + "^be,.*":
> + description: BAIKAL ELECTRONICS, JSC
Also, is 'be' a well known abbreviation for this company. Perhaps
'baikal' instead?
> "^bhf,.*":
> description: Beckhoff Automation GmbH & Co. KG
> "^bitmain,.*":
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 04/22] dt-bindings: Add vendor prefix for Baikal Electronics, JSC
2020-03-12 20:44 ` Rob Herring
@ 2020-03-13 9:40 ` Sergey Semin
0 siblings, 0 replies; 12+ messages in thread
From: Sergey Semin @ 2020-03-13 9:40 UTC (permalink / raw)
To: Rob Herring
Cc: Mark Rutland, Alexey Malahov, Thomas Bogendoerfer, Paul Burton,
Ralf Baechle, devicetree, linux-kernel
On Thu, Mar 12, 2020 at 03:44:06PM -0500, Rob Herring wrote:
> On Fri, Mar 06, 2020 at 03:46:47PM +0300, Sergey.Semin@baikalelectronics.ru wrote:
> > From: Serge Semin <fancer.lancer@gmail.com>
> >
> > Add "BAIKAL ELECTRONICS, JSC" to the list of devicetree vendor prefixes
> > as "be".
> >
> > Website: http://www.baikalelectronics.com
> >
> > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> > Signed-off-by: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
> > Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> > Cc: Paul Burton <paulburton@kernel.org>
> > Cc: Ralf Baechle <ralf@linux-mips.org>
> > ---
> > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > index 9e67944bec9c..8568713396af 100644
> > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > @@ -141,6 +141,8 @@ patternProperties:
> > description: Shenzhen AZW Technology Co., Ltd.
> > "^bananapi,.*":
> > description: BIPAI KEJI LIMITED
> > + "^be,.*":
> > + description: BAIKAL ELECTRONICS, JSC
>
> Also, is 'be' a well known abbreviation for this company. Perhaps
> 'baikal' instead?
>
Hm, I don't think that baikal is a well known synonym of the company
either. Seeing the company isn't well known in general.) Here the
'Baikal' name is mostly associated with the deepest lake in the world.)
We had a discussion amongst our team developers what abbreviation to choose.
Some of us suggested to use 'baikal' prefix too. But after all we agreed to
set the 'be' one as being short and yet compatible with company name. However
it's unlikely that developers looking at vendor prefix would think of a lake
first and, you are right, that 'baikal' word would point to the original
company name better than 'be'. On the other hand the chips the company
produces also have 'baikal' in their names: Baikal-T1, Baikal-M1, etc.
So the compatible strings of the SoC components either would look like:
- be,bt1; be,baikal-t1 (SoC/machine compatible strings)
- be,bt1-i2c; be,bt1-pvt; be,bt1-efuse; be,bt1-axi-ic; etc (individual
SoC subdevices compatible strings)
or
- baikal,bt1; baikal,baikal-t1
- baikal,bt1-i2c; baikal,bt1-pvt; baikal,bt1-efuse; baikal,bt1-axi-ic; etc
First version seemed less cumbersome, having less 'baikal' in the
compatible strings. In the second case the vendor prefix turned to be
longer than the rest of the component name, which is supposed to be the
main part of the string.
So you think 'baikal' would be better anyway? It would be great to hear
your opinion about this in details, because we still have doubts which
prefix is better.
(I'm so persistent in describing why we chose 'be' prefix, because in
case of changing it to 'baikal' I would have to alter all the drivers
we wrote, which you must agree isn't that pleasant work.)
-Sergey
> > "^bhf,.*":
> > description: Beckhoff Automation GmbH & Co. KG
> > "^bitmain,.*":
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 00/22] mips: Prepare MIPS-arch code for Baikal-T1 SoC support
[not found] <20200306124705.6595-1-Sergey.Semin@baikalelectronics.ru>
` (3 preceding siblings ...)
2020-03-06 12:46 ` [PATCH 04/22] dt-bindings: Add vendor prefix for Baikal Electronics, JSC Sergey.Semin
@ 2020-03-10 1:01 ` Sergey Semin
4 siblings, 0 replies; 12+ messages in thread
From: Sergey Semin @ 2020-03-10 1:01 UTC (permalink / raw)
To: Alexey Malahov, Maxim Kaurkin, Pavel Parkhomenko, Ramil Zaripov,
Ekaterina Skachko, Vadim Vlasov, Thomas Bogendoerfer, Paul Burton,
Ralf Baechle, Rob Herring, Frank Rowand, Tony Lindgren,
Arnd Bergmann, Greg Kroah-Hartman, Jiri Slaby, linux-mips,
linux-pm, devicetree, linux-kernel
On Fri, Mar 06, 2020 at 03:46:43PM +0300, Sergey.Semin@baikalelectronics.ru wrote:
> From: Serge Semin <fancer.lancer@gmail.com>
>
> This is a first patchset of a series of about 25 ones, which are intended to
> add the full Baikal-T1 SoC [1] support to the Linux kernel. Since they will
> concern various kernel subsystems, I decided to split the whole work up into
> the patchesets in accordance with the subsystems/devices their changes are
> introduced for. Nearly 2/3 of the work is already done and will be sent out
> very soon. While the rest of the changes specifically related to the fast-speed
> interfaces (DW 12G PHY, PCIe, SATA, xGBE, GMAC, USB, DDRC, IC) are still in
> refactoring and preparation for integration into the mainline kernel. Hopefully
> I'll finish them up in the next two-three months, and submit them straight
> away.
>
> Getting back to this patchset. As the subject states this is intended to
> prepare the MIPS-arch and generic kernel code for further Baikal-T1 SoC
> platform support integration (note the Baikal-T1 SoC platform code will be
> submitted last after the whole series of patchsets as a closure of the
> submission process). First of all the patchset starts with a set of changes
> to the dt-bindings kernel concerning MIPS CPC and CDMM nodes as being described
> by the trivial device bindings. In addition we updated the vendors prefix
> schema with Baikal Electronics JSC prefix so being further committed device
> drivers would be correctly accepted by the checkpatch-script.
>
> Then I found out that dtc-compiler integrated into the kernel doesn't support
> all the possible values of the 'reg'-property used to define the i2c-slave
> devices address. It may have 10-bits and own-slave flags, so the compiler has
> to deal with them. Even though the patch might be better to be integrated into
> the mainline dtc repo I decided to send it to the kernel first.
>
> While I was working with the MIPS architecture code, I discovered, that there
> is a bug in the Coherency Manager v2 error causes declaration and the errors
> handler lacked of CM2 L2 ECC/parity errors support. So the fixes are here in
> the patchset.
>
> Baikal-T1 SoC is based on the MIPS P5600 Warrior IP-core, which itself has
> MIPS32 Release 5 architecture. Even though on ISA level it doesn't differ much
> from the MIPS32 Release 2 release, there are still some peculiarities, which
> make it's justified to add the direct MIPS32r5 support into the kernel (see
> the specific patch for details). In addition seeing there is more than one
> real chip based on the MIPS P5600 core on the market, it would be good to have
> the direct P5600 CPU config in the MIPS-arch.
>
> There were some issues we discovered while were working with MIPS-arch code.
> So the cleanups and fixes are introduced in this patchset. First of all the
> Write-Merge CPU feature hasn't been handled in a generic way. Even if a
> platform defined the writecombine flag as _CACHE_UNCACHED_ACCELERATED, the
> feature might have been disabled in the CP0 register. We either enable it or
> leave it as is in accordance with the knowledge of whether the corresponding
> platform really supports it. Secondly Memory Accessibility Attribute Registers
> (MAAR) haven't been properly initialized when Extended Physical Address (XPA)
> mode was enabled. Thirdly since some of the platforms may have a very strict
> limitations on the IO-memory access instructions. For instance Baikal-T1 SoC
> IO-memory can be accessed by the lw/sw instructions only. In this case
> for early-printk and CPS-debug code we suggest to use the instructions in
> accordance with the UART-registers offset (lb/sb if offset = 0, lh/sh
> if offset = 1 and so on). Fourthly in case if CPUFREQ feature is enabled
> and frequency of the CPU is changed by the reference clock alteration, we
> must make sure that MIPS r4k timer related services are properly updated
> when CPU-frequency changes. It concerns udelay lpj adjustment, MIPS timer
> clockevent frequency update. In addition when CPU reference frequency changes
> it isn't recommended to use the timer as clocksource at all, since currently
> the subsystem isn't tolerant to the unstable clock sources. So in this case
> we suggest to use the r4k timer for clocksourcing only as a last resort.
> Fifthly we discovered a bug in a method of CPUFREQ boost feature enable
> procedure and fixed it in one of the patches within this patchset. And finally
> there are a few fixups/cleanups we suggest to integrate into the MIPS FDC
> and CDMM related code (see the patches for details).
>
> This patchset is rebased and tested on the mainline Linux kernel 5.6-rc4:
> commit 98d54f81e36b ("Linux 5.6-rc4").
>
> [1] http://www.baikalelectronics.com/products/168/
>
> P.S. Sorry for the previous emails burst. I forgot to start the series with
> this cover-letter and the corporate smtp broke the transmission in the middle
> anyway. Please don't pay attention to them. Here is the proper emails
> resubmission.
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> Signed-off-by: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
> Cc: Maxim Kaurkin <Maxim.Kaurkin@baikalelectronics.ru>
> Cc: Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>
> Cc: Ramil Zaripov <Ramil.Zaripov@baikalelectronics.ru>
> Cc: Ekaterina Skachko <Ekaterina.Skachko@baikalelectronics.ru>
> Cc: Vadim Vlasov <V.Vlasov@baikalelectronics.ru>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: Paul Burton <paul.burton@imgtec.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Frank Rowand <frowand.list@gmail.com>
> cc: Tony Lindgren <tony@atomide.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jslaby@suse.com>
> Cc: linux-mips@vger.kernel.org
> Cc: linux-pm@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
>
> Serge Semin (22):
> dt-bindings: Permit platform devices in the trivial-devices bindings
> dt-bindings: Add MIPS CPC controller as a trivial devices
> dt-bindings: Add MIPS CDMM controller as a trivial device
> dt-bindings: Add vendor prefix for Baikal Electronics, JSC
> mips: cm: Fix an invalid error code of INTVN_*_ERR
> mips: cm: Add L2 ECC/parity errors reporting
> mips: Add MIPS32 Release 5 support
> mips: Add MIPS Warrior P5600 support
> mips: Fix cpu_has_mips64r1/2 activation for MIPS32 CPUs
> mips: Add CP0 Write Merge config support
> mips: Add CONFIG/CONFIG6 reg fields macro
> mips: MAAR: Use more precise address mask
> mips: MAAR: Add XPA mode support
> mips: early_printk_8250: Use offset-sized IO-mem accessors
> mips: Use offset-sized IO-mem accessors in CPS debug printout
> mips: cdmm: Add mti,mips-cdmm dtb node support
> bus: cdmm: Add MIPS R5 arch support
> tty: mips_ejtag_fdc: Mark expected switch fall-through
> mips: Add udelay lpj numbers adjustment
> mips: csrc-r4k: Decrease r4k-clocksource rating if CPU_FREQ enabled
> mips: cevt-r4k: Update the r4k-clockevent frequency in sync with CPU
> cpufreq: Return zero on success in boost sw setting
>
> .../bindings/power/mti,mips-cpc.txt | 8 ---
> .../devicetree/bindings/trivial-devices.yaml | 12 ++--
> .../devicetree/bindings/vendor-prefixes.yaml | 2 +
> arch/mips/Kconfig | 62 ++++++++++++++--
> arch/mips/Makefile | 2 +
> arch/mips/include/asm/asmmacro.h | 18 ++---
> arch/mips/include/asm/compiler.h | 5 ++
> arch/mips/include/asm/cpu-features.h | 34 ++++++---
> arch/mips/include/asm/cpu-info.h | 2 +-
> arch/mips/include/asm/cpu-type.h | 6 +-
> arch/mips/include/asm/cpu.h | 11 +--
> arch/mips/include/asm/fpu.h | 4 +-
> arch/mips/include/asm/hazards.h | 8 ++-
> arch/mips/include/asm/maar.h | 17 ++++-
> arch/mips/include/asm/mipsregs.h | 33 ++++++++-
> arch/mips/include/asm/module.h | 4 ++
> arch/mips/include/asm/stackframe.h | 2 +-
> arch/mips/include/asm/switch_to.h | 8 +--
> arch/mips/kernel/cevt-r4k.c | 44 ++++++++++++
> arch/mips/kernel/cps-vec-ns16550.S | 18 ++++-
> arch/mips/kernel/cpu-probe.c | 60 ++++++++++++++++
> arch/mips/kernel/csrc-r4k.c | 4 ++
> arch/mips/kernel/early_printk_8250.c | 34 ++++++++-
> arch/mips/kernel/entry.S | 6 +-
> arch/mips/kernel/mips-cm.c | 66 +++++++++++++++--
> arch/mips/kernel/proc.c | 2 +
> arch/mips/kernel/r4k_fpu.S | 14 ++--
> arch/mips/kernel/spram.c | 4 +-
> arch/mips/kernel/time.c | 70 +++++++++++++++++++
> arch/mips/kvm/vz.c | 6 +-
> arch/mips/lib/csum_partial.S | 6 +-
> arch/mips/mm/c-r4k.c | 7 +-
> arch/mips/mm/init.c | 8 ++-
> arch/mips/mm/sc-mips.c | 7 +-
> drivers/bus/Kconfig | 2 +-
> drivers/bus/mips_cdmm.c | 15 ++++
> drivers/cpufreq/cpufreq.c | 2 +-
> drivers/tty/mips_ejtag_fdc.c | 1 +
> 38 files changed, 529 insertions(+), 85 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/power/mti,mips-cpc.txt
>
> --
> 2.25.1
>
Folks,
It appears our corporate email server changes the Message-Id field of
messages passing through it. Due to that the emails threading gets to be
broken. I'll resubmit the properly structured v2 patchset as soon as our system
administrator fixes the problem. Sorry for the inconvenience caused by it.
Regards,
-Sergey
^ permalink raw reply [flat|nested] 12+ messages in thread