* [PATCH] dt-bindings: leds: common: fix example for gpio-leds
@ 2020-03-13 16:57 Johan Jonker
2020-03-21 15:46 ` Pavel Machek
2020-03-30 18:43 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Johan Jonker @ 2020-03-13 16:57 UTC (permalink / raw)
To: jacek.anaszewski
Cc: pavel, dmurphy, robh+dt, linux-leds, devicetree, linux-kernel
The preferred form for gpio-leds compatible subnodes is:
^led-[0-9a-f]$
Fix example by changing led0 and led1 to led-0 and led-1.
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
Documentation/devicetree/bindings/leds/common.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
index c60b994fe..4c270fde4 100644
--- a/Documentation/devicetree/bindings/leds/common.yaml
+++ b/Documentation/devicetree/bindings/leds/common.yaml
@@ -167,13 +167,13 @@ examples:
led-controller {
compatible = "gpio-leds";
- led0 {
+ led-0 {
function = LED_FUNCTION_STATUS;
linux,default-trigger = "heartbeat";
gpios = <&gpio0 0 GPIO_ACTIVE_HIGH>;
};
- led1 {
+ led-1 {
function = LED_FUNCTION_USB;
gpios = <&gpio0 1 GPIO_ACTIVE_HIGH>;
trigger-sources = <&ohci_port1>, <&ehci_port1>;
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: leds: common: fix example for gpio-leds
2020-03-13 16:57 [PATCH] dt-bindings: leds: common: fix example for gpio-leds Johan Jonker
@ 2020-03-21 15:46 ` Pavel Machek
2020-03-30 18:43 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2020-03-21 15:46 UTC (permalink / raw)
To: Johan Jonker
Cc: jacek.anaszewski, dmurphy, robh+dt, linux-leds, devicetree,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 425 bytes --]
On Fri 2020-03-13 17:57:00, Johan Jonker wrote:
> The preferred form for gpio-leds compatible subnodes is:
> ^led-[0-9a-f]$
> Fix example by changing led0 and led1 to led-0 and led-1.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: leds: common: fix example for gpio-leds
2020-03-13 16:57 [PATCH] dt-bindings: leds: common: fix example for gpio-leds Johan Jonker
2020-03-21 15:46 ` Pavel Machek
@ 2020-03-30 18:43 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2020-03-30 18:43 UTC (permalink / raw)
To: Johan Jonker
Cc: jacek.anaszewski, pavel, dmurphy, robh+dt, linux-leds, devicetree,
linux-kernel
On Fri, 13 Mar 2020 17:57:00 +0100, Johan Jonker wrote:
> The preferred form for gpio-leds compatible subnodes is:
> ^led-[0-9a-f]$
> Fix example by changing led0 and led1 to led-0 and led-1.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
> Documentation/devicetree/bindings/leds/common.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Applied, thanks.
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-30 18:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-13 16:57 [PATCH] dt-bindings: leds: common: fix example for gpio-leds Johan Jonker
2020-03-21 15:46 ` Pavel Machek
2020-03-30 18:43 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).