From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19A5EC0044D for ; Sun, 15 Mar 2020 02:26:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E7A2120575 for ; Sun, 15 Mar 2020 02:26:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727324AbgCOC04 (ORCPT ); Sat, 14 Mar 2020 22:26:56 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:46588 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726557AbgCOC04 (ORCPT ); Sat, 14 Mar 2020 22:26:56 -0400 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 2594B80501; Sat, 14 Mar 2020 08:41:19 +0100 (CET) Date: Sat, 14 Mar 2020 08:41:18 +0100 From: Sam Ravnborg To: Icenowy Zheng Cc: Thierry Reding , Rob Herring , Maxime Ripard , Chen-Yu Tsai , Ondrej Jirman , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH 2/5] dt-bindings: panel: add binding for Xingbangda XBD599 panel Message-ID: <20200314074118.GD5783@ravnborg.org> References: <20200311163329.221840-1-icenowy@aosc.io> <20200311163329.221840-3-icenowy@aosc.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200311163329.221840-3-icenowy@aosc.io> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=XpTUx2N9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=gEfo2CItAAAA:8 a=NVUcaYqSR25QaaNNWYIA:9 a=CjuIK1q_8ugA:10 a=sptkURWiP4Gy88Gu7hUp:22 a=pHzHmUro8NiASowvMSCR:22 a=nt3jZW36AmriUCFCBwmW:22 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Icenowy A few comment below. Sam On Thu, Mar 12, 2020 at 12:33:26AM +0800, Icenowy Zheng wrote: > Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI LCD panel. > > Add its device tree binding. > > Signed-off-by: Icenowy Zheng > --- > .../display/panel/xingbangda,xbd599.yaml | 50 +++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/xingbangda,xbd599.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/xingbangda,xbd599.yaml b/Documentation/devicetree/bindings/display/panel/xingbangda,xbd599.yaml > new file mode 100644 > index 000000000000..62816b34de31 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/xingbangda,xbd599.yaml > @@ -0,0 +1,50 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/xingbangda,xbd599.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Xingbangda XBD599 5.99in MIPI-DSI LCD panel > + > +maintainers: > + - Icenowy Zheng > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: xingbangda,xbd599 > + reg: true > + backlight: true > + reset-gpios: true > + vcc-supply: > + description: regulator that supplies the VCC voltage Fix indent - two chars, not three > + iovcc-supply: > + description: regulator that supplies the IOVCC voltage Same here > + > +required: > + - compatible > + - reg > + - backlight > + - vcc-supply > + - iovcc-supply > + > +additionalProperties: false > + > +examples: > + - | > + &dsi { Remove '&' - dt_binding_check will fail otherwise > + #address-cells = <1>; > + #size-cells = <0>; > + > + panel@0 { > + compatible = "xingbangda,xbd599"; > + reg = <0>; > + backlight = <&backlight>; > + iovcc-supply = <®_dldo2>; > + vcc-supply = <®_ldo_io0>; > + }; > + }; > + > +... > -- > 2.24.1