From: Andrew Lunn <andrew@lunn.ch>
To: Madalin Bucur <madalin.bucur@oss.nxp.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
devicetree@vger.kernel.org, shawnguo@kernel.org,
leoyang.li@nxp.com, robh+dt@kernel.org, mark.rutland@arm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 1/3] net: fsl/fman: treat all RGMII modes in memac_adjust_link()
Date: Sat, 14 Mar 2020 22:16:01 +0100 [thread overview]
Message-ID: <20200314211601.GA8622@lunn.ch> (raw)
In-Reply-To: <1584101065-3482-2-git-send-email-madalin.bucur@oss.nxp.com>
On Fri, Mar 13, 2020 at 02:04:23PM +0200, Madalin Bucur wrote:
> Treat all internal delay variants the same as RGMII.
>
> Signed-off-by: Madalin Bucur <madalin.bucur@oss.nxp.com>
> ---
> drivers/net/ethernet/freescale/fman/fman_memac.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/fman/fman_memac.c b/drivers/net/ethernet/freescale/fman/fman_memac.c
> index e1901874c19f..0fc98584974a 100644
> --- a/drivers/net/ethernet/freescale/fman/fman_memac.c
> +++ b/drivers/net/ethernet/freescale/fman/fman_memac.c
> @@ -782,7 +782,10 @@ int memac_adjust_link(struct fman_mac *memac, u16 speed)
> /* Set full duplex */
> tmp &= ~IF_MODE_HD;
>
> - if (memac->phy_if == PHY_INTERFACE_MODE_RGMII) {
> + if (memac->phy_if == PHY_INTERFACE_MODE_RGMII ||
> + memac->phy_if == PHY_INTERFACE_MODE_RGMII_ID ||
> + memac->phy_if == PHY_INTERFACE_MODE_RGMII_RXID ||
> + memac->phy_if == PHY_INTERFACE_MODE_RGMII_TXID) {
Hi Madalin
You can use phy_interface_mode_is_rgmii()
Andrew
next prev parent reply other threads:[~2020-03-15 1:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 12:04 [PATCH net 0/3] QorIQ DPAA ARM RDBs need internal delay on RGMII Madalin Bucur
2020-03-13 12:04 ` [PATCH net 1/3] net: fsl/fman: treat all RGMII modes in memac_adjust_link() Madalin Bucur
2020-03-14 21:16 ` Andrew Lunn [this message]
2020-03-16 7:49 ` Madalin Bucur (OSS)
2020-03-16 8:39 ` Andrew Lunn
2020-03-16 9:00 ` Madalin Bucur (OSS)
2020-03-13 12:04 ` [PATCH net 2/3] arm64: dts: ls1043a-rdb: correct RGMII delay mode to rgmii-id Madalin Bucur
2020-03-14 21:18 ` Andrew Lunn
2020-03-13 12:04 ` [PATCH net 3/3] arm64: dts: ls1046ardb: set RGMII interfaces to RGMII_ID mode Madalin Bucur
2020-03-14 21:19 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200314211601.GA8622@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=madalin.bucur@oss.nxp.com \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).