From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A849C0044D for ; Mon, 16 Mar 2020 08:26:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 36CCD20719 for ; Mon, 16 Mar 2020 08:26:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729996AbgCPI0V (ORCPT ); Mon, 16 Mar 2020 04:26:21 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:41546 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728302AbgCPI0V (ORCPT ); Mon, 16 Mar 2020 04:26:21 -0400 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 42BBB2002E; Mon, 16 Mar 2020 09:26:08 +0100 (CET) Date: Mon, 16 Mar 2020 09:26:07 +0100 From: Sam Ravnborg To: Tomi Valkeinen Cc: dri-devel@lists.freedesktop.org, Thierry Reding , Rob Herring , devicetree@vger.kernel.org, Alexandre Courbot , Andrzej Hajda , Brian Masney , Chris Zhong , Douglas Anderson , Guido Gunther , Heiko Schocher , Nikolaus Schaller , Hoegeun Kwon , Jagan Teki , Jerry Han , Jonathan Bakker , Laurent Pinchart , Lin Huang , Linus Walleij , linux-spi@vger.kernel.org, Marco Franchi , Marek Belisko , Mark Brown , Maxime Ripard , Maxime Ripard , Nickey Yang , Paul Cercueil , Peter Rosin , Peter Ujfalusi , Purism Kernel Team , Robert Chiras , Sandeep Panda , Stefan Mavrodiev , Tony Lindgren , Vinay Simha BN , Werner Johansson Subject: Re: [PATCH v1 35/36] dt-bindings: display: convert lgphilips,lb035q02 to DT Schema Message-ID: <20200316082607.GA18510@ravnborg.org> References: <20200315134416.16527-1-sam@ravnborg.org> <20200315134416.16527-36-sam@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=7gkXJVJtAAAA:8 a=sozttTNsAAAA:8 a=pGLkceISAAAA:8 a=IAW4dMXMqXHR358p9ncA:9 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=aeg5Gbbo78KNqacMgKqU:22 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Tomi. Thanks for your feedback. On Mon, Mar 16, 2020 at 09:57:57AM +0200, Tomi Valkeinen wrote: > Hi Sam, > > On 15/03/2020 15:44, Sam Ravnborg wrote: > > Signed-off-by: Sam Ravnborg > > Cc: Tomi Valkeinen > > Cc: Thierry Reding > > Cc: Sam Ravnborg > > --- > > .../display/panel/lgphilips,lb035q02.txt | 33 ------------ > > .../display/panel/lgphilips,lb035q02.yaml | 54 +++++++++++++++++++ > > 2 files changed, 54 insertions(+), 33 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.txt > > create mode 100644 Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.txt b/Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.txt > > deleted file mode 100644 > > index 1a1e653e5407..000000000000 > > --- a/Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.txt > > +++ /dev/null > > @@ -1,33 +0,0 @@ > > -LG.Philips LB035Q02 Panel > > -========================= > > - > > -Required properties: > > -- compatible: "lgphilips,lb035q02" > > -- enable-gpios: panel enable gpio > > - > > -Optional properties: > > -- label: a symbolic name for the panel > > - > > -Required nodes: > > -- Video port for DPI input > > Isn't this also compatible with panel-simple bindings? 'label' is the only > one not in panel-simple, but that's optional and has never been used by the > panel driver. The panel is a SPI slave - which is not too obvious from the old binding. The new DT Schema includes spi/spi-slave.yaml to give the binding proper access to the spi slave properties. That would not be possible with panel-simple binding as no further properties are allowed with the panel-simple binding. I hope this explains why there is a dedicated binding for this panel. Sam