From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 486D3C5ACBF for ; Mon, 16 Mar 2020 08:53:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 284A720719 for ; Mon, 16 Mar 2020 08:53:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730324AbgCPIxU (ORCPT ); Mon, 16 Mar 2020 04:53:20 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:43946 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730295AbgCPIxT (ORCPT ); Mon, 16 Mar 2020 04:53:19 -0400 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id A42282002E; Mon, 16 Mar 2020 09:53:12 +0100 (CET) Date: Mon, 16 Mar 2020 09:53:11 +0100 From: Sam Ravnborg To: Tomi Valkeinen Cc: dri-devel@lists.freedesktop.org, Thierry Reding , Rob Herring , devicetree@vger.kernel.org, Alexandre Courbot , Andrzej Hajda , Brian Masney , Chris Zhong , Douglas Anderson , Guido Gunther , Heiko Schocher , Nikolaus Schaller , Hoegeun Kwon , Jagan Teki , Jerry Han , Jonathan Bakker , Laurent Pinchart , Lin Huang , Linus Walleij , linux-spi@vger.kernel.org, Marco Franchi , Marek Belisko , Mark Brown , Maxime Ripard , Maxime Ripard , Nickey Yang , Paul Cercueil , Peter Rosin , Peter Ujfalusi , Purism Kernel Team , Robert Chiras , Sandeep Panda , Stefan Mavrodiev , Tony Lindgren , Vinay Simha BN , Werner Johansson Subject: Re: [PATCH v1 35/36] dt-bindings: display: convert lgphilips,lb035q02 to DT Schema Message-ID: <20200316085311.GA19201@ravnborg.org> References: <20200315134416.16527-1-sam@ravnborg.org> <20200315134416.16527-36-sam@ravnborg.org> <20200316082607.GA18510@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=nj24DLa8QVhGY9zhrUcA:9 a=CjuIK1q_8ugA:10 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Tomi. On Mon, Mar 16, 2020 at 10:42:45AM +0200, Tomi Valkeinen wrote: > On 16/03/2020 10:26, Sam Ravnborg wrote: > > > > Isn't this also compatible with panel-simple bindings? 'label' is the only > > > one not in panel-simple, but that's optional and has never been used by the > > > panel driver. > > The panel is a SPI slave - which is not too obvious from the old > > binding. > > > > The new DT Schema includes spi/spi-slave.yaml to give the binding > > proper access to the spi slave properties. > > > > That would not be possible with panel-simple binding as no further > > properties are allowed with the panel-simple binding. > > > > I hope this explains why there is a dedicated binding for this panel. > > Hmm, but how is this different than, say, DSI panels? There are DSI panels > in panel-simple bindings, and those might require DSI bus parameters ('reg' > in the minimum). We have panel-simple-dsi for DSI simple based panels. This binding includes the reg property. If we have included DSI panels in panel-simple.yaml, and we likely have by accident, then they should be moved to panel-simple-dsi.yaml. If they requires anything else then they shall have their own binding. panel-simple.yaml and panel-simple.dsi.yaml are on purpose only for the simple panels and they have: "additionalProperties: false" to avoid that a lot of extra sneaks in. I actually considered shortly a panel-simple-spi.yaml, but the few panels I looked at had different names for the power-supply so that did not fly. I did not check them all - we have today (with this patch-set) 9 bindings that references spi-slave.yaml. Sam