From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4AA8C5ACD8 for ; Wed, 18 Mar 2020 13:08:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A95CA20724 for ; Wed, 18 Mar 2020 13:08:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584536925; bh=IK7Y5ZSmtcwGdd99YOsDwYG87YcJBtNmXMYebt4itiw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=iiwgNf22X3ZMXObL0hdbPdR9ElZSgb/4FgBbh4kH1CQ954bGZNghskQRaZaN2dq8r vCemiCApmONPFYpv0eL7glAvPNudA+uFkWEWOAeLrwOKUB6gri/Fy31Am+pYqhe5sy wTnkVtQVpX65UYNvGn4rvaMBFZW5Yve0enIImYm4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726926AbgCRNIm (ORCPT ); Wed, 18 Mar 2020 09:08:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:56670 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726767AbgCRNIl (ORCPT ); Wed, 18 Mar 2020 09:08:41 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CD8B720724; Wed, 18 Mar 2020 13:08:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584536920; bh=IK7Y5ZSmtcwGdd99YOsDwYG87YcJBtNmXMYebt4itiw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ao/O4jIgBcUwSCsqm5OQ5agm3YDTJ5N6RbEIYQECoGVoyxucRrKGyKpCerM8428XJ aCpTzqj+I0NJC510y9k85ukfosiquOlCq2FBoibr8MH08Gx24pBrpOzPgvjCPF6mp/ eCzNrbj4EaMiVzYfLuTKgiRZ5B8eYc1rCeEr4U3c= Date: Wed, 18 Mar 2020 14:08:38 +0100 From: Greg Kroah-Hartman To: Matti Vaittinen Cc: mazziesaccount@gmail.com, Sebastian Reichel , Rob Herring , Mark Rutland , "Rafael J. Wysocki" , Liam Girdwood , Mark Brown , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Markus Laine , Mikko Mutanen Subject: Re: [PATCH v4 3/9] drivers: base: add linear ranges helpers Message-ID: <20200318130838.GB2769584@kroah.com> References: <01ac2439f9d33ae405999065c5d28c368bad4a28.1582617178.git.matti.vaittinen@fi.rohmeurope.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <01ac2439f9d33ae405999065c5d28c368bad4a28.1582617178.git.matti.vaittinen@fi.rohmeurope.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Feb 25, 2020 at 10:53:01AM +0200, Matti Vaittinen wrote: > Many devices have control registers which control some measurable > property. Often a register contains control field so that change in > this field causes linear change in the controlled property. It is not > a rare case that user wants to give 'meaningful' control values and > driver needs to convert them to register field values. Even more > often user wants to 'see' the currently set value - again in > meaningful units - and driver needs to convert the values it reads > from register to these meaningful units. Examples of this include: > > - regulators, voltage/current configurations > - power, voltage/current configurations > - clk(?) NCOs > > and maybe others I can't think of right now. > > Provide a linear_range helper which can do conversion from user value > to register value 'selector'. > > The idea here is stolen from regulator framework and patches refactoring > the regulator helpers to use this are following. > > Signed-off-by: Matti Vaittinen > --- > > Changes since rfc-v3: > - Kerneldoc fixes > - Corrected commit message typo meaningfull => meaningful > > drivers/base/Kconfig | 3 + > drivers/base/Makefile | 1 + > drivers/base/linear_ranges.c | 246 +++++++++++++++++++++++++++++++++++ Why in drivers/base/ ? Why not in lib/ ? > include/linux/linear_range.h | 48 +++++++ > 4 files changed, 298 insertions(+) > create mode 100644 drivers/base/linear_ranges.c > create mode 100644 include/linux/linear_range.h > > diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig > index 5f0bc74d2409..636b6fa8e499 100644 > --- a/drivers/base/Kconfig > +++ b/drivers/base/Kconfig > @@ -209,4 +209,7 @@ config GENERIC_ARCH_TOPOLOGY > appropriate scaling, sysfs interface for reading capacity values at > runtime. > > +config LINEAR_RANGES > + tristate No help text at all??? > +EXPORT_SYMBOL(linear_range_values_in_range); EXPORT_SYMBOL_GPL() for all of these? I have to ask... > @@ -0,0 +1,48 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later */ Are you sure about the "or later"? Again, I have to ask. > +/* Copyright (C) 2020 ROHM Semiconductors */ > + > +#ifndef LINEAR_RANGE_H > +#define LINEAR_RANGE_H > + > +#include Why is this needed? thanks, greg k-h