devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Peter Chen <peter.chen@nxp.com>
Cc: robh+dt@kernel.org, kishon@ti.com, devicetree@vger.kernel.org,
	linux-usb@vger.kernel.org, jun.li@nxp.com, linux-imx@nxp.com,
	Peter Chen <peter.chen@nxp.com>
Subject: Re: [PATCH v2 2/2] doc: dt-binding: cdns-salvo-phy: add binding doc
Date: Wed, 18 Mar 2020 16:04:20 -0600	[thread overview]
Message-ID: <20200318220420.GA15468@bogus> (raw)
In-Reply-To: <20200314093941.2533-2-peter.chen@nxp.com>

On Sat, 14 Mar 2020 17:39:41 +0800, Peter Chen wrote:
> Add Cadence SALVO PHY binding doc, this PHY is a legacy module,
> and is only used for USB3 and USB2.
> 
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
> Changes for v2:
> - Fix kinds of yaml style issue
> 
>  .../bindings/phy/cdns,salvo-phy.yaml          | 49 +++++++++++++++++++
>  1 file changed, 49 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/cdns,salvo-phy.example.dt.yaml: usb3-phy@5B160000: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/cdns,salvo-phy.example.dt.yaml: usb3-phy@5B160000: #phy-cells:0:0: 1 was expected

See https://patchwork.ozlabs.org/patch/1254920
Please check and re-submit.

  reply	other threads:[~2020-03-18 22:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-14  9:39 [PATCH v2 1/2] phy: cadence: salvo: add salvo phy driver Peter Chen
2020-03-14  9:39 ` [PATCH v2 2/2] doc: dt-binding: cdns-salvo-phy: add binding doc Peter Chen
2020-03-18 22:04   ` Rob Herring [this message]
2020-03-19  6:46     ` Peter Chen
2020-03-19 17:34       ` Rob Herring
2020-03-20  1:28         ` Peter Chen
2020-03-23 15:01           ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200318220420.GA15468@bogus \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jun.li@nxp.com \
    --cc=kishon@ti.com \
    --cc=linux-imx@nxp.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=peter.chen@nxp.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).