Re: [PATCH v1 36/36] dt-bindings: display: convert olimex,lcd-olinuxino to DT Schema

[Rob Herring <robh@kernel.org>]

On Sun, Mar 15, 2020 at 02:44:16PM +0100, Sam Ravnborg wrote:
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Stefan Mavrodiev <stefan@olimex.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> ---
>  .../display/panel/olimex,lcd-olinuxino.txt    | 42 -----------
>  .../display/panel/olimex,lcd-olinuxino.yaml   | 70 +++++++++++++++++++
>  2 files changed, 70 insertions(+), 42 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/display/panel/olimex,lcd-olinuxino.txt
>  create mode 100644 Documentation/devicetree/bindings/display/panel/olimex,lcd-olinuxino.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/olimex,lcd-olinuxino.txt b/Documentation/devicetree/bindings/display/panel/olimex,lcd-olinuxino.txt
> deleted file mode 100644
> index a89f9c830a85..000000000000
> --- a/Documentation/devicetree/bindings/display/panel/olimex,lcd-olinuxino.txt
> +++ /dev/null
> @@ -1,42 +0,0 @@
> -Binding for Olimex Ltd. LCD-OLinuXino bridge panel.
> -
> -This device can be used as bridge between a host controller and LCD panels.
> -Currently supported LCDs are:
> -  - LCD-OLinuXino-4.3TS
> -  - LCD-OLinuXino-5
> -  - LCD-OLinuXino-7
> -  - LCD-OLinuXino-10
> -
> -The panel itself contains:
> -  - AT24C16C EEPROM holding panel identification and timing requirements
> -  - AR1021 resistive touch screen controller (optional)
> -  - FT5x6 capacitive touch screnn controller (optional)
> -  - GT911/GT928 capacitive touch screen controller (optional)
> -
> -The above chips share same I2C bus. The EEPROM is factory preprogrammed with
> -device information (id, serial, etc.) and timing requirements.
> -
> -Touchscreen bingings can be found in these files:
> -  - input/touchscreen/goodix.txt
> -  - input/touchscreen/edt-ft5x06.txt
> -  - input/touchscreen/ar1021.txt
> -
> -Required properties:
> -  - compatible: should be "olimex,lcd-olinuxino"
> -  - reg: address of the configuration EEPROM, should be <0x50>
> -  - power-supply: phandle of the regulator that provides the supply voltage
> -
> -Optional properties:
> -  - enable-gpios: GPIO pin to enable or disable the panel
> -  - backlight: phandle of the backlight device attacked to the panel
> -
> -Example:
> -&i2c2 {
> -	panel@50 {
> -		compatible = "olimex,lcd-olinuxino";
> -		reg = <0x50>;
> -		power-supply = <&reg_vcc5v0>;
> -		enable-gpios = <&pio 7 8 GPIO_ACTIVE_HIGH>;
> -		backlight = <&backlight>;
> -	};
> -};
> diff --git a/Documentation/devicetree/bindings/display/panel/olimex,lcd-olinuxino.yaml b/Documentation/devicetree/bindings/display/panel/olimex,lcd-olinuxino.yaml
> new file mode 100644
> index 000000000000..22d664abd552
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/olimex,lcd-olinuxino.yaml
> @@ -0,0 +1,70 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/olimex,lcd-olinuxino.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Binding for Olimex Ltd. LCD-OLinuXino bridge panel.
> +
> +maintainers:
> +  - Stefan Mavrodiev <stefan@olimex.com>
> +
> +description: |
> +  This device can be used as bridge between a host controller and LCD panels.
> +  Currently supported LCDs are:
> +    - LCD-OLinuXino-4.3TS
> +    - LCD-OLinuXino-5
> +    - LCD-OLinuXino-7
> +    - LCD-OLinuXino-10
> +
> +  The panel itself contains:
> +    - AT24C16C EEPROM holding panel identification and timing requirements
> +    - AR1021 resistive touch screen controller (optional)
> +    - FT5x6 capacitive touch screnn controller (optional)
> +    - GT911/GT928 capacitive touch screen controller (optional)
> +
> +  The above chips share same I2C bus. The EEPROM is factory preprogrammed with
> +  device information (id, serial, etc.) and timing requirements.
> +
> +  Touchscreen bingings can be found in these files:
> +    - input/touchscreen/goodix.yaml
> +    - input/touchscreen/edt-ft5x06.txt
> +    - input/touchscreen/ar1021.txt
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +  compatible:
> +    const: olimex,lcd-olinuxino
> +
> +  backlight: true
> +  enable-gpios: true
> +  power-supply: true
> +  reg: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - power-supply
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    i2c2 {

i2c {

> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        panel@50 {
> +            compatible = "olimex,lcd-olinuxino";
> +            reg = <0x50>;
> +            power-supply = <&reg_vcc5v0>;
> +            enable-gpios = <&pio 7 8 GPIO_ACTIVE_HIGH>;
> +            backlight = <&backlight>;
> +        };
> +    };
> +
> +...
> -- 
> 2.20.1
>