Re: [PATCH v2 2/2] doc: dt-binding: cdns-salvo-phy: add binding doc

[Peter Chen <peter.chen@nxp.com>]

On 20-03-18 16:04:20, Rob Herring wrote:
> On Sat, 14 Mar 2020 17:39:41 +0800, Peter Chen wrote:
> > Add Cadence SALVO PHY binding doc, this PHY is a legacy module,
> > and is only used for USB3 and USB2.
> > 
> > Signed-off-by: Peter Chen <peter.chen@nxp.com>
> > ---
> > Changes for v2:
> > - Fix kinds of yaml style issue
> > 
> >  .../bindings/phy/cdns,salvo-phy.yaml          | 49 +++++++++++++++++++
> >  1 file changed, 49 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml
> > 
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/cdns,salvo-phy.example.dt.yaml: usb3-phy@5B160000: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+'

The 'power-domains' is described at:
Documentation/devicetree/bindings/power/power_domain.txt

> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/cdns,salvo-phy.example.dt.yaml: usb3-phy@5B160000: #phy-cells:0:0: 1 was expected
> 

#phy-cell could be 0 if it is a dedicated PHY, eg single function PHY.
See below comments from drivers/phy/phy-core.c

/**
 * of_phy_simple_xlate() - returns the phy instance from phy provider
 * @dev: the PHY provider device
 * @args: of_phandle_args (not used here)
 *
 * Intended to be used by phy provider for the common case where #phy-cells is
 * 0. For other cases where #phy-cells is greater than '0', the phy provider
 * should provide a custom of_xlate function that reads the *args* and returns
 * the appropriate phy.
 */

-- 

Thanks,
Peter Chen