From: Wolfram Sang <wsa@the-dreams.de>
To: Bibby Hsieh <bibby.hsieh@mediatek.com>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
linux-i2c@vger.kernel.org, tfiga@chromium.org,
drinkcat@chromium.org, srv_heupstream@mediatek.com,
robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH v12 1/2] dt-binding: i2c: add bus-supply property
Date: Sun, 22 Mar 2020 14:07:10 +0100 [thread overview]
Message-ID: <20200322130710.GA1091@ninjato> (raw)
In-Reply-To: <20200306034946.11223-2-bibby.hsieh@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 646 bytes --]
Hi,
thanks for the patches!
I have a high level question about them, first.
> +- bus-supply
> + phandle to the regulator that provides power to i2c.
I think this is not clear enough. I assume it means the regulator for
driving SCL/SDA? In the coverletter you mention also an EEPROM. In your
case, this is driven by the same regulator? I am skeptical we can
abstract it like this because I2C devices could be driven by various
regulators in the system, so there couldn't be one "bus regulator". The
regulator for the EEPROM should be described in the EEPROM node. So,
this "bus supply" is only for driving SCL/SDA?
Kind regards,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-03-22 13:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 3:49 [PATCH v12 0/2] add power control in i2c and at24 Bibby Hsieh
2020-03-06 3:49 ` [PATCH v12 1/2] dt-binding: i2c: add bus-supply property Bibby Hsieh
2020-03-22 13:07 ` Wolfram Sang [this message]
2020-03-23 12:18 ` Tomasz Figa
2020-03-24 10:34 ` Wolfram Sang
2020-04-15 8:49 ` Bibby Hsieh
2020-04-15 18:20 ` Tomasz Figa
2020-03-06 3:49 ` [PATCH v12 2/2] i2c: core: support bus regulator controlling in adapter Bibby Hsieh
2020-03-06 5:09 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200322130710.GA1091@ninjato \
--to=wsa@the-dreams.de \
--cc=bgolaszewski@baylibre.com \
--cc=bibby.hsieh@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=linux-i2c@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).