From: Jonathan Cameron <jic23@kernel.org>
To: Alexandru Lazar <alazar@startmail.com>
Cc: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"knaack.h@gmx.de" <knaack.h@gmx.de>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
"lars@metafoo.de" <lars@metafoo.de>
Subject: Re: [PATCH v4 1/2] dt-bindings: iio: adc: Add MAX1241 device tree bindings in documentation
Date: Sun, 22 Mar 2020 15:27:35 +0000 [thread overview]
Message-ID: <20200322152735.36cb3493@archlinux> (raw)
In-Reply-To: <20200322095317.GA3099@leena.republic>
On Sun, 22 Mar 2020 11:53:17 +0200
Alexandru Lazar <alazar@startmail.com> wrote:
> > Yep.
> > Jonathan refers to Vdd input/pin [on the chip] which is different from Vref [REF
> > pin].
> > Not all drivers define Vdd.
> > Some call it AVdd.
> >
> > [...]
> >
> > It's an idea to add it, and that can give control to the driver to power-up the
> > ADC, by defining a regulator [vdd-supply] in the device-tree.
>
> Hmm... I don't know how useful this would be for the 124x family (I
> doubt anyone who needs one of these will power it from its own,
> independent supply),
You'd be surprised how often this gets added to drivers precisely because
people will put it on a controllable supply. It may well not have it's own
supply but it may share one with a bunch of other external chips and
all of them need to use the regulator framework controls to make sure it's
only disabled when they are all suspended etc.
See the number of times Linus Walleij has added this for various sensors
and ADCs because he has boards where the control is needed.
Jonathan
> but it's a pretty harmless change. I can't think of
> any reason to say no :-).
>
> Thanks,
> Alex
next prev parent reply other threads:[~2020-03-22 15:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 15:01 [PATCH v4 0/2] Maxim MAX1241 driver Alexandru Lazar
2020-03-20 15:01 ` [PATCH v4 1/2] dt-bindings: iio: adc: Add MAX1241 device tree bindings in documentation Alexandru Lazar
2020-03-21 17:34 ` Jonathan Cameron
2020-03-21 19:35 ` Alexandru Lazar
2020-03-22 9:02 ` Ardelean, Alexandru
2020-03-22 9:53 ` Alexandru Lazar
2020-03-22 15:27 ` Jonathan Cameron [this message]
2020-03-22 16:06 ` Alexandru Lazar
2020-03-22 16:57 ` Jonathan Cameron
2020-03-22 15:25 ` Jonathan Cameron
2020-03-30 23:39 ` Rob Herring
2020-03-20 15:01 ` [PATCH v4 2/2] iio: adc: Add MAX1241 driver Alexandru Lazar
2020-03-21 18:00 ` Jonathan Cameron
2020-03-21 21:56 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200322152735.36cb3493@archlinux \
--to=jic23@kernel.org \
--cc=alazar@startmail.com \
--cc=alexandru.Ardelean@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).