From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23122C54FCF for ; Sun, 22 Mar 2020 15:27:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E05F020732 for ; Sun, 22 Mar 2020 15:27:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584890863; bh=3CssCZF64v9fgPWSZK1WSg+HeERYSeMfmZIBUZnvokE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=qt3sa9o4uT0m9tEUO+qdfWZVwzcMX1d1A9yD5VMDSRw7FoqVQanTkm84MJ3krWkaG FQMsrALNzm2Y2ds4+u0Rd7K4CJG66F4vTnIBFEWptxFhqD6PsEwDYT6wNGN8E+ahT8 mCBqCXPG54FOLXhfCPFrwHQyl3/WKIQZel2Flivc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726809AbgCVP1m (ORCPT ); Sun, 22 Mar 2020 11:27:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:55230 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725785AbgCVP1l (ORCPT ); Sun, 22 Mar 2020 11:27:41 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8736D20724; Sun, 22 Mar 2020 15:27:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584890861; bh=3CssCZF64v9fgPWSZK1WSg+HeERYSeMfmZIBUZnvokE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dAfTaQoQjFygU8FJt+8XuGHWfl/RXqWvDFJ9omvJpVpyT93XDCG2tMUASLvWQvpNl tX+3xbf+6rT3DXpIdkeo+mUFxGzBsMnT5CjxObFQC942M5GDuEjDkgXRN8+mtcKDyG IRWjP7kg38M+i/A91J/sBjwP2qe+7lBnbYT77lWQ= Date: Sun, 22 Mar 2020 15:27:35 +0000 From: Jonathan Cameron To: Alexandru Lazar Cc: "Ardelean, Alexandru" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "knaack.h@gmx.de" , "linux-iio@vger.kernel.org" , "pmeerw@pmeerw.net" , "lars@metafoo.de" Subject: Re: [PATCH v4 1/2] dt-bindings: iio: adc: Add MAX1241 device tree bindings in documentation Message-ID: <20200322152735.36cb3493@archlinux> In-Reply-To: <20200322095317.GA3099@leena.republic> References: <20200320150114.9297-1-alazar@startmail.com> <20200320150114.9297-2-alazar@startmail.com> <20200321173412.52548ef1@archlinux> <20200321193541.GA16892@leena.republic> <1e51c4079222858410e9fe94c9d7f21d99abfe15.camel@analog.com> <20200322095317.GA3099@leena.republic> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, 22 Mar 2020 11:53:17 +0200 Alexandru Lazar wrote: > > Yep. > > Jonathan refers to Vdd input/pin [on the chip] which is different from Vref [REF > > pin]. > > Not all drivers define Vdd. > > Some call it AVdd. > > > > [...] > > > > It's an idea to add it, and that can give control to the driver to power-up the > > ADC, by defining a regulator [vdd-supply] in the device-tree. > > Hmm... I don't know how useful this would be for the 124x family (I > doubt anyone who needs one of these will power it from its own, > independent supply), You'd be surprised how often this gets added to drivers precisely because people will put it on a controllable supply. It may well not have it's own supply but it may share one with a bunch of other external chips and all of them need to use the regulator framework controls to make sure it's only disabled when they are all suspended etc. See the number of times Linus Walleij has added this for various sensors and ADCs because he has boards where the control is needed. Jonathan > but it's a pretty harmless change. I can't think of > any reason to say no :-). > > Thanks, > Alex