devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Rob Herring <robh+dt@kernel.org>,
	Jon Hunter <jonathanh@nvidia.com>,
	linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] clocksource: Add Tegra186 timers support
Date: Mon, 23 Mar 2020 14:42:21 +0100	[thread overview]
Message-ID: <20200323134221.GI3883508@ulmo> (raw)
In-Reply-To: <da2a0501-664a-c5d0-7b13-174e5347eaf7@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1079 bytes --]

On Fri, Mar 20, 2020 at 06:38:32PM +0300, Dmitry Osipenko wrote:
> 20.03.2020 18:11, Dmitry Osipenko пишет:
> > 20.03.2020 16:34, Thierry Reding пишет:
> >> From: Thierry Reding <treding@nvidia.com>
> >>
> >> Currently this only supports a single watchdog, which uses a timer in
> >> the background for countdown. Eventually the timers could be used for
> >> various time-keeping tasks, but by default the architected timer will
> >> already provide that functionality.
> >>
> >> Signed-off-by: Thierry Reding <treding@nvidia.com>
> >> ---
> > 
> > ...
> >> +config TEGRA186_TIMER
> >> +	bool "NVIDIA Tegra186 timer driver"
> > 
> > tristate?
> > 
> >> +	depends on ARCH_TEGRA || COMPILE_TEST
> > 
> > depends on WATCHDOG && WATCHDOG_CORE?
> 
> Actually `select WATCHDOG_CORE` for the WATCHDOG_CORE.

WATCHDOG_CORE is user-visible, so it's not safe to select it. Any reason
depends on WATCHDOG && WATCHDOG_CORE wouldn't work? I guess a dependency
on WATCHDOG_CORE would be enough because that itself already depends on
WATCHDOG.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-03-23 13:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-20 13:34 [PATCH 0/7] clocksource: Add NVIDIA Tegra186 timers support Thierry Reding
2020-03-20 13:34 ` [PATCH 1/7] dt-bindings: timer: Add bindings for NVIDIA Tegra186 timers Thierry Reding
2020-03-30 23:28   ` Rob Herring
2020-03-20 13:34 ` [PATCH 2/7] clocksource: Add Tegra186 timers support Thierry Reding
2020-03-20 14:39   ` Dmitry Osipenko
2020-03-20 15:04     ` Thierry Reding
2020-03-20 15:23       ` Dmitry Osipenko
2020-03-23 13:38         ` Thierry Reding
2020-03-31 20:04         ` Thierry Reding
2020-03-20 15:11   ` Dmitry Osipenko
2020-03-20 15:38     ` Dmitry Osipenko
2020-03-23 13:42       ` Thierry Reding [this message]
2020-03-23 13:45         ` Dmitry Osipenko
2020-03-23 16:10           ` Dmitry Osipenko
2020-03-31 19:58           ` Thierry Reding
2020-03-20 13:34 ` [PATCH 3/7] arm64: tegra: Order nodes by unit-address on Tegra194 Thierry Reding
2020-03-20 13:34 ` [PATCH 4/7] arm64: tegra: Add native timer support on Tegra186 Thierry Reding
2020-03-20 13:34 ` [PATCH 5/7] arm64: tegra: Enable native timers on Jetson TX2 Thierry Reding
2020-03-20 13:34 ` [PATCH 6/7] arm64: tegra: Add native timer support on Tegra194 Thierry Reding
2020-03-20 13:34 ` [PATCH 7/7] arm64: tegra: Enable native timers on Jetson AGX Xavier Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200323134221.GI3883508@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=digetx@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).