From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: mazziesaccount@gmail.com,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Mikko Mutanen" <mikko.mutanen@fi.rohmeurope.com>,
"Markus Laine" <markus.laine@fi.rohmeurope.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Ard Biesheuvel" <ardb@kernel.org>,
"Borislav Petkov" <bp@suse.de>,
"Brendan Higgins" <brendanhiggins@google.com>,
"Changbin Du" <changbin.du@intel.com>,
"Dan Williams" <dan.j.williams@intel.com>,
"David Gow" <davidgow@google.com>,
"David S. Miller" <davem@davemloft.net>,
devicetree@vger.kernel.org, "Gary Hook" <Gary.Hook@amd.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
"Mark Rutland" <mark.rutland@arm.com>,
"Masahiro Yamada" <yamada.masahiro@socionext.com>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Mikhail Zaslonko" <zaslonko@linux.ibm.com>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Sebastian Reichel" <sre@kernel.org>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Tal Gilboa" <talgi@mellanox.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Uwe Kleine-König" <uwe@kleine-koenig.org>,
"Vincenzo Frascino" <vincenzo.frascino@arm.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>
Subject: Re: [PATCH v6 09/10] power: supply: Support ROHM bd99954 charger
Date: Tue, 24 Mar 2020 12:35:57 +0200 [thread overview]
Message-ID: <20200324103557.GH1922688@smile.fi.intel.com> (raw)
In-Reply-To: <20200324095024.GE1922688@smile.fi.intel.com>
On Tue, Mar 24, 2020 at 11:50:24AM +0200, Andy Shevchenko wrote:
> On Tue, Mar 24, 2020 at 10:32:19AM +0200, Matti Vaittinen wrote:
> > +#include <linux/acpi.h>
>
> > +#include <linux/of.h>
>
> I didn't find any evidence of use of those two, otherwise, missed property.h
> and perhaps mod_devicetable.h.
...
> > +MODULE_DEVICE_TABLE(of, bd9995x_of_match);
> > +MODULE_DEVICE_TABLE(acpi, bd9995x_acpi_match);
I have to add since you are using those macros without ifdeffery, you should
get warning in !ACPI and/or !OF cases.
So, drop those of_match_ptr() / ACPI_PTR() and thus above headers.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-03-24 10:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1584977512.git.matti.vaittinen@fi.rohmeurope.com>
2020-03-24 8:27 ` [PATCH v6 01/10] dt-bindings: battery: add new battery parameters Matti Vaittinen
2020-03-24 8:28 ` [PATCH v6 02/10] dt_bindings: ROHM BD99954 Charger Matti Vaittinen
2020-03-24 8:29 ` [PATCH v6 04/10] lib/test_linear_ranges: add a test for the 'linear_ranges' Matti Vaittinen
2020-03-24 9:14 ` Andy Shevchenko
2020-03-24 9:51 ` Vaittinen, Matti
2020-03-24 8:30 ` [PATCH v6 05/10] power: supply: bd70528: rename linear_range to avoid collision Matti Vaittinen
2020-03-24 8:31 ` [PATCH v6 07/10] power: supply: bd70528: use linear ranges Matti Vaittinen
2020-03-24 8:31 ` [PATCH v6 08/10] power: supply: add battery parameters Matti Vaittinen
2020-03-24 8:32 ` [PATCH v6 09/10] power: supply: Support ROHM bd99954 charger Matti Vaittinen
2020-03-24 9:50 ` Andy Shevchenko
2020-03-24 9:51 ` Andy Shevchenko
2020-03-24 10:30 ` Vaittinen, Matti
2020-03-24 10:35 ` Andy Shevchenko [this message]
2020-03-25 11:36 ` Vaittinen, Matti
2020-03-25 12:09 ` andriy.shevchenko
2020-03-25 13:00 ` Vaittinen, Matti
2020-03-25 13:20 ` andriy.shevchenko
2020-03-25 13:21 ` andriy.shevchenko
2020-03-25 13:47 ` Vaittinen, Matti
2020-03-24 10:53 ` Vaittinen, Matti
2020-03-24 11:56 ` andriy.shevchenko
2020-03-25 10:14 ` Vaittinen, Matti
2020-03-25 12:05 ` andriy.shevchenko
2020-03-25 9:47 ` Vaittinen, Matti
2020-03-24 8:32 ` [PATCH v6 10/10] power: supply: Fix Kconfig help text indentiation Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200324103557.GH1922688@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Gary.Hook@amd.com \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=bp@suse.de \
--cc=brendanhiggins@google.com \
--cc=broonie@kernel.org \
--cc=changbin.du@intel.com \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=davidgow@google.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=markus.laine@fi.rohmeurope.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=mhiramat@kernel.org \
--cc=mikko.mutanen@fi.rohmeurope.com \
--cc=olteanv@gmail.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=sre@kernel.org \
--cc=talgi@mellanox.com \
--cc=tglx@linutronix.de \
--cc=uwe@kleine-koenig.org \
--cc=vincenzo.frascino@arm.com \
--cc=yamada.masahiro@socionext.com \
--cc=zaslonko@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).