From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3B92C43331 for ; Thu, 26 Mar 2020 21:21:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AADF520714 for ; Thu, 26 Mar 2020 21:21:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="gQYyIFUd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727652AbgCZVV0 (ORCPT ); Thu, 26 Mar 2020 17:21:26 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:51180 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726034AbgCZVV0 (ORCPT ); Thu, 26 Mar 2020 17:21:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=b7jMbEyQgBchxaYjnbMWehFvMY/YBtuPrMn94qG6tQk=; b=gQYyIFUdaqkeFxtOuw5YOVSw4 EYRnbTd2281MagMR2RbxpOqSABlL5dEAm7nP9sGfwl5UqKeuR5bzEVyd4ZYxJMDlJuu/9i6xNV0E9 /r93HysVOAuRlo31GFTKmnssGxwOXE8avmdv6ggcQXwJKx/0GXbSzGICtTq7hIz0yrQ/Ns1n9paxc /aGq0m+H0iGMiGoUfNjXQ1EnU2BHwbR058zWgZ0lcBwOs36l0bmAiB5AiEuc0cyAKjo1xT1QmYI4b LeJV8Xfl+goiQ2K7XdG5MtmJ5jxm+wf8fx5/h+OX+stWTQQzTGEU7gXzROR7yOahHRH7pAVtjf5lY K/kg0dzvQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:41760) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jHZw3-0005cQ-FQ; Thu, 26 Mar 2020 21:21:07 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jHZw0-0003Y9-9h; Thu, 26 Mar 2020 21:21:04 +0000 Date: Thu, 26 Mar 2020 21:21:04 +0000 From: Russell King - ARM Linux admin To: Ioana Ciornei Cc: Andrew Lunn , Florian Fainelli , Heiner Kallweit , Mark Rutland , "devicetree@vger.kernel.org" , "netdev@vger.kernel.org" , Leo Li , Rob Herring , Shawn Guo , "David S. Miller" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [RFC net-next 3/5] arm64: dts: lx2160a: add PCS MDIO nodes Message-ID: <20200326212104.GE25745@shell.armlinux.org.uk> References: <20200317144944.GP25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Mar 26, 2020 at 09:14:13PM +0000, Ioana Ciornei wrote: > > Subject: [RFC net-next 3/5] arm64: dts: lx2160a: add PCS MDIO nodes > > > > *NOT FOR MERGING* > > > > Add PCS MDIO nodes for the LX2160A, which will be used when the MAC is in > > PHY mode and is using in-band negotiation. > > > > Signed-off-by: Russell King > > --- > > .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 144 ++++++++++++++++++ > > 1 file changed, 144 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > > b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > > index e5ee5591e52b..732af33eec18 100644 > > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > > @@ -960,6 +960,132 @@ > > status = "disabled"; > > }; > > > > + pcs_mdio1: mdio@8c07000 { > > + compatible = "fsl,fman-memac-mdio"; > > + reg = <0x0 0x8c07000 0x0 0x1000>; > > + little-endian; > > + status = "disabled"; > > + }; > > Are the PCS MDIO buses shareable? I am asking this because in case of QSGMII our structure is a little bit quirky. > There are 4 MACs but all PCSs sit on the first MACs internal MDIO bus only. The other 3 internal MDIO buses are empty. I haven't looked at QSGMII yet, I've only considered single-lane setups and only implemented that. For _this_ part, it doesn't matter as this is just declaring where the hardware is. I think that matters more for the dpmac nodes. > > + > > + pcs_mdio2: mdio@8c0b000 { > > + compatible = "fsl,fman-memac-mdio"; > > + reg = <0x0 0x8c0b000 0x0 0x1000>; > > + little-endian; > > + status = "disabled"; > > + }; > > + > > + pcs_mdio3: mdio@8c0f000 { > > + compatible = "fsl,fman-memac-mdio"; > > + reg = <0x0 0x8c0f000 0x0 0x1000>; > > + little-endian; > > + status = "disabled"; > > + }; > > + > > + pcs_mdio4: mdio@8c13000 { > > + compatible = "fsl,fman-memac-mdio"; > > + reg = <0x0 0x8c13000 0x0 0x1000>; > > + little-endian; > > + status = "disabled"; > > + }; > > + > > + pcs_mdio5: mdio@8c17000 { > > + compatible = "fsl,fman-memac-mdio"; > > + reg = <0x0 0x8c17000 0x0 0x1000>; > > + little-endian; > > + status = "disabled"; > > + }; > > + > > + pcs_mdio6: mdio@8c1b000 { > > + compatible = "fsl,fman-memac-mdio"; > > + reg = <0x0 0x8c1b000 0x0 0x1000>; > > + little-endian; > > + status = "disabled"; > > + }; > > + > > + pcs_mdio7: mdio@8c1f000 { > > + compatible = "fsl,fman-memac-mdio"; > > + reg = <0x0 0x8c1f000 0x0 0x1000>; > > + little-endian; > > + status = "disabled"; > > + }; > > + > > + pcs_mdio8: mdio@8c23000 { > > + compatible = "fsl,fman-memac-mdio"; > > + reg = <0x0 0x8c23000 0x0 0x1000>; > > + little-endian; > > + status = "disabled"; > > + }; > > + > > + pcs_mdio9: mdio@8c27000 { > > + compatible = "fsl,fman-memac-mdio"; > > + reg = <0x0 0x8c27000 0x0 0x1000>; > > + little-endian; > > + status = "disabled"; > > + }; > > + > > + pcs_mdio10: mdio@8c2b000 { > > + compatible = "fsl,fman-memac-mdio"; > > + reg = <0x0 0x8c2b000 0x0 0x1000>; > > + little-endian; > > + status = "disabled"; > > + }; > > + > > + pcs_mdio11: mdio@8c2f000 { > > + compatible = "fsl,fman-memac-mdio"; > > + reg = <0x0 0x8c2f000 0x0 0x1000>; > > + little-endian; > > + status = "disabled"; > > + }; > > + > > + pcs_mdio12: mdio@8c33000 { > > + compatible = "fsl,fman-memac-mdio"; > > + reg = <0x0 0x8c33000 0x0 0x1000>; > > + little-endian; > > + status = "disabled"; > > + }; > > + > > + pcs_mdio13: mdio@8c37000 { > > + compatible = "fsl,fman-memac-mdio"; > > + reg = <0x0 0x8c37000 0x0 0x1000>; > > + little-endian; > > + status = "disabled"; > > + }; > > + > > + pcs_mdio14: mdio@8c3b000 { > > + compatible = "fsl,fman-memac-mdio"; > > + reg = <0x0 0x8c3b000 0x0 0x1000>; > > + little-endian; > > + status = "disabled"; > > + }; > > + > > + pcs_mdio15: mdio@8c3f000 { > > + compatible = "fsl,fman-memac-mdio"; > > + reg = <0x0 0x8c3f000 0x0 0x1000>; > > + little-endian; > > + status = "disabled"; > > + }; > > + > > + pcs_mdio16: mdio@8c43000 { > > + compatible = "fsl,fman-memac-mdio"; > > + reg = <0x0 0x8c43000 0x0 0x1000>; > > + little-endian; > > + status = "disabled"; > > + }; > > + > > + pcs_mdio17: mdio@8c47000 { > > + compatible = "fsl,fman-memac-mdio"; > > + reg = <0x0 0x8c47000 0x0 0x1000>; > > + little-endian; > > + status = "disabled"; > > + }; > > + > > + pcs_mdio18: mdio@8c4b000 { > > + compatible = "fsl,fman-memac-mdio"; > > + reg = <0x0 0x8c4b000 0x0 0x1000>; > > + little-endian; > > + status = "disabled"; > > + }; > > + > > Please sort the nodes alphabetically. Huh? The nodes in this file are already sorted according to address, and this patch preserves that sorting. The hex address field also happens to be alphabetical. Or do you mean the label for these modes - I've never heard of sorting by label for a SoC file. > > fsl_mc: fsl-mc@80c000000 { > > compatible = "fsl,qoriq-mc"; > > reg = <0x00000008 0x0c000000 0 0x40>, @@ -988,91 > > +1114,109 @@ > > dpmac1: dpmac@1 { > > compatible = "fsl,qoriq-mc-dpmac"; > > reg = <0x1>; > > + pcs-mdio = <&pcs_mdio1>; > > }; > > > > dpmac2: dpmac@2 { > > compatible = "fsl,qoriq-mc-dpmac"; > > reg = <0x2>; > > + pcs-mdio = <&pcs_mdio2>; > > }; > > > > dpmac3: dpmac@3 { > > compatible = "fsl,qoriq-mc-dpmac"; > > reg = <0x3>; > > + pcs-mdio = <&pcs_mdio3>; > > }; > > > > dpmac4: dpmac@4 { > > compatible = "fsl,qoriq-mc-dpmac"; > > reg = <0x4>; > > + pcs-mdio = <&pcs_mdio4>; > > }; > > > > dpmac5: dpmac@5 { > > compatible = "fsl,qoriq-mc-dpmac"; > > reg = <0x5>; > > + pcs-mdio = <&pcs_mdio5>; > > }; > > > > dpmac6: dpmac@6 { > > compatible = "fsl,qoriq-mc-dpmac"; > > reg = <0x6>; > > + pcs-mdio = <&pcs_mdio6>; > > }; > > > > dpmac7: dpmac@7 { > > compatible = "fsl,qoriq-mc-dpmac"; > > reg = <0x7>; > > + pcs-mdio = <&pcs_mdio7>; > > }; > > > > dpmac8: dpmac@8 { > > compatible = "fsl,qoriq-mc-dpmac"; > > reg = <0x8>; > > + pcs-mdio = <&pcs_mdio8>; > > }; > > > > dpmac9: dpmac@9 { > > compatible = "fsl,qoriq-mc-dpmac"; > > reg = <0x9>; > > + pcs-mdio = <&pcs_mdio9>; > > }; > > > > dpmac10: dpmac@a { > > compatible = "fsl,qoriq-mc-dpmac"; > > reg = <0xa>; > > + pcs-mdio = <&pcs_mdio10>; > > }; > > > > dpmac11: dpmac@b { > > compatible = "fsl,qoriq-mc-dpmac"; > > reg = <0xb>; > > + pcs-mdio = <&pcs_mdio11>; > > }; > > > > dpmac12: dpmac@c { > > compatible = "fsl,qoriq-mc-dpmac"; > > reg = <0xc>; > > + pcs-mdio = <&pcs_mdio12>; > > }; > > > > dpmac13: dpmac@d { > > compatible = "fsl,qoriq-mc-dpmac"; > > reg = <0xd>; > > + pcs-mdio = <&pcs_mdio13>; > > }; > > > > dpmac14: dpmac@e { > > compatible = "fsl,qoriq-mc-dpmac"; > > reg = <0xe>; > > + pcs-mdio = <&pcs_mdio14>; > > }; > > > > dpmac15: dpmac@f { > > compatible = "fsl,qoriq-mc-dpmac"; > > reg = <0xf>; > > + pcs-mdio = <&pcs_mdio15>; > > }; > > > > dpmac16: dpmac@10 { > > compatible = "fsl,qoriq-mc-dpmac"; > > reg = <0x10>; > > + pcs-mdio = <&pcs_mdio16>; > > }; > > > > dpmac17: dpmac@11 { > > compatible = "fsl,qoriq-mc-dpmac"; > > reg = <0x11>; > > + pcs-mdio = <&pcs_mdio17>; > > }; > > > > dpmac18: dpmac@12 { > > compatible = "fsl,qoriq-mc-dpmac"; > > reg = <0x12>; > > + pcs-mdio = <&pcs_mdio18>; > > }; > > }; > > }; > > -- > > 2.20.1 > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up