From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACFACC43331 for ; Tue, 31 Mar 2020 21:55:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7C9862080C for ; Tue, 31 Mar 2020 21:55:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585691700; bh=uceMTK+WUxsLd8PDx5OIkWdTNevP2qGepAw2eoEIqgc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=1eu1tKGtQ2qFj/7MdE7BkPzH1gW1ZGDmgrxsNIF8bFS2SA50w77o1Vrmfd4EHwUBC dUtNg9pLTkP8zYHoXQhxiGqLEvjvPipa80WWwmB6Aga/5Hbl1V84Q8lqam3LTGkNnl nns2jzl1Upnu7dC5V3mwQT8y4RBVcTgOaoreIAPY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731407AbgCaVzA (ORCPT ); Tue, 31 Mar 2020 17:55:00 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:45386 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731250AbgCaVy7 (ORCPT ); Tue, 31 Mar 2020 17:54:59 -0400 Received: by mail-io1-f65.google.com with SMTP id y14so6349092iol.12; Tue, 31 Mar 2020 14:54:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=11pFjDa/Z9YxdK11hpWSqQAE1GxHCAeolDe4bFA2Hvw=; b=GaeVOxzaGhJ0zKgsuW6cxVVZTO/OGFp+T9DBmQ9pNJzuUwH+W0YbzroWFwV6AxMlcJ fA1MGpvkWe4sZ0Al6DAs9Q858VIYBJrk2r4+s9Y40xHHh7ZTWgmEEgmYOOGY9yQ71WYO o4QhyuP4YHBslYoc1Z4ORsgQ+o5ciKR+TPRiLAdPaXV+JBh/9nbPkzvyUsBomm9DSLjY fxXtkAbPHv9j3AgNnTsKKLufSRFHybphO2jSWUcNre1NIuwTl7tRSxBQ+swxefF7HVN2 kcE0y65TD7/88agGLx4ndsDKopJMM1pAFf1w/FocjkFusCUWnConwBf+j3KOelNbiAG5 7NXg== X-Gm-Message-State: ANhLgQ1e2nBd70IQLiiUJWS0C4LdjoC4WlaDTtM5Mfzi82aTQoYcHuGd SQSigVd48xrxtnjKiGnwxg== X-Google-Smtp-Source: ADFU+vupLX8M6U2FZmDT40jwK+DGW65CRtTxIt40vQQvbEj5lptgfL6vlhVc89Nm4mf08y9N6gacyg== X-Received: by 2002:a6b:580d:: with SMTP id m13mr17554237iob.59.1585691698738; Tue, 31 Mar 2020 14:54:58 -0700 (PDT) Received: from rob-hp-laptop ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id l14sm36289ioj.22.2020.03.31.14.54.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2020 14:54:58 -0700 (PDT) Received: (nullmailer pid 7976 invoked by uid 1000); Tue, 31 Mar 2020 21:54:56 -0000 Date: Tue, 31 Mar 2020 15:54:56 -0600 From: Rob Herring To: Abel Vesa Cc: Shawn Guo , Sascha Hauer , Fabio Estevam , Mike Turquette , Stephen Boyd , Lee Jones , Anson Huang , Leonard Crestez , Peng Fan , Jacky Bai , Philipp Zabel , NXP Linux Team , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linux Kernel Mailing List , linux-clk@vger.kernel.org Subject: Re: [PATCH v2 02/13] Documentation: mfd: Add DT bindings for i.MX Audiomix Message-ID: <20200331215456.GA656@bogus> References: <1585150731-3354-1-git-send-email-abel.vesa@nxp.com> <1585150731-3354-3-git-send-email-abel.vesa@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1585150731-3354-3-git-send-email-abel.vesa@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Mar 25, 2020 at 05:38:40PM +0200, Abel Vesa wrote: > The i.MX Audiomix is a mix of clock gates, reset bits > and some other i.MX audio specific functionalities. > Add information for the MFD, its clock and reset controllers. > > Signed-off-by: Abel Vesa > --- > .../devicetree/bindings/mfd/fsl,imx-audiomix.txt | 34 ++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/fsl,imx-audiomix.txt Please use DT schema format. > diff --git a/Documentation/devicetree/bindings/mfd/fsl,imx-audiomix.txt b/Documentation/devicetree/bindings/mfd/fsl,imx-audiomix.txt > new file mode 100644 > index 00000000..1622818 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/fsl,imx-audiomix.txt > @@ -0,0 +1,34 @@ > +Freescale i.MX Audiomix > +====================================== > + > +Audiomix is a conglomerate of different functionalities. > + > +Required properties: > +- compatible: Should be "fsl,-mix" for the MFD device > + Should be"fsl,-audiomix-clk" for the clock controller > + Should be"fsl,-audiomix-reset" for the reset controller > + Some functionalities of the audiomix will be registered as syscon. > +- reg: should be register base and length as documented in the > + datasheet > + > +example: > + audiomix: audiomix@30e20000 { > + compatible = "fsl,imx8mp-mix"; > + reg = <0x30e20000 0x10000>; > + > + audiomix_clk: clock-controller { > + compatible = "fsl,imx8mp-audiomix-clk"; > + #clock-cells = <1>; > + clocks = <&clk IMX8MP_CLK_AUDIO_ROOT>, > + <&clk IMX8MP_CLK_AUDIO_AHB>, > + <&clk IMX8MP_CLK_AUDIO_AXI_DIV>; None of these clocks are needed for the other functions in this MFD. I'm not all that convinced that these child nodes are needed. A single node can be a clock and reset provider. If you have other things to add to the binding, do so now even if you don't have driver support. > + clock-names = "audio_root", > + "audio_ahb", > + "audio_axi_div"; > + }; > + > + audiomix_reset: reset-controller { > + compatible = "fsl,imx8mp-audiomix-reset"; > + #reset-cells = <1>; > + }; > + }; > -- > 2.7.4 >