[PATCH] dt-bindings: net: mvusb: Fix example errors

[PATCH] dt-bindings: net: mvusb: Fix example errors

[Rob Herring]

The example for Marvell USB to MDIO Controller doesn't build:

Error: Documentation/devicetree/bindings/net/marvell,mvusb.example.dts:18.9-14 syntax error
FATAL ERROR: Unable to parse input tree

This is due to label refs being used which can't be resolved.

Fixes: 61e0150cb44b ("dt-bindings: net: add marvell usb to mdio bindings")
Cc: Tobias Waldekranz <tobias@waldekranz.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
David, Please take this and send to Linus before rc1 as 'make 
dt_binding_check' was broken by the above commit. That would have been 
caught had the DT list been CC'ed or if this had been in linux-next long 
enough to test and fix (it landed in next on Monday :().

Rob

 .../bindings/net/marvell,mvusb.yaml           | 29 +++++++++----------
 1 file changed, 14 insertions(+), 15 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/marvell,mvusb.yaml b/Documentation/devicetree/bindings/net/marvell,mvusb.yaml
index 9458f6659be1..68573762294b 100644
--- a/Documentation/devicetree/bindings/net/marvell,mvusb.yaml
+++ b/Documentation/devicetree/bindings/net/marvell,mvusb.yaml
@@ -38,28 +38,27 @@ required:
 examples:
   - |
     /* USB host controller */
-    &usb1 {
-            mvusb: mdio@1 {
+    usb {
+            #address-cells = <1>;
+            #size-cells = <0>;
+
+            mdio@1 {
                     compatible = "usb1286,1fa4";
                     reg = <1>;
                     #address-cells = <1>;
                     #size-cells = <0>;
-            };
-    };
 
-    /* MV88E6390X devboard */
-    &mvusb {
-            switch@0 {
-                    compatible = "marvell,mv88e6190";
-                    status = "ok";
-                    reg = <0x0>;
+                    switch@0 {
+                            compatible = "marvell,mv88e6190";
+                            reg = <0x0>;
 
-                    ports {
-                            /* Port definitions */
-                    };
+                            ports {
+                                    /* Port definitions */
+                            };
 
-                    mdio {
-                            /* PHY definitions */
+                            mdio {
+                                    /* PHY definitions */
+                            };
                     };
             };
     };
-- 
2.20.1

Re: [PATCH] dt-bindings: net: mvusb: Fix example errors

[David Miller]

From: Rob Herring <robh@kernel.org>
Date: Wed,  1 Apr 2020 11:58:04 -0600

> David, Please take this and send to Linus before rc1 as 'make 
> dt_binding_check' was broken by the above commit. That would have been 
> caught had the DT list been CC'ed or if this had been in linux-next long 
> enough to test and fix (it landed in next on Monday :().

Will do.

Re: [PATCH] dt-bindings: net: mvusb: Fix example errors

[Tobias Waldekranz]

On Wed Apr 1, 2020 at 1:58 PM PST, Rob Herring wrote:
> The example for Marvell USB to MDIO Controller doesn't build:

Thank you for fixing this. I did run 'make dt_binding_check' before
submitting, but my branch did not have the latest kbuild additions
which passed the examples through dtc.

I'll make sure to address the remaining comments once net-next is open
again.

Thanks,
Tobias