From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A2B8C43331 for ; Thu, 2 Apr 2020 23:18:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1920C20787 for ; Thu, 2 Apr 2020 23:18:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OVTTLbqf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389108AbgDBXSp (ORCPT ); Thu, 2 Apr 2020 19:18:45 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:41388 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732600AbgDBXSp (ORCPT ); Thu, 2 Apr 2020 19:18:45 -0400 Received: by mail-pg1-f194.google.com with SMTP id b1so2571808pgm.8 for ; Thu, 02 Apr 2020 16:18:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=hRNopbGVH3Ptzrk/4MigR6ROi/adYHKfTDbekJj0Qcw=; b=OVTTLbqfhamXMqXPgwu6x5Mo38O93HBEbTvyjst4xdirc50oDR9GO3KFQQV+0NQVvN +nghNBkNzsB3y4VN5jq2ZOluhiZCr7VZUabHsiEeBGUofT7BrZPUsXupRGWCsa2D6P+d 6xsC5oXEnkeA7ZUhceQ914ZtS3D4p9TatXJnbWhd+7A7VNOCMvfkH0qv0Tq5aoBXLk1h 4a+lfPYyBy9IiXf9KiE6MQkpIFUrl1Sg3hkFxrnJOuyRh7/TUzJezaYAIMgG+MX6uk1I z39i6CS69q7Kpj9bGwYw2vCnnw4ZHKx1Tz21/NC+K6wmYN9Vnn8LQ7ayBTqAZm1rf+u/ glkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hRNopbGVH3Ptzrk/4MigR6ROi/adYHKfTDbekJj0Qcw=; b=sRVXS8K0xUDQX0AmdIGIrh99V8DG69NsxaK/lEfbt0Ziukev+9vp8ke8fQlzKMAEaD mJ9Rn33Bg6tRU8qRpU/vpwReiXX936+nCCLthx2nnXaknFNlzk6q0NfbY25hUSU/HLAH LwVQvH7YeL9pTjN84osspNNI4egbAKMDtzH0Tl8IMKLFQ5KlXTOvJ0hUmXX9tudg+Jtt af8OfJ7jDossu1oWfyJrgVW0CU94DC1aB8xOLTBsunnO3XEEc6qZb2I7tGI+VKLv3O/H fO9v8T6vFcJ/pZrSNGOHS/BsDebi3h0DgY1W0ylVlbfUVn77o9R3OzadIZTHjRJswZlT 2boQ== X-Gm-Message-State: AGi0PuZOYr+tTVy7q7AqXeXMMBfP/kOikJt5JBla40IoER5b+NGE0zA4 6YIUNmWHnvbRWBCUvm4hnit1Iw== X-Google-Smtp-Source: APiQypI7H+r1Eg5xc73T+t+fbfyInBtijzZTZim9htzlxz42ZqZLdPFt4zBC8Pp5SoJ45JlVVHugEg== X-Received: by 2002:a63:e56:: with SMTP id 22mr5520736pgo.173.1585869523780; Thu, 02 Apr 2020 16:18:43 -0700 (PDT) Received: from minitux (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id m9sm4436895pff.93.2020.04.02.16.18.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2020 16:18:43 -0700 (PDT) Date: Thu, 2 Apr 2020 16:18:40 -0700 From: Bjorn Andersson To: Doug Anderson Cc: John Stultz , lkml , Andy Gross , Rob Herring , Mark Rutland , Manu Gautam , Sandeep Maheswaram , Matthias Kaehlcke , Stephen Boyd , Kishon Vijay Abraham I , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Subject: Re: [PATCH] phy: qcom-qusb2: Re add "qcom,sdm845-qusb2-phy" compat string Message-ID: <20200402231840.GA327102@minitux> References: <20200402223723.7150-1-john.stultz@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu 02 Apr 15:56 PDT 2020, Doug Anderson wrote: > Hi, > > On Thu, Apr 2, 2020 at 3:37 PM John Stultz wrote: > > > > In commit 8fe75cd4cddf ("phy: qcom-qusb2: Add generic QUSB2 V2 > > PHY support"), the change was made to add "qcom,qusb2-v2-phy" > > as a generic compat string. However the change also removed > > the "qcom,sdm845-qusb2-phy" compat string, which is documented > > in the binding and already in use. > > > > This patch re-adds the "qcom,sdm845-qusb2-phy" compat string > > which allows the driver to continue to work with existing dts > > entries such as found on the db845c. > > > > Cc: Andy Gross > > Cc: Bjorn Andersson > > Cc: Rob Herring > > Cc: Mark Rutland > > Cc: Doug Anderson > > Cc: Manu Gautam > > Cc: Sandeep Maheswaram > > Cc: Matthias Kaehlcke > > Cc: Stephen Boyd > > Cc: Kishon Vijay Abraham I > > Cc: linux-arm-msm@vger.kernel.org > > Cc: devicetree@vger.kernel.org > > Fixes: 8fe75cd4cddf ("phy: qcom-qusb2: Add generic QUSB2 V2 PHY support") > > Reported-by: YongQin Liu > > Signed-off-by: John Stultz > > --- > > drivers/phy/qualcomm/phy-qcom-qusb2.c | 3 +++ > > 1 file changed, 3 insertions(+) > > Do you have an out-of-tree dts file? If not, I'd prefer that the fix > was for this patch to land instead: > > https://lore.kernel.org/r/1583747589-17267-9-git-send-email-sanm@codeaurora.org > > While we can land your patch if someone needs it for supporting an > out-of-tree dts, it gives people supporting future SoCs the idea that > they need to add themselves to this table too. That's now discouraged > unless there's a specific quirk that needs to be handled just for this > SoC. > Afaict the compatible has been in use in the upstream sdm845.dtsi since v4.20 and we do have an outspoken rule that we don't break backwards compatibility with existing DTBs. There are cases where it makes sense to break this rule, e.g. to fix something that's clearly broken, but I don't see that this is such a case. Regards, Bjorn