From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 554BEC4332B for ; Sat, 4 Apr 2020 16:01:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1FDAA206F8 for ; Sat, 4 Apr 2020 16:01:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586016087; bh=prtMsfibgClHmFGAkRVGCyBjS6k4/Rt446TvN90lSCc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=QoCsxSPa+k6dRkGEGLLdOvNnrisR1LQrv4E4W1vyuwNZujj4RuNWJZo/brBtbKiu1 bJzXpMacoARTkcJPWRl1kv62VIt936r+A4gwdHzfswDuBt0mpSraZP9yeAWuEd2rJI hm3807XUV/1bZCf4JSTrCrwl/9JFgnU9t+dgpAR4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726269AbgDDQB0 (ORCPT ); Sat, 4 Apr 2020 12:01:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:44762 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726229AbgDDQB0 (ORCPT ); Sat, 4 Apr 2020 12:01:26 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CA61B206D4; Sat, 4 Apr 2020 16:01:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586016085; bh=prtMsfibgClHmFGAkRVGCyBjS6k4/Rt446TvN90lSCc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VIrBT4eZ0UQhdJueNtPyYk/JTg3O55jSj8tXE1/W7MKZTNGK2gHrRi459tY/e3YG+ bDH3/qnxgavUdBLX77n+z6E/aiKUuObSIai/uJIDtuBw+ZjgKniQAKD4zctTsbg+X6 PUL/8EZGZZExHFz2OtGEmH5V194SCtnI2u2CvxQY= Date: Sat, 4 Apr 2020 17:01:20 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: "Sa, Nuno" , linux-iio , devicetree , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , Mark Rutland , "Ardelean, Alexandru" , "Hennerich, Michael" Subject: Re: [PATCH v3 5/6] iio: imu: Add support for adis16475 Message-ID: <20200404170120.43ff17e9@archlinux> In-Reply-To: References: <20200331114811.7978-1-nuno.sa@analog.com> <20200331114811.7978-6-nuno.sa@analog.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org ... > > > > > +#define ADIS16475_GYRO_CHANNEL(_mod) \ > > > > + ADIS16475_MOD_CHAN(IIO_ANGL_VEL, IIO_MOD_ ## _mod, \ > > > > + ADIS16475_REG_ ## _mod ## _GYRO_L, ADIS16475_SCAN_GYRO_ ## > > > _mod, 32, \ > > > > + 32) > > > > > > It's not obvious that this is macro inside macro. Can you indent better? > > > Ditto for the rest similar ones. > > > > > > > Honestly here I don't see any problems with indentation and it goes in conformity with > > other IMU drivers already in tree. So here, as long as anyone else has a problem with this, I prefer > > to keep it this way... > > I'm not a maintainer, not my call :-) I'm lazy when it comes to things like this. Yes it could be better, but it's still fairly readable so I don't really mind. That's not to say I don't like beautiful things if you don't mind tidying it up? :) Jonathan