Re: [PATCH v5 1/5] media: dt-bindings: media: i2c: Deprecate usage of the clock-frequency property

Laurent Pinchart
2020-04-06T17:30:17Z

Hi Prabhakar,

Thank you for the patch.

On Mon, Apr 06, 2020 at 05:42:37PM +0100, Lad Prabhakar wrote:
> OV5645 sensor supports input clock frequency ranging from 6MHz to 27MHz
> but the driver strictly expects this to be 24MHz (with tolerance of 1%)
> with this restrictions let the driver enforce the clock frequency

Maybe s/with/With/ ?

> internally to 24MHz rather then being passed as dt-property.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> Documentation/devicetree/bindings/media/i2c/ov5645.txt | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/ov5645.txt b/Documentation/devicetree/bindings/media/i2c/ov5645.txt
> index 72ad992f77be..a55bb728ea48 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ov5645.txt
> +++ b/Documentation/devicetree/bindings/media/i2c/ov5645.txt
> @@ -8,7 +8,6 @@ Required Properties:
> - compatible: Value should be "ovti,ov5645".
> - clocks: Reference to the xclk clock.
> - clock-names: Should be "xclk".
> -- clock-frequency: Frequency of the xclk clock.
> - enable-gpios: Chip enable GPIO. Polarity is GPIO_ACTIVE_HIGH. This corresponds
> to the hardware pin PWDNB which is physically active low.
> - reset-gpios: Chip reset GPIO. Polarity is GPIO_ACTIVE_LOW. This corresponds to
> @@ -37,7 +36,6 @@ Example:
>
> clocks = <&clks 200>;
> clock-names = "xclk";
> - clock-frequency = <24000000>;
>
> vdddo-supply = <&camera_dovdd_1v8>;
> vdda-supply = <&camera_avdd_2v8>;

--
Regards,

Laurent Pinchart