* [PATCH] dt-bindings: BD718x7 - add missing I2C bus properties
@ 2020-04-06 7:30 Matti Vaittinen
2020-04-09 16:36 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Matti Vaittinen @ 2020-04-06 7:30 UTC (permalink / raw)
To: matti.vaittinen, mazziesaccount
Cc: Lee Jones, Rob Herring, Mark Rutland, devicetree, linux-kernel
The DT example needs #address-cells and #size-cells for I2C bus or
validity checker will generate warnings. Add these properties in
BD71837 and BD71847 binding examples.
Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
---
This patch was created against Lee's for-mfd-next branch. Please let
me know if this was not feasible.
Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.yaml | 4 +++-
Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.yaml
index aa922c560fcc..65018a019e1d 100644
--- a/Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.yaml
@@ -123,7 +123,9 @@ examples:
#include <dt-bindings/leds/common.h>
i2c {
- pmic: pmic@4b {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ pmic: pmic@4b {
compatible = "rohm,bd71837";
reg = <0x4b>;
interrupt-parent = <&gpio1>;
diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml
index 402e40dfe0b8..77bcca2d414f 100644
--- a/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml
@@ -128,7 +128,9 @@ examples:
#include <dt-bindings/leds/common.h>
i2c {
- pmic: pmic@4b {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ pmic: pmic@4b {
compatible = "rohm,bd71847";
reg = <0x4b>;
interrupt-parent = <&gpio1>;
base-commit: d2923aa4535664ae5c46c3a093985afd18fec118
--
2.21.0
--
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND
~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dt-bindings: BD718x7 - add missing I2C bus properties
2020-04-06 7:30 [PATCH] dt-bindings: BD718x7 - add missing I2C bus properties Matti Vaittinen
@ 2020-04-09 16:36 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2020-04-09 16:36 UTC (permalink / raw)
To: Matti Vaittinen
Cc: matti.vaittinen, mazziesaccount, Lee Jones, Mark Rutland,
devicetree, linux-kernel
On Mon, 6 Apr 2020 10:30:08 +0300, Matti Vaittinen wrote:
> The DT example needs #address-cells and #size-cells for I2C bus or
> validity checker will generate warnings. Add these properties in
> BD71837 and BD71847 binding examples.
>
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> ---
>
> This patch was created against Lee's for-mfd-next branch. Please let
> me know if this was not feasible.
>
> Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.yaml | 4 +++-
> Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml | 4 +++-
> 2 files changed, 6 insertions(+), 2 deletions(-)
>
Applied, thanks.
Rob
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-09 16:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-06 7:30 [PATCH] dt-bindings: BD718x7 - add missing I2C bus properties Matti Vaittinen
2020-04-09 16:36 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).