From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB38EC2BB86 for ; Sun, 12 Apr 2020 11:49:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BA9CC20732 for ; Sun, 12 Apr 2020 11:49:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586692194; bh=PrpTl0s79HlJ3c4Pqa4ubrsrZU1YRed/3oKXDqo07DU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=PbhTsZKWYdhncs3mNhJCfHP6Zf5+LmckSZnqOPAxPavJlf+01AZsP1FP0rUFT3bpl 7sMCTN5nDs/G1ofOWeMDq5OEz3Y3UGU9OvAk74Yy5YYyRjgsk0sOhp6Pp1g/HjC2GM 2zWaIutkUF5Srb17g2a8XfRx/E+2BR+w63QPKj+8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726139AbgDLLtx (ORCPT ); Sun, 12 Apr 2020 07:49:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:60582 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725903AbgDLLtx (ORCPT ); Sun, 12 Apr 2020 07:49:53 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9968A20708; Sun, 12 Apr 2020 11:49:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586692193; bh=PrpTl0s79HlJ3c4Pqa4ubrsrZU1YRed/3oKXDqo07DU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=yMMgxMaUlil1pVEvtn1FfEFQLKy0bMHeJON6YJY6cEGG9/f7gU9zlapxMXSIl9dmD ZX41Hxjg6dxib4IJzWIoNlLxG3rSbtQ+CPO3tFe/K1pTiyuHiH9tXItq861+M15Dsg Xyfvk6qUuvYVjHVLJPODatPrfapHHVqqgF9FNur4= Date: Sun, 12 Apr 2020 12:49:48 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: "Sa, Nuno" , linux-iio , devicetree , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , Mark Rutland , "Ardelean, Alexandru" , "Hennerich, Michael" Subject: Re: [PATCH v4 5/6] iio: imu: Add support for adis16475 Message-ID: <20200412124948.7aacb900@archlinux> In-Reply-To: References: <20200406150846.878-1-nuno.sa@analog.com> <20200406150846.878-6-nuno.sa@analog.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org > > > > > > > + for_each_set_bit(bit, indio_dev->active_scan_mask, > > > > > > + indio_dev->masklength) { > > > > > > > > > > One line? > > > > > > > > > > > > > It goes beyond 80 col limit... I know I could initialize these to some local > > > const but... > > > > > > That's why question mark is there. > > > Nonetheless, if it ~2-3 characters more, I would leave it on one line anyway. > > > > > > JFYI: readability has a priority over 80 limit. > > > > > > > Thanks! I would say it also depends on the maintainer (not sure)? Some are more > > strict about checkpatch... > > Btw, the line will have 84 if one liner... > > Let's leave it to maintainer then. > I care very little either way :) In this case I'd argue that not being annoyed by checkpatch is worth the ever so slightly uglier 2 line option but find it hard to get worked up about it.