From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0AA7C2BA19 for ; Tue, 14 Apr 2020 08:08:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F78E2072D for ; Tue, 14 Apr 2020 08:08:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Qi+aAYqV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406975AbgDNII0 (ORCPT ); Tue, 14 Apr 2020 04:08:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2406959AbgDNIIH (ORCPT ); Tue, 14 Apr 2020 04:08:07 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65D43C008748 for ; Tue, 14 Apr 2020 01:08:07 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id b11so1824008wrs.6 for ; Tue, 14 Apr 2020 01:08:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Of87X/gGHd7WK7J8InDBiy0jDOtLSnaghXrcb3fjgfk=; b=Qi+aAYqVu1eN15qmGiNzA8fNa4lIaXjb7w8Ocp8Gc0hvk+JIaKlkVXzyxUG8n0kj+r UO5wQRuYWMusYRen73PY8mnpxj7c2gEagVixnKH7uYpOo25BzIAhsiy4AwByxwVKgDTX 3usXFCaxp+gOky+4ixr3sYj7SJeR2HTcyBG8WdE5NSYpwB+WADiE6Jvju2AScK2TrryU m0Nbcv9ajXflZubAOOw8jM1w57tWTxiDu8rNj7uzuriDtcDYZAa3eT9hU0TcjfE4Hm8v K5mfMgvUSBew+h/w06khwgn9kCDZAA34fzfhg7vHcnzLGX4BOXe2yx/so+jE4QPF1o8e YT5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Of87X/gGHd7WK7J8InDBiy0jDOtLSnaghXrcb3fjgfk=; b=JegG+mhXYj56/B47Z+U9/vBlauEpjkCQN2P4erBseYYU0QczkhjZm6a/REIqSRICbJ 522XWNUSF6/OT7J/3Py2S4ekGOtEjLJ6/Polx+2dYyp+kZ7DCvPdfGSoNgvByKwUajFb BagNRL//xUgappL/JZOD9kuOVlVcqt+jZzPejLeIrjq2YR9kucii1HZpe3lxmNp9oX5m Fn3T+Hagm7RwxKppAHf1AaUTpqCxAO3BNXqKt3ZVYz+y3mnvvIP7XQw1tNpvBPi5qETF AJH3bt0oJH/KdVKuJLuNgSGdwNa2Rw/Ba2z3GLJgVa6GOeFQMG9AIlLXfJM11ajEjT7a eBjA== X-Gm-Message-State: AGi0Puarm81JW8d7fW/kJrvcGZw2LICbZX6kkbZmOryUhT+ZQGrDob5W ABrT5ihevGvPMdoEyqQiGcvtVQ== X-Google-Smtp-Source: APiQypLIN3SbXV7PM0uFFyvMDh857863ygqy9yht/XtufvHAtOL8FPNIeAgdp7UPDBUQOVQgcQy0GQ== X-Received: by 2002:a5d:4286:: with SMTP id k6mr10371255wrq.222.1586851685895; Tue, 14 Apr 2020 01:08:05 -0700 (PDT) Received: from dell ([95.149.164.124]) by smtp.gmail.com with ESMTPSA id f63sm17383374wma.47.2020.04.14.01.08.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2020 01:08:05 -0700 (PDT) Date: Tue, 14 Apr 2020 09:09:05 +0100 From: Lee Jones To: Tim Harvey Cc: Linux HWMON List , Robert Jones , Rob Herring , Frank Rowand , Device Tree Mailing List , open list , Jean Delvare , Guenter Roeck Subject: Re: [PATCH v8 2/3] mfd: add Gateworks System Controller core driver Message-ID: <20200414080905.GC2167633@dell> References: <1585341214-25285-1-git-send-email-tharvey@gateworks.com> <1585341214-25285-3-git-send-email-tharvey@gateworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 08 Apr 2020, Tim Harvey wrote: > On Fri, Mar 27, 2020 at 1:33 PM Tim Harvey wrote: > > > > The Gateworks System Controller (GSC) is an I2C slave controller > > implemented with an MSP430 micro-controller whose firmware embeds the > > following features: > > - I/O expander (16 GPIO's) using PCA955x protocol > > - Real Time Clock using DS1672 protocol > > - User EEPROM using AT24 protocol > > - HWMON using custom protocol > > - Interrupt controller with tamper detect, user pushbotton > > - Watchdog controller capable of full board power-cycle > > - Power Control capable of full board power-cycle > > > > see http://trac.gateworks.com/wiki/gsc for more details > > > > Cc: Randy Dunlap > > Signed-off-by: Tim Harvey > > --- > > MAINTAINERS | 8 ++ > > drivers/mfd/Kconfig | 10 ++ > > drivers/mfd/Makefile | 1 + > > drivers/mfd/gateworks-gsc.c | 288 ++++++++++++++++++++++++++++++++++++++++++++ > > include/linux/mfd/gsc.h | 73 +++++++++++ > > 5 files changed, 380 insertions(+) > > create mode 100644 drivers/mfd/gateworks-gsc.c > > create mode 100644 include/linux/mfd/gsc.h [...] Please clip your responses. > Lee, > > Do you have time to look at this? Rob has reviewed the dt-bindings and > Guenter has reviewed the hwmon driver so this is the only patch > remaining in the series that needs review/sign-off. It's on the list. Please bear in mind that the merge-window has been open for the past 2 weeks. Usually reviewing cadence slows down during this period. It should be ramping up again this week. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog