From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Jon Hunter <jonathanh@nvidia.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Joseph Lo <josephl@nvidia.com>,
linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 09/14] memory: tegra: Add EMC scaling support code for Tegra210
Date: Tue, 14 Apr 2020 17:08:15 +0200 [thread overview]
Message-ID: <20200414150815.GM3593749@ulmo> (raw)
In-Reply-To: <e015e35b-3f82-56e1-2d86-ebc467eb92f7@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]
On Fri, Apr 10, 2020 at 05:25:06PM +0300, Dmitry Osipenko wrote:
> 09.04.2020 20:52, Thierry Reding пишет:
> ...
> > +static int tegra210_emc_remove(struct platform_device *pdev)
> > +{
> > + struct tegra210_emc *emc = platform_get_drvdata(pdev);
> > +
> > + debugfs_remove_recursive(emc->debugfs.root);
> > + tegra210_clk_emc_detach(emc->clk);
>
> It's great that you want to make this driver modular, but I don't think
> that it's a good idea to suddenly rip off the EMC clock from the users.
>
> It should be better to simply disallow unloading of this driver once
> it's loaded.
That's not what we're doing. The clock is going to stay around and users
will be able to access it. The only thing that the above does is take
away the possibility to change the rate of the EMC clock.
So I think this actually makes this really nice both for testing that
unload/reload works and it also gives users an easy way to disable EMC
frequency scaling by simply blacklisting the module.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-04-14 15:11 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 17:52 [PATCH v6 00/14] Add EMC scaling support for Tegra210 Thierry Reding
2020-04-09 17:52 ` [PATCH v6 01/14] dt-bindings: reserved-memory: Introduce memory-region-names Thierry Reding
2020-04-15 16:23 ` Rob Herring
2020-04-09 17:52 ` [PATCH v6 02/14] of: reserved-memory: Support lookup of regions by name Thierry Reding
2020-04-15 16:24 ` Rob Herring
2020-04-15 23:35 ` Thierry Reding
2020-04-16 0:58 ` Rob Herring
2020-04-09 17:52 ` [PATCH v6 03/14] of: reserved-memory: Support multiple regions per device Thierry Reding
2020-04-15 16:25 ` Rob Herring
2020-04-09 17:52 ` [PATCH v6 04/14] clk: tegra: Rename Tegra124 EMC clock source file Thierry Reding
2020-04-14 16:48 ` Dmitry Osipenko
2020-04-14 17:14 ` Thierry Reding
2020-04-09 17:52 ` [PATCH v6 05/14] clk: tegra: Add PLLP_UD and PLLMB_UD for Tegra210 Thierry Reding
2020-04-09 17:52 ` [PATCH v6 06/14] clk: tegra: Export functions for EMC clock scaling Thierry Reding
2020-04-09 17:52 ` [PATCH v6 07/14] clk: tegra: Implement Tegra210 EMC clock Thierry Reding
2020-04-09 18:24 ` Dmitry Osipenko
2020-04-14 14:34 ` Thierry Reding
2020-04-14 15:18 ` Dmitry Osipenko
2020-04-14 17:10 ` Thierry Reding
2020-04-14 20:22 ` Dmitry Osipenko
2020-04-10 20:49 ` Dmitry Osipenko
2020-04-14 14:36 ` Thierry Reding
2020-04-09 17:52 ` [PATCH v6 08/14] dt-bindings: memory: tegra: Add external memory controller binding for Tegra210 Thierry Reding
2020-04-15 16:27 ` Rob Herring
2020-04-09 17:52 ` [PATCH v6 09/14] memory: tegra: Add EMC scaling support code " Thierry Reding
2020-04-09 19:00 ` Dmitry Osipenko
2020-04-14 14:45 ` Thierry Reding
2020-04-09 19:16 ` Dmitry Osipenko
2020-04-14 14:54 ` Thierry Reding
2020-04-14 20:50 ` Dmitry Osipenko
2020-04-09 23:56 ` Dmitry Osipenko
2020-04-11 20:39 ` Dmitry Osipenko
2020-04-14 15:05 ` Thierry Reding
2020-04-14 15:32 ` Dmitry Osipenko
2020-04-14 15:02 ` Thierry Reding
2020-04-10 14:25 ` Dmitry Osipenko
2020-04-14 15:08 ` Thierry Reding [this message]
2020-04-10 14:26 ` Dmitry Osipenko
2020-04-14 15:39 ` Thierry Reding
2020-04-10 20:46 ` Dmitry Osipenko
2020-04-14 15:41 ` Thierry Reding
2020-04-14 20:39 ` Dmitry Osipenko
2020-04-14 20:46 ` Dmitry Osipenko
2020-04-14 20:56 ` Dmitry Osipenko
2020-04-09 17:52 ` [PATCH v6 10/14] memory: tegra: Add EMC scaling sequence " Thierry Reding
2020-04-10 14:18 ` Dmitry Osipenko
2020-04-14 15:45 ` Thierry Reding
2020-04-14 16:27 ` Dmitry Osipenko
2020-04-14 20:03 ` Thierry Reding
2020-04-09 17:52 ` [PATCH v6 11/14] memory: tegra: Support derated timings on Tegra210 Thierry Reding
2020-04-09 23:44 ` Dmitry Osipenko
2020-04-14 15:47 ` Thierry Reding
2020-04-14 16:25 ` Dmitry Osipenko
2020-04-10 14:28 ` Dmitry Osipenko
2020-04-14 16:29 ` Thierry Reding
2020-04-14 16:40 ` Dmitry Osipenko
2020-04-14 16:48 ` Thierry Reding
2020-04-09 17:52 ` [PATCH v6 12/14] arm64: tegra: Add external memory controller node for Tegra210 Thierry Reding
2020-04-09 17:52 ` [PATCH v6 13/14] arm64: tegra: Hook up EMC cooling device Thierry Reding
2020-04-09 17:52 ` [PATCH v6 14/14] clk: tegra: Remove the old emc_mux clock for Tegra210 Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414150815.GM3593749@ulmo \
--to=thierry.reding@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=josephl@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).