devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Boris Brezillon <bbrezillon@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	linux-media@vger.kernel.org,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH v1 3/4] dt-bindings: media: add wiring property to video-interfaces
Date: Tue, 14 Apr 2020 14:40:54 -0500	[thread overview]
Message-ID: <20200414194054.GB29184@bogus> (raw)
In-Reply-To: <20200412182012.27515-4-sam@ravnborg.org>

On Sun, Apr 12, 2020 at 08:20:11PM +0200, Sam Ravnborg wrote:
> The wiring property is used to describe the wiring between
> the connector and the panel. The property can be used when the
> wiring is used to change the mode from for example
> BGR to RGB. The first users are the at91sam9 family where
> such a wiring trick is sometimes used.
> The possilbe values are so far limited to what is required
> by the at91sam9 family, but using "text" allows us to extend
> this in the future.
> 
> There exists similar properties today:
>  - display/tilcdc/tilcdc.txt: blue-and-red-wiring
>  - display/atmel,lcdc.txt: atmel,lcd-wiring-mode
> 
> Neither of the above are defined as endpoint properties.
> 
> The new property "wiring" has a more general name and
> is defined as an endpoint property.
> It will replace atmel,lcd-wiring-mode and may replace
> blue-and-red-wiring.
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Hans Verkuil <hverkuil@xs4all.nl>
> Cc: linux-media@vger.kernel.org
> ---
>  Documentation/devicetree/bindings/media/video-interfaces.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt
> index f884ada0bffc..c3bb87c5c9a9 100644
> --- a/Documentation/devicetree/bindings/media/video-interfaces.txt
> +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt
> @@ -141,6 +141,9 @@ Optional endpoint properties
>  - link-frequencies: Allowed data bus frequencies. For MIPI CSI-2, for
>    instance, this is the actual frequency of the bus, not bits per clock per
>    lane value. An array of 64-bit unsigned integers.
> +- wiring: Wiring of data lines to display.
> +  "straight" - normal wiring.

Don't really need a property to express this...

> +  "red-blue-reversed" - red and blue lines reversed.

For a common property, I think this needs to be looked at in terms of 
formats and some of the format negotiation work Boris was doing.

Rob

  reply	other threads:[~2020-04-14 19:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-12 18:20 [PATCH v1 0/4] dt-bindings: DT Schema variants of atmel lcdc, hlcdc Sam Ravnborg
2020-04-12 18:20 ` [PATCH v1 1/4] dt-bindings: display: convert atmel-hlcdc to DT Schema Sam Ravnborg
2020-04-14  8:28   ` Maxime Ripard
2020-04-15 16:39     ` Sam Ravnborg
2020-04-16  7:28       ` Maxime Ripard
2020-04-12 18:20 ` [PATCH v1 2/4] dt-bindings: display: convert atmel lcdc " Sam Ravnborg
2020-04-14  8:30   ` Maxime Ripard
2020-04-15 16:44     ` Sam Ravnborg
2020-04-16  7:31       ` Maxime Ripard
2020-04-12 18:20 ` [PATCH v1 3/4] dt-bindings: media: add wiring property to video-interfaces Sam Ravnborg
2020-04-14 19:40   ` Rob Herring [this message]
2020-04-15 16:45     ` Sam Ravnborg
2020-04-12 18:20 ` [PATCH v1 4/4] dt-bindings: display: add port support to atmel lcdc Sam Ravnborg
2020-04-14 19:10   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200414194054.GB29184@bogus \
    --to=robh@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=bbrezillon@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).