From: Oleksij Rempel <o.rempel@pengutronix.de>
To: peng.fan@nxp.com
Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, robh+dt@kernel.org,
jaswinder.singh@linaro.org, linux@rempel-privat.de,
devicetree@vger.kernel.org, Anson.Huang@nxp.com,
linux-kernel@vger.kernel.org, linux-imx@nxp.com,
kernel@pengutronix.de, festevam@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] arm64: dts: imx8qxp: support scu mailbox channel
Date: Wed, 15 Apr 2020 07:50:09 +0200 [thread overview]
Message-ID: <20200415055009.uxkzy4j3l24dvvyv@pengutronix.de> (raw)
In-Reply-To: <1586870668-32630-2-git-send-email-peng.fan@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 3035 bytes --]
On Tue, Apr 14, 2020 at 09:24:28PM +0800, peng.fan@nxp.com wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> With mailbox driver support i.MX8 SCU MU channel, we could
> use it to avoid trigger interrupts for each TR/RR registers
> in one MU, instead, only one RX interrupt for a recv and
> one TX interrupt for a send.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>
> Note:
> This patch needs https://patchwork.kernel.org/patch/11446659/
> The other three patches in the patchset has been in linux-next
>
> arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 18 ++++++------------
> 1 file changed, 6 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> index e8ffb7590656..d1c3c98e4b39 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> @@ -141,17 +141,11 @@
>
> scu {
> compatible = "fsl,imx-scu";
> - mbox-names = "tx0", "tx1", "tx2", "tx3",
> - "rx0", "rx1", "rx2", "rx3",
> + mbox-names = "tx0",
> + "rx0",
> "gip3";
> mboxes = <&lsio_mu1 0 0
> - &lsio_mu1 0 1
> - &lsio_mu1 0 2
> - &lsio_mu1 0 3
> &lsio_mu1 1 0
> - &lsio_mu1 1 1
> - &lsio_mu1 1 2
> - &lsio_mu1 1 3
> &lsio_mu1 3 3>;
>
> clk: clock-controller {
> @@ -548,14 +542,14 @@
> };
>
> lsio_mu1: mailbox@5d1c0000 {
> - compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
> + compatible = "fsl,imx8-mu-scu", "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
> reg = <0x5d1c0000 0x10000>;
> interrupts = <GIC_SPI 177 IRQ_TYPE_LEVEL_HIGH>;
> #mbox-cells = <2>;
> };
>
> lsio_mu2: mailbox@5d1d0000 {
> - compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
> + compatible = "fsl,imx8-mu-scu", "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
> reg = <0x5d1d0000 0x10000>;
> interrupts = <GIC_SPI 178 IRQ_TYPE_LEVEL_HIGH>;
> #mbox-cells = <2>;
> @@ -563,7 +557,7 @@
> };
>
> lsio_mu3: mailbox@5d1e0000 {
> - compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
> + compatible = "fsl,imx8-mu-scu", "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
> reg = <0x5d1e0000 0x10000>;
> interrupts = <GIC_SPI 179 IRQ_TYPE_LEVEL_HIGH>;
> #mbox-cells = <2>;
> @@ -571,7 +565,7 @@
> };
>
> lsio_mu4: mailbox@5d1f0000 {
> - compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
> + compatible = "fsl,imx8-mu-scu", "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
> reg = <0x5d1f0000 0x10000>;
> interrupts = <GIC_SPI 180 IRQ_TYPE_LEVEL_HIGH>;
> #mbox-cells = <2>;
> --
> 2.16.4
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-04-15 5:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 13:24 [PATCH 1/2] dt-bindings: mailbox: imx-mu: correct example peng.fan
2020-04-14 13:24 ` [PATCH 2/2] arm64: dts: imx8qxp: support scu mailbox channel peng.fan
2020-04-15 5:50 ` Oleksij Rempel [this message]
2020-04-28 8:50 ` Shawn Guo
2020-04-15 5:49 ` [PATCH 1/2] dt-bindings: mailbox: imx-mu: correct example Oleksij Rempel
2020-04-20 21:07 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415055009.uxkzy4j3l24dvvyv@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=Anson.Huang@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=jaswinder.singh@linaro.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).