From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D8F0C3815B for ; Wed, 15 Apr 2020 15:12:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DCA7E20857 for ; Wed, 15 Apr 2020 15:12:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586963566; bh=tIhwo4Av+Ko1GexPfUE5H1cXeGMDMCxzkLiqEIVxS+8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=tAP2tX7mLf2hsCbp0H0DNe5AMj4v3mktWtJbqVMiCsJ4pMKZUyVArAZXCL5BQmCrt twF3hfxcb37od9B0vGCp6defoqYL7WNH71FVs4GaHXfQ9T81MsfSiwHBCSCKzhgCL+ jNmEne3rPFXEae48JDQipuNgI7K3/6Z6ymgPHklM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732251AbgDOPMl (ORCPT ); Wed, 15 Apr 2020 11:12:41 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:34670 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393194AbgDOPMl (ORCPT ); Wed, 15 Apr 2020 11:12:41 -0400 Received: by mail-ot1-f66.google.com with SMTP id m2so255639otr.1; Wed, 15 Apr 2020 08:12:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZFCMh2H9Eh+ryRXkXK/V7+2w4B+PUgVzUEm1sj08lm0=; b=Fm98cqyhkL7XLrDgNy/rlEpq9O/WJzzMDc30kjJPiRADv6woHOk6VQzx8mDS08ElmK /22vou22tx5SGdhNo359jmILyph0DaoL+fSP5wO7+Vzwpqrjqo1aEQDAxPXKpBg7KupY YtWiNumrL/doriIm1x8M1iI0/Nk7LGdOzCBNXN6vmxxlhxtO962usoGidE0D2lgo74T4 6cuTxRS/RMhr5hEfWhupz0p3IXjzuBAIhl7zQIxnHdrWEqJJGYQW2FugGDCq8BWaJy7D f2e4qiTwBrZ9UlIMCT5UacEoPe58XLLkNsinAvje0mWjdCCqKsMocgaMytqnYN4gwRB9 8VjA== X-Gm-Message-State: AGi0PuaFshGLSjumyzPbpAIBwdC7FmhsxN5RvH2MVyIODqsGKhyzxrrK esiZQHoj6FMV6W/EpbO0Dw== X-Google-Smtp-Source: APiQypIKxwXtUrjwfyuCqVzzKfMogJVdKDlcIeltnelwgqKhG6bH+DblCsEbrigze1USzStBxtor4A== X-Received: by 2002:a9d:4102:: with SMTP id o2mr22206640ote.98.1586963559689; Wed, 15 Apr 2020 08:12:39 -0700 (PDT) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id r205sm6395829oih.47.2020.04.15.08.12.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2020 08:12:35 -0700 (PDT) Received: (nullmailer pid 30324 invoked by uid 1000); Wed, 15 Apr 2020 15:12:34 -0000 Date: Wed, 15 Apr 2020 10:12:34 -0500 From: Rob Herring To: Kiran Gunda Cc: bjorn.andersson@linaro.org, jingoohan1@gmail.com, lee.jones@linaro.org, b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org, daniel.thompson@linaro.org, jacek.anaszewski@gmail.com, pavel@ucw.cz, mark.rutland@arm.com, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Dan Murphy , linux-arm-msm@vger.kernel.org, Subbaraman Narayanamurthy Subject: Re: [PATCH V5 3/4] backlight: qcom-wled: Add WLED5 bindings Message-ID: <20200415151234.GA25862@bogus> References: <1586274430-28402-1-git-send-email-kgunda@codeaurora.org> <1586274430-28402-4-git-send-email-kgunda@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1586274430-28402-4-git-send-email-kgunda@codeaurora.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Apr 07, 2020 at 09:17:09PM +0530, Kiran Gunda wrote: > Add WLED5 specific bindings. > checkpatch.pl complains about some trailing whitespace. The previous patch too. > Signed-off-by: Kiran Gunda > Signed-off-by: Subbaraman Narayanamurthy > --- > .../bindings/leds/backlight/qcom-wled.yaml | 60 ++++++++++++++++++++-- > 1 file changed, 57 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml > index 770e780..5714631 100644 > --- a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml > +++ b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml > @@ -21,6 +21,7 @@ properties: > - qcom,pm8941-wled > - qcom,pmi8998-wled > - qcom,pm660l-wled > + - qcom,pm8150l-wled > > reg: > maxItems: 1 > @@ -28,12 +29,13 @@ properties: > default-brightness: > description: > brightness value on boot. > - minimum: 0 > - maximum: 4095 > - default: 2048 > > label: true > > + max-brightness: > + description: > + Maximum brightness level. > + > qcom,cs-out: > description: > enable current sink output. > @@ -130,6 +132,31 @@ properties: > This feature is not supported for WLED3. > type: boolean > > + qcom,modulator-sel: > + description: Need a '|' at the end to preserve formatting. > + Selects the modulator used for brightness modulation. > + Allowed values are, > + 0 - Modulator A > + 1 - Modulator B > + This property is applicable only to WLED5 peripheral. > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + - enum: [ 0, 1 ] > + - default: 0 > + > + qcom,cabc-sel: > + description: Need a '|'. > + Selects the CABC pin signal used for brightness modulation. > + Allowed values are, > + 0 - CABC disabled > + 1 - CABC 1 > + 2 - CABC 2 > + 3 - External signal (e.g. LPG) is used for dimming > + This property is applicable only to WLED5 peripheral. > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + - enum: [ 0, 1, 2, 3 ] > + > allOf: > - if: > properties: > @@ -179,6 +206,33 @@ allOf: > - const: ovp > - const: short > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,pm8150l-wled > + > + then: > + properties: > + default-brightness: > + minimum: 0 > + maximum: 32767 > + > + max-brightness: > + minimum: 0 > + maximum: 32767 > + > + else: > + properties: > + default-brightness: > + minimum: 0 > + maximum: 4095 Wrong indentation. > + > + max-brightness: > + minimum: 0 > + maximum: 4095 > + > required: > - compatible > - reg > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >