From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 684B8C38A2C for ; Wed, 15 Apr 2020 16:07:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 432D32166E for ; Wed, 15 Apr 2020 16:07:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586966862; bh=/y2ckExWdTI7UWOJbRtNhepJOM6jaoJcFWCX20lgdY8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Z4aTVeEYnlUD6yJxTYVVzB0OUfSm3XBgkw6KmrOL6YlvrJoojIcy7Iu26QLFqmwWV DJB3Jj+UqHW55B7OQY2IuaZmrdDGrzgi56zjf7Faye5I9G+BK7bGZC2XejJtYrUKJM i3LGbwCSIxf0Vr4Co8bYBP8ImJuturTsrvYW1bAs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2410205AbgDOQHf (ORCPT ); Wed, 15 Apr 2020 12:07:35 -0400 Received: from mail-oi1-f195.google.com ([209.85.167.195]:33358 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729190AbgDOQHd (ORCPT ); Wed, 15 Apr 2020 12:07:33 -0400 Received: by mail-oi1-f195.google.com with SMTP id m14so13932753oic.0; Wed, 15 Apr 2020 09:07:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=uYhwLEgK1Ycm8Hcmrx9CbYR8tRwlULjhiPmaER/B1xU=; b=YMjU3GwPPTmOVexmtrHoeg0K822S+qfc9UHJgVHxeYBLReaCRcd4NvRs16A6S/5G1k 1Pmkd+jJF6yRBglgDqUFNaKAwbNZXGt7UaZDkIMwxZQLReEVHFznvC00Uuwqp5np9deZ l7gQeifdD/f9QDA/0C8mZgYwMZQsLX+D9+oX/c35KZxJKVQGTdYQvLcpgdf+EMLvQjSz cMIH2hof6QngCZtaJul+Q2LxEUPH2n9Gf4+iEpTOZDTpq1AKNcIBmFwiGjrqseoO/goH z4IDYd8J0y6ysAvdmnw1PfPShsMT7zRQJsGcuUJZzCsEKJq98zE2NA4mokvq2QByFmhd B+Kw== X-Gm-Message-State: AGi0PuYMSTDe+nSnRD+j212dlKTcrkcn9fCD1e/C4GhWVObzTFER5nyE n/nqtx7rLytvDx4hLtaFzQ== X-Google-Smtp-Source: APiQypKfMH0XUPx9NA0nmEjS5pXKHMvADDOnF1WUquydnNa3O0PCH3lvfFxqU/W7sCEPDnP0HxvTvg== X-Received: by 2002:aca:34c6:: with SMTP id b189mr19137555oia.63.1586966851608; Wed, 15 Apr 2020 09:07:31 -0700 (PDT) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id l7sm4249117oii.26.2020.04.15.09.07.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2020 09:07:30 -0700 (PDT) Received: (nullmailer pid 9753 invoked by uid 1000); Wed, 15 Apr 2020 16:07:29 -0000 Date: Wed, 15 Apr 2020 11:07:29 -0500 From: Rob Herring To: Robert Foss Cc: Dongchun Zhu , Fabio Estevam , Andy Shevchenko , Sakari Ailus , Marco Felsch , Tomasz Figa , Maxime Ripard , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v7 1/3] media: dt-bindings: ov8856: Document YAML bindings Message-ID: <20200415160729.GA4438@bogus> References: <20200408110816.2712841-1-robert.foss@linaro.org> <20200408110816.2712841-2-robert.foss@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200408110816.2712841-2-robert.foss@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Apr 08, 2020 at 01:08:14PM +0200, Robert Foss wrote: > From: Dongchun Zhu > > This patch adds documentation of device tree in YAML schema for the > OV8856 CMOS image sensor. > > Signed-off-by: Dongchun Zhu > Signed-off-by: Robert Foss > --- > > - Changes since v6: > * Marco: remove qcom specifics from DT example > > - Changes since v5: > * Add assigned-clocks and assigned-clock-rates > * robher: dt-schema errors > > - Changes since v4: > * Fabio: Change reset-gpio to GPIO_ACTIVE_LOW, explain in description > * Add clock-lanes property to example > * robher: Fix syntax error in devicetree example > > - Changes since v3: > * robher: Fix syntax error > * robher: Removed maxItems > * Fixes yaml 'make dt-binding-check' errors > > - Changes since v2: > Fixes comments from from Andy, Tomasz, Sakari, Rob. > * Convert text documentation to YAML schema. > > - Changes since v1: > Fixes comments from Sakari, Tomasz > * Add clock-frequency and link-frequencies in DT > > .../devicetree/bindings/media/i2c/ov8856.yaml | 143 ++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 144 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/ov8856.yaml > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml > new file mode 100644 > index 000000000000..96bef5403d7e > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml > @@ -0,0 +1,143 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright (c) 2019 MediaTek Inc. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/i2c/ov8856.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Omnivision OV8856 CMOS Sensor Device Tree Bindings > + > +maintainers: > + - Ben Kao > + - Dongchun Zhu > + > +description: |- > + The Omnivision OV8856 is a high performance, 1/4-inch, 8 megapixel, CMOS > + image sensor that delivers 3264x2448 at 30fps. It provides full-frame, > + sub-sampled, and windowed 10-bit MIPI images in various formats via the > + Serial Camera Control Bus (SCCB) interface. This chip is programmable > + through I2C and two-wire SCCB. The sensor output is available via CSI-2 > + serial data output (up to 4-lane). > + > +properties: > + compatible: > + const: ovti,ov8856 > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + description: > + Input clock for the sensor. > + items: > + - const: xvclk > + > + assigned-clocks: > + description: > + Input clock for the sensor. > + > + assigned-clock-rates: > + description: > + Frequency of the xvclk clock in Hertz. These 2 should have a 'maxItems: 1' > + > + dovdd-supply: > + description: > + Definition of the regulator used as interface power supply. > + > + avdd-supply: > + description: > + Definition of the regulator used as analog power supply. > + > + dvdd-supply: > + description: > + Definition of the regulator used as digital power supply. > + > + reset-gpios: > + description: > + The phandle and specifier for the GPIO that controls sensor reset. > + This corresponds to the hardware pin XSHUTDOWN which is physically > + active low. > + > + port: > + type: object > + additionalProperties: false > + description: > + A node containing input and output port nodes with endpoint definitions Only an output, right? > + as documented in > + Documentation/devicetree/bindings/media/video-interfaces.txt > + > + properties: > + endpoint: > + type: object > + > + properties: > + clock-lanes: > + maxItems: 1 > + > + data-lanes: > + maxItems: 1 > + > + remote-endpoint: true > + > + required: > + - clock-lanes > + - data-lanes > + - remote-endpoint > + > + required: > + - endpoint > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - assigned-clocks > + - assigned-clock-rates > + - dovdd-supply > + - avdd-supply > + - dvdd-supply > + - reset-gpios > + - port > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ov8856: camera@10 { > + compatible = "ovti,ov8856"; > + reg = <0x10>; > + > + reset-gpios = <&pio 111 GPIO_ACTIVE_LOW>; > + pinctrl-names = "default"; > + pinctrl-0 = <&clk_24m_cam>; > + > + clocks = <&cam_osc>; > + clock-names = "xvclk"; > + assigned-clocks = <&cam_osc>; > + assigned-clock-rates = <19200000>; > + > + avdd-supply = <&mt6358_vcama2_reg>; > + dvdd-supply = <&mt6358_vcamd_reg>; > + dovdd-supply = <&mt6358_vcamio_reg>; > + > + port { > + wcam_out: endpoint { > + remote-endpoint = <&mipi_in_wcam>; > + clock-lanes = <0>; > + data-lanes = <1 2 3 4>; > + link-frequencies = /bits/ 64 <360000000 180000000>; > + }; > + }; > + }; > + }; > +... > \ No newline at end of file ^^^ > diff --git a/MAINTAINERS b/MAINTAINERS > index 534a8dc4f84a..3f35c6e9700a 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -12465,6 +12465,7 @@ L: linux-media@vger.kernel.org > T: git git://linuxtv.org/media_tree.git > S: Maintained > F: drivers/media/i2c/ov8856.c > +F: Documentation/devicetree/bindings/media/i2c/ov8856.yaml > > OMNIVISION OV9650 SENSOR DRIVER > M: Sakari Ailus > -- > 2.25.1 >