devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matt Porter <mporter@konsulko.com>
To: Daniel Baluta <daniel.baluta@gmail.com>
Cc: Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Anson Huang <Anson.Huang@nxp.com>,
	Leonard Crestez <leonard.crestez@nxp.com>,
	Daniel Baluta <daniel.baluta@nxp.com>,
	Devicetree List <devicetree@vger.kernel.org>,
	Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	yibin.gong@nxp.com
Subject: Re: [PATCH] arm64: dts: imx8mm: fix dma peripheral type for SAI nodes
Date: Wed, 15 Apr 2020 14:45:48 -0400	[thread overview]
Message-ID: <20200415184548.GA29919@bacon.ohporter.com> (raw)
In-Reply-To: <CAEnQRZCqeJkRPEUYL3k8seuNusLZ6QpT-X-A7E20AMHSYcmaUA@mail.gmail.com>

On Wed, Apr 15, 2020 at 09:04:43PM +0300, Daniel Baluta wrote:
> On Tue, Mar 31, 2020 at 11:36 PM Matt Porter <mporter@konsulko.com> wrote:
> >
> > The peripheral type specified in the dma phandle for each SAI node
> > is incorrect. Change it to specify the SAI peripheral.
> >
> > Signed-off-by: Matt Porter <mporter@konsulko.com>
> 
> Hi Matt,
> 
> Why do you think this is incorrect?  AFAIK script number 2 works fine
> for SAI. Can you add
> more details on what bug are you encountering?
> 
> Adding Robin the owner of SDMA.

Hi Daniel,

Thanks for the response. I was experiencing timeouts that were traced
back to dma incompletions. Changing the script at the time fixed that
issue. Now, given your response I went back and checked this again and
verified that script 2 does work for me now. I did change firmware to
the latest v4.4 from something quite old so now I'm suspecting I had
bad firmware loaded up. Does that sound plausible? In any case, I can
confirm this is not needed.

-Matt

  reply	other threads:[~2020-04-15 19:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-31 20:35 [PATCH] arm64: dts: imx8mm: fix dma peripheral type for SAI nodes Matt Porter
2020-04-15 18:04 ` Daniel Baluta
2020-04-15 18:45   ` Matt Porter [this message]
2020-04-20  7:21     ` Robin Gong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200415184548.GA29919@bacon.ohporter.com \
    --to=mporter@konsulko.com \
    --cc=Anson.Huang@nxp.com \
    --cc=daniel.baluta@gmail.com \
    --cc=daniel.baluta@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=leonard.crestez@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=yibin.gong@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).