From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1348BC2BB85 for ; Wed, 15 Apr 2020 19:07:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E3C8C20768 for ; Wed, 15 Apr 2020 19:07:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=konsulko.com header.i=@konsulko.com header.b="ZZ+QkkHQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406349AbgDOTHe (ORCPT ); Wed, 15 Apr 2020 15:07:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1416852AbgDOSpx (ORCPT ); Wed, 15 Apr 2020 14:45:53 -0400 Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0910AC061A0E for ; Wed, 15 Apr 2020 11:45:53 -0700 (PDT) Received: by mail-qk1-x744.google.com with SMTP id g74so18451732qke.13 for ; Wed, 15 Apr 2020 11:45:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=PBQchXV5h+GZBKvpNdyH5xHjxEMUXqW14Qdp3U1Zwvc=; b=ZZ+QkkHQTKXaxC1zVQQ/q2prKNkCzlHQabzEGSspciFAhzhlpUCTKgjhDQ6pOYiBfh 51t2+Gv6VtlAUaVxJo5ggnMII7sRvKSwKbUSot03CmpO+mHUrmC9f4HNo4rmDByEUH+g VZZZUtgfWDK5ODUYpfCym8yp/CWQWcErBKkAE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=PBQchXV5h+GZBKvpNdyH5xHjxEMUXqW14Qdp3U1Zwvc=; b=cI0Bcg1rrUToYPVdN2I4Mb9hfINCEKuzXUa4JsJmsLybyC/wTwC/eaAvF8ezcbIhpH Bj40UNVnt9KNG3fgxa9CCQVO5h1Rsk2f2aKRs6iWmBQ0T9rh33/o2LGebdzpgvXrlJmS Z1VrgEyCmIZxGWQLMeF8ccPTfZzSgfIN6kGlIq27CKrmfIWO22NskSZfPtjiM+kKrMvJ VNkeqs0VGkR6NXvo97l2atNjC9PMw4DRkYzCHAUhr3AHKyG+q+7xbNNKWCN+wT7TGCKW yuBiMjvW50hC1iqhQDNFu6O7pqftDAJk+zbR5LbYgDTTAvzcwgocxznsPZhwJ8Cb91n4 tcCQ== X-Gm-Message-State: AGi0PuZjc3Dh21lyCEzU6MgVYpuKUlea/BmrDpbC97xUZbhd8ZAM6eop r2DdFbS6HVq2pkIbZ9SV3RdBrA== X-Google-Smtp-Source: APiQypKIGgPLSnD/hI0ZniHM0EIt5UECe27dLHztwyrc5P2U+rUjJibDWwAjqlDUrk55s9PeRu8flg== X-Received: by 2002:a37:5a02:: with SMTP id o2mr27246247qkb.380.1586976352184; Wed, 15 Apr 2020 11:45:52 -0700 (PDT) Received: from bacon.ohporter.com ([2605:a000:1234:47c6:a553:c33f:1562:b0b1]) by smtp.gmail.com with ESMTPSA id p31sm11105853qtf.11.2020.04.15.11.45.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2020 11:45:51 -0700 (PDT) Date: Wed, 15 Apr 2020 14:45:48 -0400 From: Matt Porter To: Daniel Baluta Cc: Shawn Guo , Sascha Hauer , Rob Herring , Mark Rutland , Anson Huang , Leonard Crestez , Daniel Baluta , Devicetree List , Linux ARM Kernel List , Linux Kernel Mailing List , yibin.gong@nxp.com Subject: Re: [PATCH] arm64: dts: imx8mm: fix dma peripheral type for SAI nodes Message-ID: <20200415184548.GA29919@bacon.ohporter.com> References: <20200331203551.20914-1-mporter@konsulko.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Apr 15, 2020 at 09:04:43PM +0300, Daniel Baluta wrote: > On Tue, Mar 31, 2020 at 11:36 PM Matt Porter wrote: > > > > The peripheral type specified in the dma phandle for each SAI node > > is incorrect. Change it to specify the SAI peripheral. > > > > Signed-off-by: Matt Porter > > Hi Matt, > > Why do you think this is incorrect? AFAIK script number 2 works fine > for SAI. Can you add > more details on what bug are you encountering? > > Adding Robin the owner of SDMA. Hi Daniel, Thanks for the response. I was experiencing timeouts that were traced back to dma incompletions. Changing the script at the time fixed that issue. Now, given your response I went back and checked this again and verified that script 2 does work for me now. I did change firmware to the latest v4.4 from something quite old so now I'm suspecting I had bad firmware loaded up. Does that sound plausible? In any case, I can confirm this is not needed. -Matt