From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Bastian Krause <bst@pengutronix.de>
Cc: linux-rtc@vger.kernel.org,
Alessandro Zummo <a.zummo@towertech.it>,
Rob Herring <robh+dt@kernel.org>,
Arnaud Ebalard <arno@natisbad.org>, Marek Vasut <marex@denx.de>,
devicetree@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH 2/3] dt-bindings: rtc: add chargeable flag for rx8130
Date: Wed, 15 Apr 2020 20:56:09 +0200 [thread overview]
Message-ID: <20200415185609.GP34509@piout.net> (raw)
In-Reply-To: <20200415163701.21989-2-bst@pengutronix.de>
On 15/04/2020 18:37:00+0200, Bastian Krause wrote:
> Signed-off-by: Bastian Krause <bst@pengutronix.de>
> ---
> Documentation/devicetree/bindings/rtc/rtc-ds1307.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/rtc/rtc-ds1307.txt b/Documentation/devicetree/bindings/rtc/rtc-ds1307.txt
> index 66f0a31ae9ce..987a0c9e0cd7 100644
> --- a/Documentation/devicetree/bindings/rtc/rtc-ds1307.txt
> +++ b/Documentation/devicetree/bindings/rtc/rtc-ds1307.txt
> @@ -34,6 +34,9 @@ Optional properties:
> - trickle-diode-disable : ds1339, ds1340 and ds 1388 only
> Do not use internal trickle charger diode
> Should be given if internal trickle charger diode should be disabled
> +- aux-voltage-chargeable: rx8130 only
> + Epsons's rx8130 supports a backup battery/supercap.
> + This flag tells whether the battery/supercap is chargeable or not.
>
I think we should make that a generic property and this should supersede
trickle-diode-disable which is a bit wonky as I would prefer the default
to be disabled instead of enabled with the current semantics.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-04-15 19:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 16:36 [RESEND PATCH v2 1/3] rtc: ds1307: Enable battery backup on RX8130 Bastian Krause
2020-04-15 16:37 ` [PATCH 2/3] dt-bindings: rtc: add chargeable flag for rx8130 Bastian Krause
2020-04-15 16:44 ` Uwe Kleine-König
2020-04-15 18:56 ` Alexandre Belloni [this message]
2020-08-24 11:31 ` Bastian Krause
2020-08-24 13:32 ` Bastian Krause
2020-08-25 15:32 ` Alexandre Belloni
2020-08-26 8:13 ` Bastian Krause
2020-09-02 19:18 ` Alexandre Belloni
2020-04-15 16:37 ` [PATCH 3/3] rtc: ds1307: make backup battery chargeable optionally Bastian Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415185609.GP34509@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=arno@natisbad.org \
--cc=bst@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-rtc@vger.kernel.org \
--cc=marex@denx.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).