From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55FFBC2BA2B for ; Thu, 16 Apr 2020 20:59:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 31C6B2222D for ; Thu, 16 Apr 2020 20:59:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Q+5EH2tP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727983AbgDPU65 (ORCPT ); Thu, 16 Apr 2020 16:58:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726296AbgDPU6t (ORCPT ); Thu, 16 Apr 2020 16:58:49 -0400 Received: from mail-qv1-xf49.google.com (mail-qv1-xf49.google.com [IPv6:2607:f8b0:4864:20::f49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84412C061A0C for ; Thu, 16 Apr 2020 13:58:48 -0700 (PDT) Received: by mail-qv1-xf49.google.com with SMTP id d2so209748qve.11 for ; Thu, 16 Apr 2020 13:58:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:subject:from:to:cc; bh=HqZDwf9Q7C67M/mDRl+pQv0rP1w37UTSZ4kbAHBt66Q=; b=Q+5EH2tPZsSLAErwg1IspceG+J61zlJdooxXpvm+MCgII/FqHm3TK71amylmcYc81E gAFWt3RwNcD9ANYF1lGGDwPFLDvNU8I05y+c32s+MZMppFovDfk0zt0q3onqFxPrGrWh 8oWvRoMmHfgijEgT8fP911VtFZdtK809EKhcrWRQ56cbCjDHgzeNPCI6/eF05YSTgraa 1TlZLlAcr1NHnKy9mUuL/AvUjBqWjBE83uqEjNjYMjc9/4jdiudKup/qav+Dk3uQE5FJ R3fMgfXtI0ecmS/1Gq47TZOj11vFyb6Q8B/JkAAXV935Ivibwxm3tnmKAzkvdgiG9P/i rJnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version:subject :from:to:cc; bh=HqZDwf9Q7C67M/mDRl+pQv0rP1w37UTSZ4kbAHBt66Q=; b=L0/6XTMdyzssKjYtxkelpiBbYM1MEyB4H5UNwssKieBZFpxmWiric5aIdDY3QyJAk1 kjJ52/ieRByfvCzE3SPVreVk1bhl+FPhNG3vMfEyG3iXyhqbXTNL516+sFYf3B6e8WVK /upqSUiVNn6LNNBK77DFBOZxIRa5nwj+zpidmk54ziJYRqzbUyysjIp734/DjMPHVvGU mcvnsZzFKiS+9psRW1EwGlkRZ0EjX3kUZ9NkcjAMsKTm+ZT9A/njK+Lf0ibcYvzccxP3 knuTJR3c2zHgC9fb5DHkgTCVTGkmjZ4ShWWrDlcAZCGHMF5OdmPYnVoPaaK9j4oFDyaj ld5A== X-Gm-Message-State: AGi0PuaV1hHWv2yB21ASyAMcfNjSrIWmwtf4TsO5OeqRs5MWO2a+gPMJ /A7ehwqVT/3xYpiln3lG2rHsTvY+H5uKA4k= X-Google-Smtp-Source: APiQypI6kmzfdqdUBhHY3FyAluii9jxd30OtvsbuQwt35VUya6k56Nxe6Byxot+OqIm2luH3L29mv4Kf+gFk+aQ= X-Received: by 2002:a05:620a:7e8:: with SMTP id k8mr22217820qkk.183.1587070727685; Thu, 16 Apr 2020 13:58:47 -0700 (PDT) Date: Thu, 16 Apr 2020 13:58:38 -0700 In-Reply-To: Message-Id: <20200416205838.161894-1-saravanak@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.26.1.301.g55bc3eb7cb9-goog Subject: [PATCH v1] of: property: Don't retry device_link_add() upon failure From: Saravana Kannan To: Rob Herring , Frank Rowand Cc: Saravana Kannan , Nicolas Saenz Julienne , Greg Kroah-Hartman , kernel-team@android.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org When of_link_to_phandle() was implemented initially, there was no way to tell if device_link_add() was failing because the supplier device hasn't been parsed yet, hasn't been added yet, the links were creating a cycle, etc. Some of these were transient errors that'd go away at a later point. However, with the current set of improved checks, if device_link_add() fails, it'll only be for permanent errors like cycles or out-of-memory errors. Also, with the addition of DL_FLAG_SYNC_STATE_ONLY flag [1] to device links, all the valid dependency cycles due to "proxy" device links (needed for correctness of sync_state() device callback) will never fail device_link_add() due to cycles. So, continuing to retry failing device links (by returning -EAGAIN) is no longer useful. At worst, it prevents platforms from setting fw_devlink=on (or better) because it prevents proper boot up. So, let's not do that anymore. [1] - https://lore.kernel.org/lkml/20191028220027.251605-1-saravanak@google.com/ Cc: Nicolas Saenz Julienne Cc: Greg Kroah-Hartman Signed-off-by: Saravana Kannan --- drivers/of/property.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/property.c b/drivers/of/property.c index 252e4f600155..ee1bc267f975 100644 --- a/drivers/of/property.c +++ b/drivers/of/property.c @@ -1074,7 +1074,7 @@ static int of_link_to_phandle(struct device *dev, struct device_node *sup_np, return -EAGAIN; } if (!device_link_add(dev, sup_dev, dl_flags)) - ret = -EAGAIN; + ret = -EINVAL; put_device(sup_dev); return ret; } -- 2.26.1.301.g55bc3eb7cb9-goog