From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81F36C352BE for ; Thu, 16 Apr 2020 19:53:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6BF502063A for ; Thu, 16 Apr 2020 19:53:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728358AbgDPTxe (ORCPT ); Thu, 16 Apr 2020 15:53:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728199AbgDPTxd (ORCPT ); Thu, 16 Apr 2020 15:53:33 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05962C061A0C; Thu, 16 Apr 2020 12:53:32 -0700 (PDT) Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 49C832A23D7; Thu, 16 Apr 2020 20:53:31 +0100 (BST) Date: Thu, 16 Apr 2020 21:53:28 +0200 From: Boris Brezillon To: Christophe Kerello Cc: , , , , , , , marex@denx.de, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH v2 03/12] bus: stm32-fmc2-ebi: add STM32 FMC2 EBI controller driver Message-ID: <20200416215328.53982fef@collabora.com> In-Reply-To: <1586966256-29548-4-git-send-email-christophe.kerello@st.com> References: <1586966256-29548-1-git-send-email-christophe.kerello@st.com> <1586966256-29548-4-git-send-email-christophe.kerello@st.com> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 15 Apr 2020 17:57:27 +0200 Christophe Kerello wrote: > The driver adds the support for the STMicroelectronics FMC2 EBI controller > found on STM32MP SOCs. > > Signed-off-by: Christophe Kerello > Tested-by: Marek Vasut > --- > Changes in v2: > - call 2 APIs to manage FMC2 enable/disable instead of ops > - call 2 APIs to manage FMC2 NWAIT shared signal instead of ops > > drivers/bus/Kconfig | 11 + > drivers/bus/Makefile | 1 + > drivers/bus/stm32-fmc2-ebi.c | 1091 ++++++++++++++++++++++++++++++++++++++++++ Hm, I see that other memory bus controller drivers are placed under drivers/memory/, any reason for choosing drivers/bus/? If that's where we want to have all generic memory bus controllers to live it might be worth moving existing drivers to the drivers/bus/ directory at some point.