devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Chris Ruehl <chris.ruehl@gtsys.com.hk>
Cc: devicetree@vger.kernel.org, "Hartmut Knaack" <knaack.h@gmx.de>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Peter Meerwald-Stadler" <pmeerw@pmeerw.net>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Steve Winslow" <swinslow@gmail.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/3] iio: documentation ltc2632_chip_info add num_channels
Date: Sat, 18 Apr 2020 16:46:06 +0100	[thread overview]
Message-ID: <20200418164606.42ad772f@archlinux> (raw)
In-Reply-To: <20200416012016.21422-2-chris.ruehl@gtsys.com.hk>

On Thu, 16 Apr 2020 09:20:09 +0800
Chris Ruehl <chris.ruehl@gtsys.com.hk> wrote:

> The documentation for ltc_2632_chip_info missed the desciption for the
> num_channels. This trivial patch adds it.
> 
> Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>

Please make sure to pick up tags from earlier versions.  Uwe
gave one to v3 + added a fixes tag to make it explicit which
commit introduced the field but didn't document it.

I'm in two minds on whether to leave that in the commit when I
take it as the AI bot may well pick the patch up and backport
it which seems a bit pointless if harmless!

Still if you respin please add it and I can make up my mind then.
In meantime the series needs DT review.

> ---
> v4:
> Fix commit text.
> 
>  drivers/iio/dac/ltc2632.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/dac/ltc2632.c b/drivers/iio/dac/ltc2632.c
> index 7adc91056aa1..2a84ea654645 100644
> --- a/drivers/iio/dac/ltc2632.c
> +++ b/drivers/iio/dac/ltc2632.c
> @@ -24,6 +24,7 @@
>  /**
>   * struct ltc2632_chip_info - chip specific information
>   * @channels:		channel spec for the DAC
> + * @num_channels:	DAC channel count of the chip
>   * @vref_mv:		internal reference voltage
>   */
>  struct ltc2632_chip_info {


  reply	other threads:[~2020-04-18 15:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-16  1:20 [PATCH v4] iio: patch set ltc2632 Chris Ruehl
2020-04-16  1:20 ` [PATCH v4 1/3] iio: documentation ltc2632_chip_info add num_channels Chris Ruehl
2020-04-18 15:46   ` Jonathan Cameron [this message]
2020-04-16  1:20 ` [PATCH v4 2/3] iio: DAC extension for ltc2634-12/10/8 Chris Ruehl
2020-04-16  6:56   ` Uwe Kleine-König
2020-04-16  7:14     ` Chris Ruehl
2020-04-17 10:27       ` Andy Shevchenko
2020-04-17 10:56         ` Lars-Peter Clausen
2020-04-17 10:57           ` Andy Shevchenko
2020-04-16  1:20 ` [PATCH v4 3/3] iio/dac: convert ltc2632.txt to lltc,ltc2632.yaml Chris Ruehl
2020-04-18 15:53   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200418164606.42ad772f@archlinux \
    --to=jic23@kernel.org \
    --cc=chris.ruehl@gtsys.com.hk \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=swinslow@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).