From: Lee Jones <lee.jones@linaro.org>
To: kgunda@codeaurora.org
Cc: Rob Herring <robh@kernel.org>,
bjorn.andersson@linaro.org, jingoohan1@gmail.com,
b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org,
daniel.thompson@linaro.org, jacek.anaszewski@gmail.com,
pavel@ucw.cz, mark.rutland@arm.com, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Dan Murphy <dmurphy@ti.com>,
linux-arm-msm@vger.kernel.org,
Subbaraman Narayanamurthy <subbaram@codeaurora.org>
Subject: Re: [PATCH V5 1/4] backlight: qcom-wled: convert the wled bindings to .yaml format
Date: Mon, 20 Apr 2020 08:27:27 +0100 [thread overview]
Message-ID: <20200420072727.GI3737@dell> (raw)
In-Reply-To: <557e8bd874256271174402b5faba9c90@codeaurora.org>
On Fri, 17 Apr 2020, kgunda@codeaurora.org wrote:
> On 2020-04-15 20:39, Rob Herring wrote:
> > On Tue, Apr 07, 2020 at 09:17:07PM +0530, Kiran Gunda wrote:
> > > Convert the qcom-wled bindings from .txt to .yaml format.
> > > Also replace PM8941 to WLED3 and PMI8998 to WLED4.
> > >
> > > Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
> > > Signed-off-by: Subbaraman Narayanamurthy <subbaram@codeaurora.org>
> > > Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> > > ---
> > > .../bindings/leds/backlight/qcom-wled.txt | 154
> > > ----------------
> > > .../bindings/leds/backlight/qcom-wled.yaml | 201
> > > +++++++++++++++++++++
> > > 2 files changed, 201 insertions(+), 154 deletions(-)
> > > delete mode 100644
> > > Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt
> > > create mode 100644
> > > Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml
[...]
> > > + interrupt-names:
> > > + items:
> > > + - const: ovp
> > > + - const: short
> >
> > Move these 2 props to the main section adding a 'minItems: 1'. Then just
> > define 'minItems: 2' here and 'maxItems: 1' in the 'then' clause.
> >
> > > +
> > > +required:
> > > + - compatible
> > > + - reg
> > > + - label
> >
> > Add:
> >
> > additionalProperties: false
> >
> > > +
> > > +examples:
> > > + - |
> > > + backlight@d800 {
> > > + compatible = "qcom,pm8941-wled";
> > > + reg = <0xd800 0x100>;
> > > + label = "backlight";
> > > +
> > > + qcom,cs-out;
> > > + qcom,current-limit = <20>;
> > > + qcom,current-boost-limit = <805>;
> > > + qcom,switching-freq = <1600>;
> > > + qcom,ovp = <29>;
> > > + qcom,num-strings = <2>;
> > > + qcom,enabled-strings = <0 1>;
> > > + };
> Thanks for reviewing. I will submit the next revision with all the fixes.
Please trim your replies.
Also, if you agree with all of the review comments, there really is no
need to reply and/or thank the reviewer. Simply submit a subsequent
set with a bumped version indicator.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-04-20 7:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 15:47 [PATCH V5 0/4] Add support for WLED5 Kiran Gunda
2020-04-07 15:47 ` [PATCH V5 1/4] backlight: qcom-wled: convert the wled bindings to .yaml format Kiran Gunda
2020-04-15 15:09 ` Rob Herring
2020-04-17 11:53 ` kgunda
2020-04-20 7:27 ` Lee Jones [this message]
2020-04-07 15:47 ` [PATCH V5 2/4] backlight: qcom-wled: Add callback functions Kiran Gunda
2020-04-20 16:17 ` Daniel Thompson
2020-04-07 15:47 ` [PATCH V5 3/4] backlight: qcom-wled: Add WLED5 bindings Kiran Gunda
2020-04-15 15:12 ` Rob Herring
2020-04-17 11:54 ` kgunda
2020-04-20 16:20 ` Daniel Thompson
2020-04-07 15:47 ` [PATCH V5 4/4] backlight: qcom-wled: Add support for WLED5 peripheral that is present on PM8150L PMICs Kiran Gunda
2020-04-20 16:37 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420072727.GI3737@dell \
--to=lee.jones@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=kgunda@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
--cc=subbaram@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).